2014-12-06 18:58:29

by Murilo Opsfelder Araujo

[permalink] [raw]
Subject: next-20141204 crashing on ext4_fill_super()

Hello, everyone.

next-20141204 started crashing on my laptop with the following error right
after I enter my disk encryption password:

http://opsfelder.com/~murilo/lkml/next-20141204_crash.jpg

The previous version next-20141203 was working just fine. next-20141205 is
also crashing.

Git-bisect pointed me to the commit [1]
d0079b903022160fee1d673a3c1f3154c84385eb "ext4:
ext4_da_convert_inline_data_to_extent drop locked page after error".

I tried reverting it from next-20141204 but got no luck.

I'd be happy if someone can help me getting this fixed.

Thanks in advance.

[1]
commit d0079b903022160fee1d673a3c1f3154c84385eb
Author: Dmitry Monakhov <[email protected]>
Date: Tue Dec 2 18:46:20 2014 -0500

ext4: ext4_da_convert_inline_data_to_extent drop locked page after error

Testcase:
xfstests generic/270
MKFS_OPTIONS="-q -I 256 -O inline_data,64bit"

Call Trace:
[<ffffffff81144c76>] lock_page+0x35/0x39 -------> DEADLOCK
[<ffffffff81145260>] pagecache_get_page+0x65/0x15a
[<ffffffff811507fc>] truncate_inode_pages_range+0x1db/0x45c
[<ffffffff8120ea63>] ? ext4_da_get_block_prep+0x439/0x4b6
[<ffffffff811b29b7>] ? __block_write_begin+0x284/0x29c
[<ffffffff8120e62a>] ? ext4_change_inode_journal_flag+0x16b/0x16b
[<ffffffff81150af0>] truncate_inode_pages+0x12/0x14
[<ffffffff81247cb4>] ext4_truncate_failed_write+0x19/0x25
[<ffffffff812488cf>] ext4_da_write_inline_data_begin+0x196/0x31c
[<ffffffff81210dad>] ext4_da_write_begin+0x189/0x302
[<ffffffff810c07ac>] ? trace_hardirqs_on+0xd/0xf
[<ffffffff810ddd13>] ? read_seqcount_begin.clone.1+0x9f/0xcc
[<ffffffff8114309d>] generic_perform_write+0xc7/0x1c6
[<ffffffff810c040e>] ? mark_held_locks+0x59/0x77
[<ffffffff811445d1>] __generic_file_write_iter+0x17f/0x1c5
[<ffffffff8120726b>] ext4_file_write_iter+0x2a5/0x354
[<ffffffff81185656>] ? file_start_write+0x2a/0x2c
[<ffffffff8107bcdb>] ? bad_area_nosemaphore+0x13/0x15
[<ffffffff811858ce>] new_sync_write+0x8a/0xb2
[<ffffffff81186e7b>] vfs_write+0xb5/0x14d
[<ffffffff81186ffb>] SyS_write+0x5c/0x8c
[<ffffffff816f2529>] system_call_fastpath+0x12/0x17

Signed-off-by: Dmitry Monakhov <[email protected]>
Signed-off-by: Theodore Ts'o <[email protected]>

--
Murilo


2014-12-06 22:16:28

by Theodore Ts'o

[permalink] [raw]
Subject: Re: next-20141204 crashing on ext4_fill_super()

Please revert fdfe07398761 and that should the crashes; this will be
fixed in the next linux-next release. My apologies for the inconvenience.

- Ted

2014-12-07 13:58:50

by Murilo Opsfelder Araujo

[permalink] [raw]
Subject: Re: next-20141204 crashing on ext4_fill_super()

On Saturday, December 06, 2014 05:16:21 PM Theodore Ts'o wrote:
> Please revert fdfe07398761 and that should the crashes; this will be
> fixed in the next linux-next release. My apologies for the inconvenience.
>
> - Ted
Hello, Ted.

Reverting that commit worked. No need to apologize.

Thanks a lot for the quick reply.

--
Murilo