2023-07-27 14:52:07

by Mark O'Donovan

Subject: [PATCH 1/2] nvme-auth: unlock mutex in one place only

Signed-off-by: Mark O'Donovan <[email protected]>
---
drivers/nvme/host/auth.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c
index daf5d144a8ea..e1a98647c3a2 100644
--- a/drivers/nvme/host/auth.c
+++ b/drivers/nvme/host/auth.c
@@ -758,12 +758,11 @@ static void nvme_queue_auth_work(struct work_struct *work)
__func__, chap->qid);
mutex_lock(&ctrl->dhchap_auth_mutex);
ret = nvme_auth_dhchap_setup_host_response(ctrl, chap);
+ mutex_unlock(&ctrl->dhchap_auth_mutex);
if (ret) {
- mutex_unlock(&ctrl->dhchap_auth_mutex);
chap->error = ret;
goto fail2;
}
- mutex_unlock(&ctrl->dhchap_auth_mutex);

/* DH-HMAC-CHAP Step 3: send reply */
dev_dbg(ctrl->device, "%s: qid %d send reply\n",
--
2.39.2

2023-07-31 06:14:42

by Christoph Hellwig

Subject: Re: [PATCH 1/2] nvme-auth: unlock mutex in one place only

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>

2023-07-31 13:57:41

by Sagi Grimberg

Subject: Re: [PATCH 1/2] nvme-auth: unlock mutex in one place only

Reviewed-by: Sagi Grimberg <[email protected]>

2023-07-31 14:13:13

by Christoph Hellwig

Subject: Re: [PATCH 1/2] nvme-auth: unlock mutex in one place only

On Mon, Jul 31, 2023 at 02:00:37PM +0200, Markus Elfring wrote:
> Are imperative change descriptions still preferred?

It doesn't fucking matter. Please stop spamming nvme contributors.