2019-04-06 11:01:25

by Hariprasad Kelam

Subject: [PATCH] f2fs: data: fix warning Using plain integer as NULL pointer

changed passing function argument "0 to NULL" to fix below sparse
warning

fs/f2fs/data.c:426:47: warning: Using plain integer as NULL pointer

Signed-off-by: Hariprasad Kelam <[email protected]>
---
fs/f2fs/data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 97279441..15a2381 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -423,7 +423,7 @@ static void __submit_merged_write_cond(struct f2fs_sb_info *sbi,

void f2fs_submit_merged_write(struct f2fs_sb_info *sbi, enum page_type type)
{
- __submit_merged_write_cond(sbi, NULL, 0, 0, type, true);
+ __submit_merged_write_cond(sbi, NULL, NULL, 0, type, true);
}

void f2fs_submit_merged_write_cond(struct f2fs_sb_info *sbi,
--
2.7.4

2019-04-06 19:07:46

by Mukesh Ojha

Subject: Re: [PATCH] f2fs: data: fix warning Using plain integer as NULL pointer

On 4/6/2019 4:29 PM, Hariprasad Kelam wrote:
> changed passing function argument "0 to NULL" to fix below sparse
> warning
>
> fs/f2fs/data.c:426:47: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Hariprasad Kelam <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh

> ---
> fs/f2fs/data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 97279441..15a2381 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -423,7 +423,7 @@ static void __submit_merged_write_cond(struct f2fs_sb_info *sbi,
>
> void f2fs_submit_merged_write(struct f2fs_sb_info *sbi, enum page_type type)
> {
> - __submit_merged_write_cond(sbi, NULL, 0, 0, type, true);
> + __submit_merged_write_cond(sbi, NULL, NULL, 0, type, true);
> }
>
> void f2fs_submit_merged_write_cond(struct f2fs_sb_info *sbi,

2019-04-08 11:19:49

by Chao Yu

Subject: Re: [PATCH] f2fs: data: fix warning Using plain integer as NULL pointer

On 2019/4/6 18:59, Hariprasad Kelam wrote:
> changed passing function argument "0 to NULL" to fix below sparse
> warning
>
> fs/f2fs/data.c:426:47: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Hariprasad Kelam <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,