2023-12-14 20:58:53

by Sergey Shtylyov

[permalink] [raw]
Subject: Re: [PATCH net-next v2 06/21] net: ravb: Assert/de-assert reset on suspend/resume

On 12/14/23 2:45 PM, Claudiu wrote:

> From: Claudiu Beznea <[email protected]>
>
> RZ/G3S can go to deep sleep states where power to most of the SoC parts is
> off. When resuming from such a state, the Ethernet controller needs to be
> reinitialized. De-asserting the reset signal for it should also be done.
> Thus, add reset assert/de-assert on suspend/resume functions.
>
> On the resume function, the de-assert was not reverted in case of failures
> to give the user a chance to restore the interface (e.g., bringing down/up
> the interface) in case suspend/resume failed.
>
> Signed-off-by: Claudiu Beznea <[email protected]>

Reviewed-by: Sergey Shtylyov <[email protected]>

[...]

MBR, Sergey