2014-07-03 19:16:12

by Pawel Lebioda

[permalink] [raw]

Subject: [PATCH] staging: nvec: insert blank lines after declarations

---

Hi,

This patch fixes coding style warnings reported by checkpatch.pl:
"Missing a blank line after declarations".

Regards
Pawel Lebioda

Signed-off-by: Pawel Lebioda <[email protected]>
drivers/staging/nvec/nvec_paz00.c | 1 +
drivers/staging/nvec/nvec_power.c | 1 +
drivers/staging/nvec/nvec_ps2.c | 2 ++
3 files changed, 4 insertions(+)

diff --git a/drivers/staging/nvec/nvec_paz00.c b/drivers/staging/nvec/nvec_paz00.c
index 934b796..e2e675a 100644
--- a/drivers/staging/nvec/nvec_paz00.c
+++ b/drivers/staging/nvec/nvec_paz00.c
@@ -35,6 +35,7 @@ static void nvec_led_brightness_set(struct led_classdev *led_cdev,
{
struct nvec_led *led = to_nvec_led(led_cdev);
unsigned char buf[] = NVEC_LED_REQ;
+
buf[4] = value;

nvec_write_async(led->nvec, buf, sizeof(buf));
diff --git a/drivers/staging/nvec/nvec_power.c b/drivers/staging/nvec/nvec_power.c
index aacfcd6..6446e15 100644
--- a/drivers/staging/nvec/nvec_power.c
+++ b/drivers/staging/nvec/nvec_power.c
@@ -226,6 +226,7 @@ static int nvec_power_get_property(struct power_supply *psy,
union power_supply_propval *val)
{
struct nvec_power *power = dev_get_drvdata(psy->dev->parent);
+
switch (psp) {
case POWER_SUPPLY_PROP_ONLINE:
val->intval = power->on;
diff --git a/drivers/staging/nvec/nvec_ps2.c b/drivers/staging/nvec/nvec_ps2.c
index 45b2f13..f56f1db 100644
--- a/drivers/staging/nvec/nvec_ps2.c
+++ b/drivers/staging/nvec/nvec_ps2.c
@@ -53,12 +53,14 @@ static struct nvec_ps2 ps2_dev;
static int ps2_startstreaming(struct serio *ser_dev)
{
unsigned char buf[] = { NVEC_PS2, AUTO_RECEIVE_N, PACKET_SIZE };
+
return nvec_write_async(ps2_dev.nvec, buf, sizeof(buf));
}

static void ps2_stopstreaming(struct serio *ser_dev)
{
unsigned char buf[] = { NVEC_PS2, CANCEL_AUTO_RECEIVE };
+
nvec_write_async(ps2_dev.nvec, buf, sizeof(buf));
}

2014-07-04 07:39:57

by Marc Dietrich

[permalink] [raw]

Subject: Re: [PATCH] staging: nvec: insert blank lines after declarations

---

Am Donnerstag, 3. Juli 2014, 21:15:57 schrieb Pawel Lebioda:
> Hi,
>
> This patch fixes coding style warnings reported by checkpatch.pl:
> "Missing a blank line after declarations".

thanks. Looking at the checkpatch output, its requirement of at
least 4 lines of help text looks like a bit overkill though.

> Signed-off-by: Pawel Lebioda <[email protected]>
> drivers/staging/nvec/nvec_paz00.c | 1 +
> drivers/staging/nvec/nvec_power.c | 1 +
> drivers/staging/nvec/nvec_ps2.c | 2 ++
> 3 files changed, 4 insertions(+)

Acked-by: Marc Dietrich <[email protected]>

---

Attachments:

signature.asc (490.00 B)
This is a digitally signed message part.