2007-10-13 19:03:57

by Jeff Garzik

Subject: [PATCH] drivers/block/cpqarray,cciss: kill unused var

The recent bio work and subsequent fixups created unused variables.

Signed-off-by: Jeff Garzik <[email protected]>
---
drivers/block/cciss.c | 1 -
drivers/block/cpqarray.c | 3 +--
2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 28d1457..27401d6 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -1191,7 +1191,6 @@ static inline void complete_buffers(struct bio *bio, int status)
{
while (bio) {
struct bio *xbh = bio->bi_next;
- int nr_sectors = bio_sectors(bio);

bio->bi_next = NULL;
bio_endio(bio, status ? 0 : -EIO);
diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c
index 3853c9a..568603d 100644
--- a/drivers/block/cpqarray.c
+++ b/drivers/block/cpqarray.c
@@ -981,9 +981,8 @@ static void start_io(ctlr_info_t *h)
static inline void complete_buffers(struct bio *bio, int ok)
{
struct bio *xbh;
- while(bio) {
- int nr_sectors = bio_sectors(bio);

+ while (bio) {
xbh = bio->bi_next;
bio->bi_next = NULL;

2007-10-15 07:53:18

by Jens Axboe

Subject: Re: [PATCH] drivers/block/cpqarray,cciss: kill unused var

On Sat, Oct 13 2007, Jeff Garzik wrote:
> The recent bio work and subsequent fixups created unused variables.
>
> Signed-off-by: Jeff Garzik <[email protected]>
> ---
> drivers/block/cciss.c | 1 -
> drivers/block/cpqarray.c | 3 +--
> 2 files changed, 1 insertion(+), 3 deletions(-)

Thanks Jeff, applied.

--
Jens Axboe

2007-10-16 14:55:53

by Mike Miller

Subject: RE: [PATCH] drivers/block/cpqarray,cciss: kill unused var

> -----Original Message-----
> From: Jeff Garzik [mailto:[email protected]]
> Sent: Saturday, October 13, 2007 2:04 PM
> To: Andrew Morton; Linus Torvalds
> Cc: LKML; [email protected]; ISS StorageDev
> Subject: [PATCH] drivers/block/cpqarray,cciss: kill unused var
>
> The recent bio work and subsequent fixups created unused variables.
>
> Signed-off-by: Jeff Garzik <[email protected]>

Acked-by: Mike Miller <[email protected]>

> ---
> drivers/block/cciss.c | 1 -
> drivers/block/cpqarray.c | 3 +--
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> index 28d1457..27401d6 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -1191,7 +1191,6 @@ static inline void
> complete_buffers(struct bio *bio, int status) {
> while (bio) {
> struct bio *xbh = bio->bi_next;
> - int nr_sectors = bio_sectors(bio);
>
> bio->bi_next = NULL;
> bio_endio(bio, status ? 0 : -EIO);
> diff --git a/drivers/block/cpqarray.c
> b/drivers/block/cpqarray.c index 3853c9a..568603d 100644
> --- a/drivers/block/cpqarray.c
> +++ b/drivers/block/cpqarray.c
> @@ -981,9 +981,8 @@ static void start_io(ctlr_info_t *h)
> static inline void complete_buffers(struct bio *bio, int ok) {
> struct bio *xbh;
> - while(bio) {
> - int nr_sectors = bio_sectors(bio);
>
> + while (bio) {
> xbh = bio->bi_next;
> bio->bi_next = NULL;
>
>