Hi Greg,
Commits
97c6166001ef ("Staging: rtlwifi: Remove unused variable and the code")
357f862bd214 ("staging: comedi: adv_pci1760: fix typo in comments")
23cb746b5e9d ("staging: rtl8192u: Replace mdelay with msleep in rtl8192_usb_probe")
beac4303532f ("Staging: vt6656: Fix unnecessary 'out of memory' message")
are missing a Signed-off-by from their committer.
--
Cheers,
Stephen Rothwell
On Wed, Jan 10, 2018 at 07:18:30AM +1100, Stephen Rothwell wrote:
> Hi Greg,
>
> Commits
>
> 97c6166001ef ("Staging: rtlwifi: Remove unused variable and the code")
> 357f862bd214 ("staging: comedi: adv_pci1760: fix typo in comments")
> 23cb746b5e9d ("staging: rtl8192u: Replace mdelay with msleep in rtl8192_usb_probe")
> beac4303532f ("Staging: vt6656: Fix unnecessary 'out of memory' message")
>
> are missing a Signed-off-by from their committer.
Crap, this has been a long month, sorry about that. I'll go work on
getting that git hook in place to prevent this from happening again...
greg k-h
On Wed, Nov 29, 2017 at 09:59:16AM +1100, Stephen Rothwell wrote:
> Hi Greg,
>
> On Tue, 28 Nov 2017 20:41:39 +0100 Greg KH <[email protected]> wrote:
> >
> > I need to set up a git hook for this :(
>
> I couldn't find an appropriate hook for fetching or merging other
> trees :-( Instead I run the attached script below after each fetch.
Ok, instead of just running this every so often (obviously I was
forgetting to), I've now added it to my main "commit this set of
patches" script so that I will be notified of any problems _before_ you
ever see them.
Sorry for taking so long with this, ugh.
greg k-h
On 29.11.2017 13:24, Stephen Rothwell wrote:
> Hi Christian,
>
> On Wed, 29 Nov 2017 09:44:44 +0100 Christian Gromm <[email protected]> wrote:
>>
>> Hmm, am I missing something here? I have it in.
>> Here are copies of the patches in question and both have
>> a "Signed-off-by" line in.
>
> According to the From: line in the body of these emails, the author of
> this patch is Andrey Shvetsov <[email protected]>, and there is no
> Signed-off-by line from Andrey.
>
Got it. Thanks! We will fix our process so it won't happen again :)
regards,
Chris
From 1585425079158265584@xxx Wed Nov 29 18:12:58 +0000 2017
X-GM-THRID: 1585255511557675077
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
Hi all,
On Wed, 29 Nov 2017 23:24:46 +1100 Stephen Rothwell <[email protected]> wrote:
>
> On Wed, 29 Nov 2017 09:44:44 +0100 Christian Gromm <[email protected]> wrote:
> >
> > Hmm, am I missing something here? I have it in.
> > Here are copies of the patches in question and both have
> > a "Signed-off-by" line in.
>
> According to the From: line in the body of these emails, the author of
> this patch is Andrey Shvetsov <[email protected]>, and there is no
> Signed-off-by line from Andrey.
I should read further ahead in my email ... sorry for the noise.
--
Cheers,
Stephen Rothwell
From 1585425045551391131@xxx Wed Nov 29 18:12:26 +0000 2017
X-GM-THRID: 1585255511557675077
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
Hi Christian,
On Wed, 29 Nov 2017 09:44:44 +0100 Christian Gromm <[email protected]> wrote:
>
> Hmm, am I missing something here? I have it in.
> Here are copies of the patches in question and both have
> a "Signed-off-by" line in.
According to the From: line in the body of these emails, the author of
this patch is Andrey Shvetsov <[email protected]>, and there is no
Signed-off-by line from Andrey.
--
Cheers,
Stephen Rothwell
From 1585404850253259151@xxx Wed Nov 29 12:51:26 +0000 2017
X-GM-THRID: 1585255511557675077
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
On Wed, Nov 29, 2017 at 09:44:44AM +0100, Christian Gromm wrote:
> On 28.11.2017 20:41, Greg KH wrote:
> > On Tue, Nov 28, 2017 at 08:16:51AM +1100, Stephen Rothwell wrote:
> > > Hi Greg,
> > >
> > > Commits
> > >
> > > 2525ef557c73 ("staging: most: update driver usage file")
> > > e7e3ce04588c ("staging: most: core: fix list traversing")
> > >
> > > are missing a Signed-off-by from their author.
> >
> > Ugh, I missed that. Christian, please be more careful.
> >
>
> Hmm, am I missing something here? I have it in.
> Here are copies of the patches in question and both have
> a "Signed-off-by" line in.
>
> ---snip---
> Received: from muaddib.microchip.com (10.10.76.4) by
> chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id
> 14.3.352.0; Tue, 21 Nov 2017 07:05:31 -0700
> From: Christian Gromm <[email protected]>
> To: [email protected]
> CC: [email protected], Andrey Shvetsov
> <[email protected]>, Christian Gromm <[email protected]>
> Subject: [PATCH 48/50] staging: most: core: fix list traversing
> Date: Tue, 21 Nov 2017 15:05:22 +0100
> Message-ID:
> <[email protected]>
> X-Mailer: git-send-email 2.7.4
> In-Reply-To:
> <[email protected]>
> References: <[email protected]>
> Content-Type: text/plain
> Return-Path: [email protected]
> X-MS-Exchange-Organization-AuthSource: CHN-SV-EXCH05.mchp-main.com
> X-MS-Exchange-Organization-AuthAs: Internal
> X-MS-Exchange-Organization-AuthMechanism: 10
> X-MS-Exchange-Organization-AVStamp-Mailbox: SYMANTEC;628359232;0;info
> MIME-Version: 1.0
>
> From: Andrey Shvetsov <[email protected]>
> This patch fixes the offset and data handling when traversing
> the list of devices that are attached to the bus.
>
> Signed-off-by: Christian Gromm <[email protected]>
> ---
> drivers/staging/most/core.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
> index d03ff97..9729206 100644
> --- a/drivers/staging/most/core.c
> +++ b/drivers/staging/most/core.c
> @@ -535,10 +535,16 @@ static struct core_component *match_component(char
> *name)
> return NULL;
> }
>
> +struct show_links_data {
> + int offs;
> + char *buf;
> +};
> +
> int print_links(struct device *dev, void *data)
> {
> - int offs = 0;
> - char *buf = data;
> + struct show_links_data *d = data;
> + int offs = d->offs;
> + char *buf = d->buf;
> struct most_channel *c;
> struct most_interface *iface = to_most_interface(dev);
>
> @@ -560,13 +566,16 @@ int print_links(struct device *dev, void *data)
> dev_name(&c->dev));
> }
> }
> + d->offs = offs;
> return 0;
> }
>
> static ssize_t links_show(struct device_driver *drv, char *buf)
> {
> - bus_for_each_dev(&mc.bus, NULL, buf, print_links);
> - return strlen(buf);
> + struct show_links_data d = { .buf = buf };
> +
> + bus_for_each_dev(&mc.bus, NULL, &d, print_links);
> + return d.offs;
> }
>
> static ssize_t components_show(struct device_driver *drv, char *buf)
> --
> 2.7.4
>
>
> and
>
>
> Received: from muaddib.microchip.com (10.10.76.4) by
> chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id
> 14.3.352.0; Tue, 21 Nov 2017 07:05:26 -0700
> From: Christian Gromm <[email protected]>
> To: [email protected]
> CC: [email protected], Andrey Shvetsov
> <[email protected]>, Christian Gromm <[email protected]>
> Subject: [PATCH 44/50] staging: most: update driver usage file
> Date: Tue, 21 Nov 2017 15:05:18 +0100
> Message-ID:
> <[email protected]>
> X-Mailer: git-send-email 2.7.4
> In-Reply-To:
> <[email protected]>
> References: <[email protected]>
> Content-Type: text/plain
> Return-Path: [email protected]
> X-MS-Exchange-Organization-AuthSource: CHN-SV-EXCH05.mchp-main.com
> X-MS-Exchange-Organization-AuthAs: Internal
> X-MS-Exchange-Organization-AuthMechanism: 10
> X-MS-Exchange-Organization-AVStamp-Mailbox: SYMANTEC;628359232;0;info
> MIME-Version: 1.0
>
> From: Andrey Shvetsov <[email protected]>
>
> This patch keeps the usage file up to date.
>
> Signed-off-by: Christian Gromm <[email protected]>
> ---
Why is there no signed-off-by from Andrey?
From 1585392399596452999@xxx Wed Nov 29 09:33:32 +0000 2017
X-GM-THRID: 1585255511557675077
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
On Wed, Nov 29, 2017 at 10:25:10AM +0100, Christian Gromm wrote:
> On 29.11.2017 10:14, Greg KH wrote:
> > On Wed, Nov 29, 2017 at 09:44:44AM +0100, Christian Gromm wrote:
> > > On 28.11.2017 20:41, Greg KH wrote:
> > > > On Tue, Nov 28, 2017 at 08:16:51AM +1100, Stephen Rothwell wrote:
> > > > > Hi Greg,
> > > > >
> > > > > Commits
> > > > >
> > > > > 2525ef557c73 ("staging: most: update driver usage file")
> > > > > e7e3ce04588c ("staging: most: core: fix list traversing")
> > > > >
> > > > > are missing a Signed-off-by from their author.
> > > >
> > > > Ugh, I missed that. Christian, please be more careful.
> > > >
> > >
> > > Hmm, am I missing something here? I have it in.
> > > Here are copies of the patches in question and both have
> > > a "Signed-off-by" line in.
> > >
> > > ---snip---
> > > Received: from muaddib.microchip.com (10.10.76.4) by
> > > chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id
> > > 14.3.352.0; Tue, 21 Nov 2017 07:05:31 -0700
> > > From: Christian Gromm <[email protected]>
> > > To: [email protected]
> > > CC: [email protected], Andrey Shvetsov
> > > <[email protected]>, Christian Gromm <[email protected]>
> > > Subject: [PATCH 48/50] staging: most: core: fix list traversing
> > > Date: Tue, 21 Nov 2017 15:05:22 +0100
> > > Message-ID:
> > > <[email protected]>
> > > X-Mailer: git-send-email 2.7.4
> > > In-Reply-To:
> > > <[email protected]>
> > > References: <[email protected]>
> > > Content-Type: text/plain
> > > Return-Path: [email protected]
> > > X-MS-Exchange-Organization-AuthSource: CHN-SV-EXCH05.mchp-main.com
> > > X-MS-Exchange-Organization-AuthAs: Internal
> > > X-MS-Exchange-Organization-AuthMechanism: 10
> > > X-MS-Exchange-Organization-AVStamp-Mailbox: SYMANTEC;628359232;0;info
> > > MIME-Version: 1.0
> > >
> > > From: Andrey Shvetsov <[email protected]>
> > > This patch fixes the offset and data handling when traversing
> > > the list of devices that are attached to the bus.
> > >
> > > Signed-off-by: Christian Gromm <[email protected]>
> > > ---
> > > drivers/staging/most/core.c | 17 +++++++++++++----
> > > 1 file changed, 13 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
> > > index d03ff97..9729206 100644
> > > --- a/drivers/staging/most/core.c
> > > +++ b/drivers/staging/most/core.c
> > > @@ -535,10 +535,16 @@ static struct core_component *match_component(char
> > > *name)
> > > return NULL;
> > > }
> > >
> > > +struct show_links_data {
> > > + int offs;
> > > + char *buf;
> > > +};
> > > +
> > > int print_links(struct device *dev, void *data)
> > > {
> > > - int offs = 0;
> > > - char *buf = data;
> > > + struct show_links_data *d = data;
> > > + int offs = d->offs;
> > > + char *buf = d->buf;
> > > struct most_channel *c;
> > > struct most_interface *iface = to_most_interface(dev);
> > >
> > > @@ -560,13 +566,16 @@ int print_links(struct device *dev, void *data)
> > > dev_name(&c->dev));
> > > }
> > > }
> > > + d->offs = offs;
> > > return 0;
> > > }
> > >
> > > static ssize_t links_show(struct device_driver *drv, char *buf)
> > > {
> > > - bus_for_each_dev(&mc.bus, NULL, buf, print_links);
> > > - return strlen(buf);
> > > + struct show_links_data d = { .buf = buf };
> > > +
> > > + bus_for_each_dev(&mc.bus, NULL, &d, print_links);
> > > + return d.offs;
> > > }
> > >
> > > static ssize_t components_show(struct device_driver *drv, char *buf)
> > > --
> > > 2.7.4
> > >
> > >
> > > and
> > >
> > >
> > > Received: from muaddib.microchip.com (10.10.76.4) by
> > > chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id
> > > 14.3.352.0; Tue, 21 Nov 2017 07:05:26 -0700
> > > From: Christian Gromm <[email protected]>
> > > To: [email protected]
> > > CC: [email protected], Andrey Shvetsov
> > > <[email protected]>, Christian Gromm <[email protected]>
> > > Subject: [PATCH 44/50] staging: most: update driver usage file
> > > Date: Tue, 21 Nov 2017 15:05:18 +0100
> > > Message-ID:
> > > <[email protected]>
> > > X-Mailer: git-send-email 2.7.4
> > > In-Reply-To:
> > > <[email protected]>
> > > References: <[email protected]>
> > > Content-Type: text/plain
> > > Return-Path: [email protected]
> > > X-MS-Exchange-Organization-AuthSource: CHN-SV-EXCH05.mchp-main.com
> > > X-MS-Exchange-Organization-AuthAs: Internal
> > > X-MS-Exchange-Organization-AuthMechanism: 10
> > > X-MS-Exchange-Organization-AVStamp-Mailbox: SYMANTEC;628359232;0;info
> > > MIME-Version: 1.0
> > >
> > > From: Andrey Shvetsov <[email protected]>
> > >
> > > This patch keeps the usage file up to date.
> > >
> > > Signed-off-by: Christian Gromm <[email protected]>
> > > ---
> >
> > Why is there no signed-off-by from Andrey?
> >
>
> Ah, his "Signed-off-by" is missing. Understood. Wasn't aware that
> this is a prerequisite. Thought the patches need at least one
> person that signs them off.
They do, but that should always be the patch author at the least :)
> This is because we both develop on the driver. And I take the
> patches from our internal gitlab server, prepare them and send
> them upstream. And those two patches missed his Signed-off
> obvioulsy.
You should sign off on your internal patches, to make this more obvious
and easier.
> Should I resend?
It's already in my tree, no need.
thanks,
greg k-h
From 1585391926028238014@xxx Wed Nov 29 09:26:01 +0000 2017
X-GM-THRID: 1585255511557675077
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
On 29.11.2017 10:14, Greg KH wrote:
> On Wed, Nov 29, 2017 at 09:44:44AM +0100, Christian Gromm wrote:
>> On 28.11.2017 20:41, Greg KH wrote:
>>> On Tue, Nov 28, 2017 at 08:16:51AM +1100, Stephen Rothwell wrote:
>>>> Hi Greg,
>>>>
>>>> Commits
>>>>
>>>> 2525ef557c73 ("staging: most: update driver usage file")
>>>> e7e3ce04588c ("staging: most: core: fix list traversing")
>>>>
>>>> are missing a Signed-off-by from their author.
>>>
>>> Ugh, I missed that. Christian, please be more careful.
>>>
>>
>> Hmm, am I missing something here? I have it in.
>> Here are copies of the patches in question and both have
>> a "Signed-off-by" line in.
>>
>> ---snip---
>> Received: from muaddib.microchip.com (10.10.76.4) by
>> chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id
>> 14.3.352.0; Tue, 21 Nov 2017 07:05:31 -0700
>> From: Christian Gromm <[email protected]>
>> To: [email protected]
>> CC: [email protected], Andrey Shvetsov
>> <[email protected]>, Christian Gromm <[email protected]>
>> Subject: [PATCH 48/50] staging: most: core: fix list traversing
>> Date: Tue, 21 Nov 2017 15:05:22 +0100
>> Message-ID:
>> <[email protected]>
>> X-Mailer: git-send-email 2.7.4
>> In-Reply-To:
>> <[email protected]>
>> References: <[email protected]>
>> Content-Type: text/plain
>> Return-Path: [email protected]
>> X-MS-Exchange-Organization-AuthSource: CHN-SV-EXCH05.mchp-main.com
>> X-MS-Exchange-Organization-AuthAs: Internal
>> X-MS-Exchange-Organization-AuthMechanism: 10
>> X-MS-Exchange-Organization-AVStamp-Mailbox: SYMANTEC;628359232;0;info
>> MIME-Version: 1.0
>>
>> From: Andrey Shvetsov <[email protected]>
>> This patch fixes the offset and data handling when traversing
>> the list of devices that are attached to the bus.
>>
>> Signed-off-by: Christian Gromm <[email protected]>
>> ---
>> drivers/staging/most/core.c | 17 +++++++++++++----
>> 1 file changed, 13 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
>> index d03ff97..9729206 100644
>> --- a/drivers/staging/most/core.c
>> +++ b/drivers/staging/most/core.c
>> @@ -535,10 +535,16 @@ static struct core_component *match_component(char
>> *name)
>> return NULL;
>> }
>>
>> +struct show_links_data {
>> + int offs;
>> + char *buf;
>> +};
>> +
>> int print_links(struct device *dev, void *data)
>> {
>> - int offs = 0;
>> - char *buf = data;
>> + struct show_links_data *d = data;
>> + int offs = d->offs;
>> + char *buf = d->buf;
>> struct most_channel *c;
>> struct most_interface *iface = to_most_interface(dev);
>>
>> @@ -560,13 +566,16 @@ int print_links(struct device *dev, void *data)
>> dev_name(&c->dev));
>> }
>> }
>> + d->offs = offs;
>> return 0;
>> }
>>
>> static ssize_t links_show(struct device_driver *drv, char *buf)
>> {
>> - bus_for_each_dev(&mc.bus, NULL, buf, print_links);
>> - return strlen(buf);
>> + struct show_links_data d = { .buf = buf };
>> +
>> + bus_for_each_dev(&mc.bus, NULL, &d, print_links);
>> + return d.offs;
>> }
>>
>> static ssize_t components_show(struct device_driver *drv, char *buf)
>> --
>> 2.7.4
>>
>>
>> and
>>
>>
>> Received: from muaddib.microchip.com (10.10.76.4) by
>> chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id
>> 14.3.352.0; Tue, 21 Nov 2017 07:05:26 -0700
>> From: Christian Gromm <[email protected]>
>> To: [email protected]
>> CC: [email protected], Andrey Shvetsov
>> <[email protected]>, Christian Gromm <[email protected]>
>> Subject: [PATCH 44/50] staging: most: update driver usage file
>> Date: Tue, 21 Nov 2017 15:05:18 +0100
>> Message-ID:
>> <[email protected]>
>> X-Mailer: git-send-email 2.7.4
>> In-Reply-To:
>> <[email protected]>
>> References: <[email protected]>
>> Content-Type: text/plain
>> Return-Path: [email protected]
>> X-MS-Exchange-Organization-AuthSource: CHN-SV-EXCH05.mchp-main.com
>> X-MS-Exchange-Organization-AuthAs: Internal
>> X-MS-Exchange-Organization-AuthMechanism: 10
>> X-MS-Exchange-Organization-AVStamp-Mailbox: SYMANTEC;628359232;0;info
>> MIME-Version: 1.0
>>
>> From: Andrey Shvetsov <[email protected]>
>>
>> This patch keeps the usage file up to date.
>>
>> Signed-off-by: Christian Gromm <[email protected]>
>> ---
>
> Why is there no signed-off-by from Andrey?
>
Ah, his "Signed-off-by" is missing. Understood. Wasn't aware that
this is a prerequisite. Thought the patches need at least one
person that signs them off.
This is because we both develop on the driver. And I take the
patches from our internal gitlab server, prepare them and send
them upstream. And those two patches missed his Signed-off
obvioulsy.
Should I resend?
regards,
Chris
From 1585389371510447564@xxx Wed Nov 29 08:45:25 +0000 2017
X-GM-THRID: 1585255511557675077
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
On 28.11.2017 20:41, Greg KH wrote:
> On Tue, Nov 28, 2017 at 08:16:51AM +1100, Stephen Rothwell wrote:
>> Hi Greg,
>>
>> Commits
>>
>> 2525ef557c73 ("staging: most: update driver usage file")
>> e7e3ce04588c ("staging: most: core: fix list traversing")
>>
>> are missing a Signed-off-by from their author.
>
> Ugh, I missed that. Christian, please be more careful.
>
Hmm, am I missing something here? I have it in.
Here are copies of the patches in question and both have
a "Signed-off-by" line in.
---snip---
Received: from muaddib.microchip.com (10.10.76.4) by
chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id
14.3.352.0; Tue, 21 Nov 2017 07:05:31 -0700
From: Christian Gromm <[email protected]>
To: [email protected]
CC: [email protected], Andrey Shvetsov
<[email protected]>, Christian Gromm <[email protected]>
Subject: [PATCH 48/50] staging: most: core: fix list traversing
Date: Tue, 21 Nov 2017 15:05:22 +0100
Message-ID:
<[email protected]>
X-Mailer: git-send-email 2.7.4
In-Reply-To:
<[email protected]>
References: <[email protected]>
Content-Type: text/plain
Return-Path: [email protected]
X-MS-Exchange-Organization-AuthSource: CHN-SV-EXCH05.mchp-main.com
X-MS-Exchange-Organization-AuthAs: Internal
X-MS-Exchange-Organization-AuthMechanism: 10
X-MS-Exchange-Organization-AVStamp-Mailbox: SYMANTEC;628359232;0;info
MIME-Version: 1.0
From: Andrey Shvetsov <[email protected]>
This patch fixes the offset and data handling when traversing
the list of devices that are attached to the bus.
Signed-off-by: Christian Gromm <[email protected]>
---
drivers/staging/most/core.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index d03ff97..9729206 100644
--- a/drivers/staging/most/core.c
+++ b/drivers/staging/most/core.c
@@ -535,10 +535,16 @@ static struct core_component *match_component(char
*name)
return NULL;
}
+struct show_links_data {
+ int offs;
+ char *buf;
+};
+
int print_links(struct device *dev, void *data)
{
- int offs = 0;
- char *buf = data;
+ struct show_links_data *d = data;
+ int offs = d->offs;
+ char *buf = d->buf;
struct most_channel *c;
struct most_interface *iface = to_most_interface(dev);
@@ -560,13 +566,16 @@ int print_links(struct device *dev, void *data)
dev_name(&c->dev));
}
}
+ d->offs = offs;
return 0;
}
static ssize_t links_show(struct device_driver *drv, char *buf)
{
- bus_for_each_dev(&mc.bus, NULL, buf, print_links);
- return strlen(buf);
+ struct show_links_data d = { .buf = buf };
+
+ bus_for_each_dev(&mc.bus, NULL, &d, print_links);
+ return d.offs;
}
static ssize_t components_show(struct device_driver *drv, char *buf)
--
2.7.4
and
Received: from muaddib.microchip.com (10.10.76.4) by
chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id
14.3.352.0; Tue, 21 Nov 2017 07:05:26 -0700
From: Christian Gromm <[email protected]>
To: [email protected]
CC: [email protected], Andrey Shvetsov
<[email protected]>, Christian Gromm <[email protected]>
Subject: [PATCH 44/50] staging: most: update driver usage file
Date: Tue, 21 Nov 2017 15:05:18 +0100
Message-ID:
<[email protected]>
X-Mailer: git-send-email 2.7.4
In-Reply-To:
<[email protected]>
References: <[email protected]>
Content-Type: text/plain
Return-Path: [email protected]
X-MS-Exchange-Organization-AuthSource: CHN-SV-EXCH05.mchp-main.com
X-MS-Exchange-Organization-AuthAs: Internal
X-MS-Exchange-Organization-AuthMechanism: 10
X-MS-Exchange-Organization-AVStamp-Mailbox: SYMANTEC;628359232;0;info
MIME-Version: 1.0
From: Andrey Shvetsov <[email protected]>
This patch keeps the usage file up to date.
Signed-off-by: Christian Gromm <[email protected]>
---
.../staging/most/Documentation/driver_usage.txt | 192
+++++++++++----------
1 file changed, 105 insertions(+), 87 deletions(-)
diff --git a/drivers/staging/most/Documentation/driver_usage.txt
b/drivers/staging/most/Documentation/driver_usage.txt
index a4dc0c3..bb9b4e8 100644
--- a/drivers/staging/most/Documentation/driver_usage.txt
+++ b/drivers/staging/most/Documentation/driver_usage.txt
@@ -23,20 +23,29 @@ audio/video streaming. Therefore, the driver
perfectly fits to the mission
of Automotive Grade Linux to create open source software solutions for
automotive applications.
-The driver consists basically of three layers. The hardware layer, the
-core layer and the application layer. The core layer consists of the core
-module only. This module handles the communication flow through all three
-layers, the configuration of the driver, the configuration interface
-representation in sysfs, and the buffer management.
-For each of the other two layers a selection of modules is provided. These
-modules can arbitrarily be combined to meet the needs of the desired
-system architecture. A module of the hardware layer is referred to as an
-HDM (hardware dependent module). Each module of this layer handles exactly
-one of the peripheral interfaces of a network interface controller (e.g.
-USB, MediaLB, I2C). A module of the application layer is referred to as an
-AIM (application interfacing module). The modules of this layer give access
-to MOST via one the following ways: character devices, ALSA, Networking or
..........
regards,
Chris
> I need to set up a git hook for this :(
>
> greg k-h
>
From 1585357545938745890@xxx Wed Nov 29 00:19:33 +0000 2017
X-GM-THRID: 1585255511557675077
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
Hi Michael,
On Wed, 29 Nov 2017 11:09:04 +1100 Michael Ellerman <[email protected]> wrote:
>
> Isn't the update hook what you want?
>
> Called by git-receive-pack:
>
> Before each ref is updated, if $GIT_DIR/hooks/update file exists and
> is executable, it is invoked once per ref, with three parameters:
>
> $GIT_DIR/hooks/update refname sha1-old sha1-new
"This hook is invoked by git-receive-pack on the remote repository,
which happens when a git push is done on a local repository."
--
Cheers,
Stephen Rothwell
From 1585356946839700710@xxx Wed Nov 29 00:10:02 +0000 2017
X-GM-THRID: 1585255511557675077
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
Stephen Rothwell <[email protected]> writes:
> Hi Greg,
>
> On Tue, 28 Nov 2017 20:41:39 +0100 Greg KH <[email protected]> wrote:
>>
>> I need to set up a git hook for this :(
>
> I couldn't find an appropriate hook for fetching or merging other
> trees :-( Instead I run the attached script below after each fetch.
Isn't the update hook what you want?
Called by git-receive-pack:
Before each ref is updated, if $GIT_DIR/hooks/update file exists and
is executable, it is invoked once per ref, with three parameters:
$GIT_DIR/hooks/update refname sha1-old sha1-new
cheers
From 1585352583086561953@xxx Tue Nov 28 23:00:40 +0000 2017
X-GM-THRID: 1585255511557675077
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
Hi Greg,
On Tue, 28 Nov 2017 20:41:39 +0100 Greg KH <[email protected]> wrote:
>
> I need to set up a git hook for this :(
I couldn't find an appropriate hook for fetching or merging other
trees :-( Instead I run the attached script below after each fetch.
--
Cheers,
Stephen Rothwell
On Tue, Nov 28, 2017 at 08:16:51AM +1100, Stephen Rothwell wrote:
> Hi Greg,
>
> Commits
>
> 2525ef557c73 ("staging: most: update driver usage file")
> e7e3ce04588c ("staging: most: core: fix list traversing")
>
> are missing a Signed-off-by from their author.
Ugh, I missed that. Christian, please be more careful.
I need to set up a git hook for this :(
greg k-h
From 1585255511557675077@xxx Mon Nov 27 21:17:46 +0000 2017
X-GM-THRID: 1585255511557675077
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread