2004-10-06 21:28:44

by Hanna Linder

Subject: [PATCH 2.6][2/54] arch/i386/pci/acpi.c Use for_each_pci_dev macro

Using the new for_each_pci_dev macro. Compiled and boot tested.

Hanna Linder
IBM Linux Technology Center

Signed-off-by: Hanna Linder <[email protected]>

---

diff -Nrup linux-2.6.9-rc3-mm2cln/arch/i386/pci/acpi.c linux-2.6.9-rc3-mm2patch3/arch/i386/pci/acpi.c
--- linux-2.6.9-rc3-mm2cln/arch/i386/pci/acpi.c 2004-10-04 11:38:04.000000000 -0700
+++ linux-2.6.9-rc3-mm2patch3/arch/i386/pci/acpi.c 2004-10-06 12:27:55.818932576 -0700
@@ -41,7 +41,7 @@ static int __init pci_acpi_init(void)
printk(KERN_INFO "** was specified. If this was required to make a driver work,\n");
printk(KERN_INFO "** please email the output of \"lspci\" to [email protected]\n");
printk(KERN_INFO "** so I can fix the driver.\n");
- while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL)
+ for_each_pci_dev(dev);
acpi_pci_irq_enable(dev);
} else {
printk(KERN_INFO "** PCI interrupts are no longer routed automatically. If this\n");

2004-10-07 09:31:37

by David Vrabel

Subject: Re: [PATCH 2.6][2/54] arch/i386/pci/acpi.c Use for_each_pci_dev macro

Hanna Linder wrote:
>
> + for_each_pci_dev(dev);

That semicolon doesn't look right.

> acpi_pci_irq_enable(dev);

David Vrabel

2004-10-07 19:31:13

by Hanna Linder

Subject: Re: [PATCH 2.6][2/54] arch/i386/pci/acpi.c Use for_each_pci_dev macro

--On Thursday, October 07, 2004 10:30:33 AM +0100 David Vrabel <[email protected]> wrote:

> Hanna Linder wrote:
>>
>> + for_each_pci_dev(dev);
>
> That semicolon doesn't look right.

Woops. You are right. Here is the reroll

Signed-off-by: Hanna Linder <[email protected]>
---

diff -Nrup linux-2.6.9-rc3-mm2cln/arch/i386/pci/acpi.c linux-2.6.9-rc3-mm2patch/arch/i386/pci/acpi.c
--- linux-2.6.9-rc3-mm2cln/arch/i386/pci/acpi.c 2004-10-04 11:38:04.000000000 -0700
+++ linux-2.6.9-rc3-mm2patch/arch/i386/pci/acpi.c 2004-10-07 12:21:49.825530848 -0700
@@ -41,7 +41,7 @@ static int __init pci_acpi_init(void)
printk(KERN_INFO "** was specified. If this was required to make a driver work,\n");
printk(KERN_INFO "** please email the output of \"lspci\" to [email protected]\n");
printk(KERN_INFO "** so I can fix the driver.\n");
- while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL)
+ for_each_pci_dev(dev)
acpi_pci_irq_enable(dev);
} else {
printk(KERN_INFO "** PCI interrupts are no longer routed automatically. If this\n");