2024-03-25 15:18:43

by Xiu Jianfeng

Subject: [PATCH -next] mm/slub: correct comment in do_slab_free()

From: Xiu Jianfeng <[email protected]>

slab_alloc_node() should be __slab_alloc_node().

Signed-off-by: Xiu Jianfeng <[email protected]>
---
mm/slub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/slub.c b/mm/slub.c
index 7b68a3451eb9..33ac769a69b9 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -4446,7 +4446,7 @@ static __always_inline void do_slab_free(struct kmem_cache *s,
c = raw_cpu_ptr(s->cpu_slab);
tid = READ_ONCE(c->tid);

- /* Same with comment on barrier() in slab_alloc_node() */
+ /* Same with comment on barrier() in __slab_alloc_node() */
barrier();

if (unlikely(slab != c->slab)) {
--
2.34.1

2024-04-04 15:56:03

by Vlastimil Babka

Subject: Re: [PATCH -next] mm/slub: correct comment in do_slab_free()

On 3/25/24 1:22 PM, Xiu Jianfeng wrote:
> From: Xiu Jianfeng <[email protected]>
>
> slab_alloc_node() should be __slab_alloc_node().
>
> Signed-off-by: Xiu Jianfeng <[email protected]>

Thanks, added to slab/for-next

> ---
> mm/slub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 7b68a3451eb9..33ac769a69b9 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -4446,7 +4446,7 @@ static __always_inline void do_slab_free(struct kmem_cache *s,
> c = raw_cpu_ptr(s->cpu_slab);
> tid = READ_ONCE(c->tid);
>
> - /* Same with comment on barrier() in slab_alloc_node() */
> + /* Same with comment on barrier() in __slab_alloc_node() */
> barrier();
>
> if (unlikely(slab != c->slab)) {