2019-10-16 13:26:23

by Marek Bykowski

Subject: Re: [PATCHv2 1/2] bus: arm-ccn: Enable stats for CCN-512 interconnect

Add compatible string for the ARM CCN-502 interconnect

Signed-off-by: Marek Bykowski <[email protected]>
Signed-off-by: Boleslaw Malecki <[email protected]>
---
Changelog v1->v2:
- Change the subject to reflect where the driver got moved to (drivers/perf) from
(drivers/bus).
- Add credit to my work mate that helped me validate the counts from
the interconnect.
---
drivers/perf/arm-ccn.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c
index 7dd850e02f19..b6e00f35a448 100644
--- a/drivers/perf/arm-ccn.c
+++ b/drivers/perf/arm-ccn.c
@@ -1545,6 +1545,7 @@ static int arm_ccn_remove(struct platform_device *pdev)
static const struct of_device_id arm_ccn_match[] = {
{ .compatible = "arm,ccn-502", },
{ .compatible = "arm,ccn-504", },
+ { .compatible = "arm,ccn-512", },
{},
};
MODULE_DEVICE_TABLE(of, arm_ccn_match);

2019-10-16 13:55:37

by Marek Bykowski

Subject: Re: [PATCHv3 1/2] perf: arm-ccn: Enable stats for CCN-512 interconnect

Add compatible string for the ARM CCN-512 interconnect

Signed-off-by: Marek Bykowski <[email protected]>
Signed-off-by: Boleslaw Malecki <[email protected]>
---
Changelog v2->v3
- Correcting copy-paste typo: this commit adds compatible string for CCN-512
and not for CCN-502 which has already a support for.
- Now *for real* change the subject to reflect where the driver got moved
to (drivers/perf) from (drivers/bus).
Changelog v1->v2:
- Change the subject to reflect where the driver got moved to (drivers/perf)
from (drivers/bus).
- Add credit to my work mate that helped me validate the counts from
the interconnect.
---
drivers/perf/arm-ccn.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c
index 7dd850e02f19..b6e00f35a448 100644
--- a/drivers/perf/arm-ccn.c
+++ b/drivers/perf/arm-ccn.c
@@ -1545,6 +1545,7 @@ static int arm_ccn_remove(struct platform_device *pdev)
static const struct of_device_id arm_ccn_match[] = {
{ .compatible = "arm,ccn-502", },
{ .compatible = "arm,ccn-504", },
+ { .compatible = "arm,ccn-512", },
{},
};
MODULE_DEVICE_TABLE(of, arm_ccn_match);

2019-10-16 14:55:25

by Pawel Moll

Subject: Re: [PATCHv2 1/2] bus: arm-ccn: Enable stats for CCN-512 interconnect

On Wed, 2019-10-16 at 10:06 +0100, Marek Bykowski wrote:
> Add compatible string for the ARM CCN-502 interconnect
>
> Signed-off-by: Marek Bykowski <[email protected]>
> Signed-off-by: Boleslaw Malecki <[email protected]>
> ---
> Changelog v1->v2:
> - Change the subject to reflect where the driver got moved to (drivers/perf) from
> (drivers/bus).
> - Add credit to my work mate that helped me validate the counts from
> the interconnect.
> ---
> drivers/perf/arm-ccn.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c
> index 7dd850e02f19..b6e00f35a448 100644
> --- a/drivers/perf/arm-ccn.c
> +++ b/drivers/perf/arm-ccn.c
> @@ -1545,6 +1545,7 @@ static int arm_ccn_remove(struct platform_device *pdev)
> static const struct of_device_id arm_ccn_match[] = {
> { .compatible = "arm,ccn-502", },
> { .compatible = "arm,ccn-504", },
> + { .compatible = "arm,ccn-512", },
> {},
> };
> MODULE_DEVICE_TABLE(of, arm_ccn_match);

Acked-by: Pawel Moll <[email protected]>

Thanks!

Pawel

2019-10-28 21:12:55

by Will Deacon

Subject: Re: [PATCHv3 1/2] perf: arm-ccn: Enable stats for CCN-512 interconnect

On Wed, Oct 16, 2019 at 11:57:39AM +0200, Marek Bykowski wrote:
> Add compatible string for the ARM CCN-512 interconnect
>
> Signed-off-by: Marek Bykowski <[email protected]>
> Signed-off-by: Boleslaw Malecki <[email protected]>

I've queued this (and the docs change), but does it really need two
sign-offs for a one-line change? Boleslaw isn't even on cc!

Will

> drivers/perf/arm-ccn.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c
> index 7dd850e02f19..b6e00f35a448 100644
> --- a/drivers/perf/arm-ccn.c
> +++ b/drivers/perf/arm-ccn.c
> @@ -1545,6 +1545,7 @@ static int arm_ccn_remove(struct platform_device *pdev)
> static const struct of_device_id arm_ccn_match[] = {
> { .compatible = "arm,ccn-502", },
> { .compatible = "arm,ccn-504", },
> + { .compatible = "arm,ccn-512", },
> {},
> };
> MODULE_DEVICE_TABLE(of, arm_ccn_match);