2022-01-10 21:32:50

by Christophe JAILLET

[permalink] [raw]

Subject: [PATCH] batman-adv: Remove redundant 'flush_workqueue()' calls

---

'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

This was generated with coccinelle:

@@
expression E;
@@
- flush_workqueue(E);
destroy_workqueue(E);

Signed-off-by: Christophe JAILLET <[email protected]>
---
net/batman-adv/main.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c
index 5207cd8d6ad8..8f1b724d0412 100644
--- a/net/batman-adv/main.c
+++ b/net/batman-adv/main.c
@@ -132,7 +132,6 @@ static void __exit batadv_exit(void)
rtnl_link_unregister(&batadv_link_ops);
unregister_netdevice_notifier(&batadv_hard_if_notifier);

- flush_workqueue(batadv_event_workqueue);
destroy_workqueue(batadv_event_workqueue);
batadv_event_workqueue = NULL;

--
2.32.0

2022-01-11 07:39:34

by Sven Eckelmann

[permalink] [raw]

Subject: Re: [PATCH] batman-adv: Remove redundant 'flush_workqueue()' calls

---

On Monday, 10 January 2022 22:32:27 CET Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.

Thanks, it was now applied.

Kind regards,
Sven

---

Attachments:

signature.asc (833.00 B)
This is a digitally signed message part.