2015-11-09 21:17:52

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH 25/38] staging: media: davinci_vpfe: fix ipipe_mode type

Hi Andrzej,

Thank you for the patch.

On Monday 21 September 2015 15:33:57 Andrzej Hajda wrote:
> The variable can take negative values.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
>
> Signed-off-by: Andrzej Hajda <[email protected]>

Acked-by: Laurent Pinchart <[email protected]>

and applied to my tree.

> ---
> drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
> b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c index
> 2a3a56b..b1d5e23 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
> @@ -254,7 +254,7 @@ int config_ipipe_hw(struct vpfe_ipipe_device *ipipe)
> void __iomem *ipipe_base = ipipe->base_addr;
> struct v4l2_mbus_framefmt *outformat;
> u32 color_pat;
> - u32 ipipe_mode;
> + int ipipe_mode;
> u32 data_path;
>
> /* enable clock to IPIPE */

--
Regards,

Laurent Pinchart