2020-03-15 03:47:40

by Johan Jonker

Subject: [PATCH] ARM: dts: rockchip: fix vref-supply for &saradc node rk3288 firefly reload

A test with the command below gives this error:

arch/arm/boot/dts/rk3288-firefly-reload.dt.yaml: saradc@ff100000:
'vref-supply' is a required property

PMIC Channel OUT11 with powername 'vcc_18'
(connected through R155 bridge with 'vccio_wl')
is used for the recovery key and ADC_AVDD_1V8.

Fix error by adding 'vcc_18' as vref for the saradc.

make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/adc/
rockchip-saradc.yaml

Signed-off-by: Johan Jonker <[email protected]>
---
Schematic:

http://www.t-firefly.com/download/Firefly-RK3288-Reload/hardware/MainBoard/
Schematic/FIREFLY-RK3288_RELOAD_V10_Schematic.pdf
---
arch/arm/boot/dts/rk3288-firefly-reload.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/rk3288-firefly-reload.dts b/arch/arm/boot/dts/rk3288-firefly-reload.dts
index 1574383fd..8c38bda21 100644
--- a/arch/arm/boot/dts/rk3288-firefly-reload.dts
+++ b/arch/arm/boot/dts/rk3288-firefly-reload.dts
@@ -234,6 +234,7 @@
};

&saradc {
+ vref-supply = <&vcc_18>;
status = "okay";
};

--
2.11.0

2020-03-17 00:30:32

by Heiko Stuebner

Subject: Re: [PATCH] ARM: dts: rockchip: fix vref-supply for &saradc node rk3288 firefly reload

Am Samstag, 14. M?rz 2020, 15:07:55 CET schrieb Johan Jonker:
> A test with the command below gives this error:
>
> arch/arm/boot/dts/rk3288-firefly-reload.dt.yaml: saradc@ff100000:
> 'vref-supply' is a required property
>
> PMIC Channel OUT11 with powername 'vcc_18'
> (connected through R155 bridge with 'vccio_wl')
> is used for the recovery key and ADC_AVDD_1V8.
>
> Fix error by adding 'vcc_18' as vref for the saradc.
>
> make ARCH=arm dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/adc/
> rockchip-saradc.yaml
>
> Signed-off-by: Johan Jonker <[email protected]>

applied for 5.7

Thanks
Heiko