2009-11-11 21:59:32

by Dave Jones

Subject: Fix argument order in memset call in ./drivers/media/common/ir-functions.c

Size is the third argument, not the second.

Signed-off-by: Dave Jones <[email protected]>

diff --git a/drivers/media/common/ir-functions.c b/drivers/media/common/ir-functions.c
index 655474b..abd4791 100644
--- a/drivers/media/common/ir-functions.c
+++ b/drivers/media/common/ir-functions.c
@@ -64,7 +64,7 @@ void ir_input_init(struct input_dev *dev, struct ir_input_state *ir,

ir->ir_type = ir_type;

- memset(ir->ir_codes, sizeof(ir->ir_codes), 0);
+ memset(ir->ir_codes, 0, sizeof(ir->ir_codes));

/*
* FIXME: This is a temporary workaround to use the new IR tables

2009-11-12 07:09:13

by Cong Wang

Subject: Re: Fix argument order in memset call in ./drivers/media/common/ir-functions.c

On Thu, Nov 12, 2009 at 5:59 AM, Dave Jones <[email protected]> wrote:
> Size is the third argument, not the second.
>
> Signed-off-by: Dave Jones <[email protected]>


Definitely yes.

Acked-by: WANG Cong <[email protected]>

>
> diff --git a/drivers/media/common/ir-functions.c b/drivers/media/common/ir-functions.c
> index 655474b..abd4791 100644
> --- a/drivers/media/common/ir-functions.c
> +++ b/drivers/media/common/ir-functions.c
> @@ -64,7 +64,7 @@ void ir_input_init(struct input_dev *dev, struct ir_input_state *ir,
>
>        ir->ir_type = ir_type;
>
> -       memset(ir->ir_codes, sizeof(ir->ir_codes), 0);
> +       memset(ir->ir_codes, 0, sizeof(ir->ir_codes));
>
>        /*
>         * FIXME: This is a temporary workaround to use the new IR tables