2022-01-28 12:20:29

by Sean Anderson

[permalink] [raw]
Subject: Re: PROBLEM: encryption test failures since "crypto: mxs-dcp - Use sg_mapping_iter to copy data"

Hi Christian,

On 1/27/22 12:23 PM, Christian Eggers wrote:
> SoC: i.MX6ULL
>
> After upgrading from v5.10.65-rt53 to v5.10.73-rt54 I get two additional messages on boot:
>
> ...
> [ 3.786333] alg: skcipher: ecb-aes-dcp encryption test failed (wrong result) on test vector 0, cfg="two even aligned splits"
> [ 3.789020] alg: skcipher: cbc-aes-dcp encryption test failed (wrong result) on test vector 0, cfg="two even aligned splits"
> [ 3.793741] mxs-dcp 2280000.crypto: mxs_dcp: initialized
> ..
>
> After reverting the commit
>
> 2e6d793e1bf0 ("crypto: mxs-dcp - Use sg_mapping_iter to copy data")
>
> the error messages above disappear again.

Can you try applying the patch in [1] on top of your revert?

--Sean

[1] https://lore.kernel.org/linux-arm-kernel/[email protected]/


2022-01-28 13:21:02

by Christian Eggers

[permalink] [raw]
Subject: Re: PROBLEM: encryption test failures since "crypto: mxs-dcp - Use sg_mapping_iter to copy data"

Hi Sean,

On Thursday, 27 January 2022, 18:31:48 CET, Sean Anderson wrote:
> Hi Christian,
>
> On 1/27/22 12:23 PM, Christian Eggers wrote:
> > SoC: i.MX6ULL
> >
> > After upgrading from v5.10.65-rt53 to v5.10.73-rt54 I get two additional messages on boot:
> >
> > ...
> > [ 3.786333] alg: skcipher: ecb-aes-dcp encryption test failed (wrong result) on test vector 0, cfg="two even aligned splits"
> > [ 3.789020] alg: skcipher: cbc-aes-dcp encryption test failed (wrong result) on test vector 0, cfg="two even aligned splits"
> > [ 3.793741] mxs-dcp 2280000.crypto: mxs_dcp: initialized
> > ..
> >
> > After reverting the commit
> >
> > 2e6d793e1bf0 ("crypto: mxs-dcp - Use sg_mapping_iter to copy data")
> >
> > the error messages above disappear again.
>
> Can you try applying the patch in [1] on top of your revert?
with the patch from [1] on top of the reverted 2e6d793e1bf0 there are
no error messages on boot.

regards
Christian

>
> [1] https://lore.kernel.org/linux-arm-kernel/[email protected]/
>