2018-11-20 14:36:49

by Malathi Gottam

Subject: [PATCH] arm64: dts: sdm845: add video nodes

This adds video nodes to sdm845 based on the examples
in the bindings.

Signed-off-by: Malathi Gottam <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 0c9a2aa..d82487d 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -84,6 +84,10 @@
reg = <0 0x86200000 0 0x2d00000>;
no-map;
};
+ venus_region: venus@95800000 {
+ reg = <0x0 0x95800000 0x0 0x500000>;
+ no-map;
+ };
};

cpus {
@@ -1103,5 +1107,35 @@
status = "disabled";
};
};
+
+ video-codec@aa00000 {
+ compatible = "qcom,sdm845-venus";
+ reg = <0x0aa00000 0xff000>;
+ interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
+ power-domains = <&videocc VENUS_GDSC>;
+ clocks = <&videocc VIDEO_CC_VENUS_CTL_CORE_CLK>,
+ <&videocc VIDEO_CC_VENUS_AHB_CLK>,
+ <&videocc VIDEO_CC_VENUS_CTL_AXI_CLK>;
+ clock-names = "core", "iface", "bus";
+ iommus = <&apps_smmu 0x10a0 0x8>,
+ <&apps_smmu 0x10b0 0x0>;
+ memory-region = <&venus_region>;
+
+ video-core0 {
+ compatible = "venus-decoder";
+ clocks = <&videocc VIDEO_CC_VCODEC0_CORE_CLK>,
+ <&videocc VIDEO_CC_VCODEC0_AXI_CLK>;
+ clock-names = "core", "bus";
+ power-domains = <&videocc VCODEC0_GDSC>;
+ };
+
+ video-core1 {
+ compatible = "venus-encoder";
+ clocks = <&videocc VIDEO_CC_VCODEC1_CORE_CLK>,
+ <&videocc VIDEO_CC_VCODEC1_AXI_CLK>;
+ clock-names = "core", "bus";
+ power-domains = <&videocc VCODEC1_GDSC>;
+ };
+ };
};
};
--
1.9.1

2018-11-21 06:57:49

by Sibi Sankar

Subject: Re: [PATCH] arm64: dts: sdm845: add video nodes

Hi Malathi,

On 2018-11-20 15:38, Malathi Gottam wrote:
> This adds video nodes to sdm845 based on the examples
> in the bindings.
>
> Signed-off-by: Malathi Gottam <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 34
> ++++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 0c9a2aa..d82487d 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -84,6 +84,10 @@
> reg = <0 0x86200000 0 0x2d00000>;
> no-map;
> };
> + venus_region: venus@95800000 {
> + reg = <0x0 0x95800000 0x0 0x500000>;
> + no-map;
> + };

nit: Please make this venus_region: memory@95800000
instead and add a new line before venus_region.

> };
>
> cpus {
> @@ -1103,5 +1107,35 @@
> status = "disabled";
> };
> };
> +
> + video-codec@aa00000 {
> + compatible = "qcom,sdm845-venus";
> + reg = <0x0aa00000 0xff000>;
> + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> + power-domains = <&videocc VENUS_GDSC>;
> + clocks = <&videocc VIDEO_CC_VENUS_CTL_CORE_CLK>,
> + <&videocc VIDEO_CC_VENUS_AHB_CLK>,
> + <&videocc VIDEO_CC_VENUS_CTL_AXI_CLK>;
> + clock-names = "core", "iface", "bus";
> + iommus = <&apps_smmu 0x10a0 0x8>,
> + <&apps_smmu 0x10b0 0x0>;
> + memory-region = <&venus_region>;
> +
> + video-core0 {
> + compatible = "venus-decoder";
> + clocks = <&videocc VIDEO_CC_VCODEC0_CORE_CLK>,
> + <&videocc VIDEO_CC_VCODEC0_AXI_CLK>;
> + clock-names = "core", "bus";
> + power-domains = <&videocc VCODEC0_GDSC>;
> + };
> +
> + video-core1 {
> + compatible = "venus-encoder";
> + clocks = <&videocc VIDEO_CC_VCODEC1_CORE_CLK>,
> + <&videocc VIDEO_CC_VCODEC1_AXI_CLK>;
> + clock-names = "core", "bus";
> + power-domains = <&videocc VCODEC1_GDSC>;
> + };
> + };
> };
> };

--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.

2018-11-27 10:32:19

by Alexandre Courbot

Subject: Re: [PATCH] arm64: dts: sdm845: add video nodes

On Tue, Nov 20, 2018 at 7:08 PM Malathi Gottam <[email protected]> wrote:
>
> This adds video nodes to sdm845 based on the examples
> in the bindings.
>
> Signed-off-by: Malathi Gottam <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 34 ++++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 0c9a2aa..d82487d 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -84,6 +84,10 @@
> reg = <0 0x86200000 0 0x2d00000>;
> no-map;
> };
> + venus_region: venus@95800000 {
> + reg = <0x0 0x95800000 0x0 0x500000>;

Note that the driver expects a size of 0x600000 here and will fail to
probe if this is smaller.

2018-11-27 11:00:30

by Stanimir Varbanov

Subject: Re: [PATCH] arm64: dts: sdm845: add video nodes

Hi Alex,

On 11/27/18 9:31 AM, Alexandre Courbot wrote:
> On Tue, Nov 20, 2018 at 7:08 PM Malathi Gottam <[email protected]> wrote:
>>
>> This adds video nodes to sdm845 based on the examples
>> in the bindings.
>>
>> Signed-off-by: Malathi Gottam <[email protected]>
>> ---
>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 34 ++++++++++++++++++++++++++++++++++
>> 1 file changed, 34 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> index 0c9a2aa..d82487d 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> @@ -84,6 +84,10 @@
>> reg = <0 0x86200000 0 0x2d00000>;
>> no-map;
>> };
>> + venus_region: venus@95800000 {
>> + reg = <0x0 0x95800000 0x0 0x500000>;
>
> Note that the driver expects a size of 0x600000 here and will fail to
> probe if this is smaller.
>

I have to send a patch to fix that size mismatch as we discussed that it
the other mail thread.

--
regards,
Stan

2019-01-16 18:41:08

by Stanimir Varbanov

Subject: Re: [PATCH] arm64: dts: sdm845: add video nodes

Hi Alex,

On 11/27/18 10:24 AM, Stanimir Varbanov wrote:
> Hi Alex,
>
> On 11/27/18 9:31 AM, Alexandre Courbot wrote:
>> On Tue, Nov 20, 2018 at 7:08 PM Malathi Gottam <[email protected]> wrote:
>>>
>>> This adds video nodes to sdm845 based on the examples
>>> in the bindings.
>>>
>>> Signed-off-by: Malathi Gottam <[email protected]>
>>> ---
>>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 34 ++++++++++++++++++++++++++++++++++
>>> 1 file changed, 34 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>>> index 0c9a2aa..d82487d 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>>> @@ -84,6 +84,10 @@
>>> reg = <0 0x86200000 0 0x2d00000>;
>>> no-map;
>>> };
>>> + venus_region: venus@95800000 {
>>> + reg = <0x0 0x95800000 0x0 0x500000>;
>>
>> Note that the driver expects a size of 0x600000 here and will fail to
>> probe if this is smaller.
>>
>
> I have to send a patch to fix that size mismatch as we discussed that it
> the other mail thread.
>

I sent the size mismatch patch here:

https://patchwork.kernel.org/patch/10753645/


--
regards,
Stan