2024-04-10 15:54:52

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] clk: sifive: prci: fix module autoloading

Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
based on the alias from of_device_id table. Clocks are considered core
components, so usually they are built-in, however these can be built and
used as modules on some generic kernel.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/clk/sifive/sifive-prci.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/sifive/sifive-prci.c b/drivers/clk/sifive/sifive-prci.c
index 25b8e1a80ddc..700a1be9ec47 100644
--- a/drivers/clk/sifive/sifive-prci.c
+++ b/drivers/clk/sifive/sifive-prci.c
@@ -611,6 +611,7 @@ static const struct of_device_id sifive_prci_of_match[] = {
{.compatible = "sifive,fu740-c000-prci", .data = &prci_clk_fu740},
{}
};
+MODULE_DEVICE_TABLE(of, sifive_prci_of_match);

static struct platform_driver sifive_prci_driver = {
.driver = {
--
2.34.1



2024-04-10 16:03:22

by Samuel Holland

[permalink] [raw]
Subject: Re: [PATCH] clk: sifive: prci: fix module autoloading

On 2024-04-10 10:53 AM, Krzysztof Kozlowski wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from of_device_id table. Clocks are considered core
> components, so usually they are built-in, however these can be built and
> used as modules on some generic kernel.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/clk/sifive/sifive-prci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/sifive/sifive-prci.c b/drivers/clk/sifive/sifive-prci.c
> index 25b8e1a80ddc..700a1be9ec47 100644
> --- a/drivers/clk/sifive/sifive-prci.c
> +++ b/drivers/clk/sifive/sifive-prci.c
> @@ -611,6 +611,7 @@ static const struct of_device_id sifive_prci_of_match[] = {
> {.compatible = "sifive,fu740-c000-prci", .data = &prci_clk_fu740},
> {}
> };
> +MODULE_DEVICE_TABLE(of, sifive_prci_of_match);
>
> static struct platform_driver sifive_prci_driver = {
> .driver = {

Reviewed-by: Samuel Holland <[email protected]>