2024-01-10 21:01:28

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v22 7/8] arm64: dts: nuvoton: npcm8xx: replace reg with syscon property

On 08/01/2024 14:54, Tomer Maimon wrote:
> Replace reg with syscon property since the clock registers handle the
> reset registers as well.
>
> Signed-off-by: Tomer Maimon <[email protected]>
> ---

NAK for the same reasons as previous patch.

Best regards,
Krzysztof



2024-01-16 19:40:16

by Tomer Maimon

[permalink] [raw]
Subject: Re: [PATCH v22 7/8] arm64: dts: nuvoton: npcm8xx: replace reg with syscon property

Hi Krzysztof,

Thanks for your comment.

On Wed, 10 Jan 2024 at 22:59, Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 08/01/2024 14:54, Tomer Maimon wrote:
> > Replace reg with syscon property since the clock registers handle the
> > reset registers as well.
> >
> > Signed-off-by: Tomer Maimon <[email protected]>
> > ---
>
> NAK for the same reasons as previous patch.
Will explain more in the commit message
>
> Best regards,
> Krzysztof
>

Best regards,

Tomer

2024-01-16 22:16:33

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v22 7/8] arm64: dts: nuvoton: npcm8xx: replace reg with syscon property

On 16/01/2024 20:39, Tomer Maimon wrote:
> Hi Krzysztof,
>
> Thanks for your comment.
>
> On Wed, 10 Jan 2024 at 22:59, Krzysztof Kozlowski
> <[email protected]> wrote:
>>
>> On 08/01/2024 14:54, Tomer Maimon wrote:
>>> Replace reg with syscon property since the clock registers handle the
>>> reset registers as well.
>>>
>>> Signed-off-by: Tomer Maimon <[email protected]>
>>> ---
>>
>> NAK for the same reasons as previous patch.
> Will explain more in the commit message

No, this wasn't even tested. Build your code with W=1 and fix all
warnings first. But anyway this is not the way to go.

Best regards,
Krzysztof