2020-03-27 21:35:03

by Kammela, Gayatri

[permalink] [raw]
Subject: [PATCH v2 0/3] Fixes: update Tiger Lake ACPI device IDs

Hi,

The hardware IDs for devices supported by Tiger Lake for various drivers
such as DPTF, fan, Intel thermal and intel-hid are added with missing 'C'
which makes them invalid. Hence fix these IDs by updating.

For instance, the updated ID now looks like
INT1047 --> INTC1047

Patch 1: Update Tiger Lake ACPI device IDs for DPTF and fan drivers
Patch 2: Update Tiger Lake ACPI device ID for intel-hid driver
Patch 3: Update Tiger Lake ACPI device IDs for thermal driver

Changes since v1:
1) Added fixes tag to each patch

Gayatri Kammela (3):
ACPI: fix: Update Tiger Lake ACPI device IDs
platform/x86: intel-hid: fix: Update Tiger Lake ACPI device ID
thermal: int340x_thermal: fix: Update Tiger Lake ACPI device IDs

drivers/acpi/device_pm.c | 2 +-
drivers/acpi/dptf/dptf_power.c | 2 +-
drivers/acpi/dptf/int340x_thermal.c | 8 ++++----
drivers/platform/x86/intel-hid.c | 2 +-
drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 2 +-
drivers/thermal/intel/int340x_thermal/int3403_thermal.c | 2 +-
6 files changed, 9 insertions(+), 9 deletions(-)

Cc: Andy Shevchenko <[email protected]>
Cc: Srinivas Pandruvada <[email protected]>
Cc: Rafael J. Wysocki <[email protected]>
--
2.17.1


2020-03-27 21:35:36

by Kammela, Gayatri

[permalink] [raw]
Subject: [PATCH v2 3/3] thermal: int340x_thermal: fix: Update Tiger Lake ACPI device IDs

Tiger Lake's new unique ACPI device IDs for Intel thermal driver are not
valid because of missing 'C' in the IDs. Fix the IDs by updating them.

After the update, the new IDs should now look like
INT1040 --> INTC1040
INT1043 --> INTC1043

Fixes: 9b1b5535dfc9 ("thermal: int340x_thermal: Add Tiger Lake ACPI device IDs")
Cc: 5.6+ <[email protected]> # 5.6+
Cc: Andy Shevchenko <[email protected]>
Cc: Srinivas Pandruvada <[email protected]>
Cc: Rafael J. Wysocki <[email protected]>
Suggested-by: Srinivas Pandruvada <[email protected]>
Signed-off-by: Gayatri Kammela <[email protected]>
---
drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 2 +-
drivers/thermal/intel/int340x_thermal/int3403_thermal.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
index efae0c02d898..71a9877b85a5 100644
--- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
+++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
@@ -369,7 +369,7 @@ static int int3400_thermal_remove(struct platform_device *pdev)
}

static const struct acpi_device_id int3400_thermal_match[] = {
- {"INT1040", 0},
+ {"INTC1040", 0},
{"INT3400", 0},
{}
};
diff --git a/drivers/thermal/intel/int340x_thermal/int3403_thermal.c b/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
index aeece1e136a5..3849d5869609 100644
--- a/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
+++ b/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
@@ -282,7 +282,7 @@ static int int3403_remove(struct platform_device *pdev)
}

static const struct acpi_device_id int3403_device_ids[] = {
- {"INT1043", 0},
+ {"INTC1043", 0},
{"INT3403", 0},
{"", 0},
};
--
2.17.1

2020-03-28 20:45:56

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v2 0/3] Fixes: update Tiger Lake ACPI device IDs

On Fri, Mar 27, 2020 at 11:34 PM Gayatri Kammela
<[email protected]> wrote:
>
> Hi,
>
> The hardware IDs for devices supported by Tiger Lake for various drivers
> such as DPTF, fan, Intel thermal and intel-hid are added with missing 'C'
> which makes them invalid. Hence fix these IDs by updating.
>
> For instance, the updated ID now looks like
> INT1047 --> INTC1047
>
> Patch 1: Update Tiger Lake ACPI device IDs for DPTF and fan drivers
> Patch 2: Update Tiger Lake ACPI device ID for intel-hid driver
> Patch 3: Update Tiger Lake ACPI device IDs for thermal driver
>

Please, keep the IDs sorted (INTC should go after INT, etc).
Also I will need an Ack for patch 1 (at least).

> Changes since v1:
> 1) Added fixes tag to each patch
>
> Gayatri Kammela (3):
> ACPI: fix: Update Tiger Lake ACPI device IDs
> platform/x86: intel-hid: fix: Update Tiger Lake ACPI device ID
> thermal: int340x_thermal: fix: Update Tiger Lake ACPI device IDs
>
> drivers/acpi/device_pm.c | 2 +-
> drivers/acpi/dptf/dptf_power.c | 2 +-
> drivers/acpi/dptf/int340x_thermal.c | 8 ++++----
> drivers/platform/x86/intel-hid.c | 2 +-
> drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 2 +-
> drivers/thermal/intel/int340x_thermal/int3403_thermal.c | 2 +-
> 6 files changed, 9 insertions(+), 9 deletions(-)
>
> Cc: Andy Shevchenko <[email protected]>
> Cc: Srinivas Pandruvada <[email protected]>
> Cc: Rafael J. Wysocki <[email protected]>
> --
> 2.17.1
>


--
With Best Regards,
Andy Shevchenko

2020-03-31 02:38:50

by Zhang, Rui

[permalink] [raw]
Subject: Re: [PATCH v2 3/3] thermal: int340x_thermal: fix: Update Tiger Lake ACPI device IDs

On Fri, 2020-03-27 at 14:28 -0700, Gayatri Kammela wrote:
> Tiger Lake's new unique ACPI device IDs for Intel thermal driver are
> not
> valid because of missing 'C' in the IDs. Fix the IDs by updating
> them.
>
> After the update, the new IDs should now look like
> INT1040 --> INTC1040
> INT1043 --> INTC1043
>
> Fixes: 9b1b5535dfc9 ("thermal: int340x_thermal: Add Tiger Lake ACPI
> device IDs")
> Cc: 5.6+ <[email protected]> # 5.6+
> Cc: Andy Shevchenko <[email protected]>
> Cc: Srinivas Pandruvada <[email protected]>
> Cc: Rafael J. Wysocki <[email protected]>
> Suggested-by: Srinivas Pandruvada <[email protected]>
> Signed-off-by: Gayatri Kammela <[email protected]>

Acked-by: Zhang Rui <[email protected]>

thanks,
rui
> ---
> drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 2 +-
> drivers/thermal/intel/int340x_thermal/int3403_thermal.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> index efae0c02d898..71a9877b85a5 100644
> --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> @@ -369,7 +369,7 @@ static int int3400_thermal_remove(struct
> platform_device *pdev)
> }
>
> static const struct acpi_device_id int3400_thermal_match[] = {
> - {"INT1040", 0},
> + {"INTC1040", 0},
> {"INT3400", 0},
> {}
> };
> diff --git a/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
> b/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
> index aeece1e136a5..3849d5869609 100644
> --- a/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
> +++ b/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
> @@ -282,7 +282,7 @@ static int int3403_remove(struct platform_device
> *pdev)
> }
>
> static const struct acpi_device_id int3403_device_ids[] = {
> - {"INT1043", 0},
> + {"INTC1043", 0},
> {"INT3403", 0},
> {"", 0},
> };