2019-08-07 11:45:12

by Frieder Schrempf

[permalink] [raw]
Subject: [PATCH] i2c: imx: Allow the driver to be built for ARM64 SoCs such as i.MX8M

From: Frieder Schrempf <[email protected]>

The imx I2C controller is used in some ARM64 SoCs such as i.MX8M.
To make use of it, append ARM64 to the list of dependencies.

Signed-off-by: Frieder Schrempf <[email protected]>
---
drivers/i2c/busses/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 09367fc014c3..46b653621513 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -664,7 +664,7 @@ config I2C_IMG

config I2C_IMX
tristate "IMX I2C interface"
- depends on ARCH_MXC || ARCH_LAYERSCAPE || COLDFIRE
+ depends on ARCH_MXC || ARCH_LAYERSCAPE || COLDFIRE || ARM64
help
Say Y here if you want to use the IIC bus controller on
the Freescale i.MX/MXC, Layerscape or ColdFire processors.
--
2.17.1


2019-08-07 12:12:31

by Alexander Stein

[permalink] [raw]
Subject: Re: [PATCH] i2c: imx: Allow the driver to be built for ARM64 SoCs such as i.MX8M

On Wednesday, August 7, 2019, 1:44:06 PM CEST Schrempf Frieder wrote:
> From: Frieder Schrempf <[email protected]>
>
> The imx I2C controller is used in some ARM64 SoCs such as i.MX8M.
> To make use of it, append ARM64 to the list of dependencies.
>
> Signed-off-by: Frieder Schrempf <[email protected]>
> ---
> drivers/i2c/busses/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 09367fc014c3..46b653621513 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -664,7 +664,7 @@ config I2C_IMG
>
> config I2C_IMX
> tristate "IMX I2C interface"
> - depends on ARCH_MXC || ARCH_LAYERSCAPE || COLDFIRE
> + depends on ARCH_MXC || ARCH_LAYERSCAPE || COLDFIRE || ARM64

I don't think this should be necessary at all as ARCH_MXC is also available for arm64, see https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/Kconfig.platforms#n167
I rather wonder why ARCH_MXC is not set. Same for fec.

> help
> Say Y here if you want to use the IIC bus controller on
> the Freescale i.MX/MXC, Layerscape or ColdFire processors.
>




2019-08-07 13:27:04

by Frieder Schrempf

[permalink] [raw]
Subject: Re: [PATCH] i2c: imx: Allow the driver to be built for ARM64 SoCs such as i.MX8M

On 07.08.19 14:09, Alexander Stein wrote:
> On Wednesday, August 7, 2019, 1:44:06 PM CEST Schrempf Frieder wrote:
>> From: Frieder Schrempf <[email protected]>
>>
>> The imx I2C controller is used in some ARM64 SoCs such as i.MX8M.
>> To make use of it, append ARM64 to the list of dependencies.
>>
>> Signed-off-by: Frieder Schrempf <[email protected]>
>> ---
>> drivers/i2c/busses/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
>> index 09367fc014c3..46b653621513 100644
>> --- a/drivers/i2c/busses/Kconfig
>> +++ b/drivers/i2c/busses/Kconfig
>> @@ -664,7 +664,7 @@ config I2C_IMG
>>
>> config I2C_IMX
>> tristate "IMX I2C interface"
>> - depends on ARCH_MXC || ARCH_LAYERSCAPE || COLDFIRE
>> + depends on ARCH_MXC || ARCH_LAYERSCAPE || COLDFIRE || ARM64
>
> I don't think this should be necessary at all as ARCH_MXC is also available for arm64, see https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/Kconfig.platforms#n167
> I rather wonder why ARCH_MXC is not set. Same for fec.

You're right of course. I somehow managed to mess up my defconfig. I
started over with a clean config from arch/arm64/configs/defconfig and
everything seems fine now. Sorry for the noise.

>
>> help
>> Say Y here if you want to use the IIC bus controller on
>> the Freescale i.MX/MXC, Layerscape or ColdFire processors.
>>
>
>
>
>