2022-06-08 12:47:17

by Heinrich Schuchardt

[permalink] [raw]
Subject: Re: [PATCH 3/3] riscv: dts: microchip: fix icicle kit's dr_mode

On 6/7/22 15:22, Conor Dooley wrote:
> The usb on icicle kit is actually configured for otg, not host mode.
> Swap it over.

To my understanding both host mode and OTG mode could be supported by
the hardware.

Jumper J17 on
https://www.microsemi.com/images/10/MicrosoftTeams-image%201.png.
USB device mode selection - Open: USB client. Closed: USB host

Is OTG really the most important scenario for running the board? I
personally would prefer to run it in host mode to add more peripherals.

What is missing on the driver side to enable host mode?

Can we detect the 5 Volt jumper setting via GPIO?

Best regards

Heinrich

>
> Fixes: 528a5b1f2556 ("riscv: dts: microchip: add new peripherals to icicle kit device tree")
> Signed-off-by: Conor Dooley<[email protected]>
> ---
> arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts b/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
> index 044982a11df5..121b01c8784f 100644
> --- a/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
> +++ b/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
> @@ -158,5 +158,5 @@ &syscontroller {
>
> &usb {
> status = "okay";
> - dr_mode = "host";
> + dr_mode = "otg";
> };
> -- 2.36.1


2022-06-08 13:15:30

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH 3/3] riscv: dts: microchip: fix icicle kit's dr_mode

On 08/06/2022 13:21, Heinrich Schuchardt wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 6/7/22 15:22, Conor Dooley wrote:
>> The usb on icicle kit is actually configured for otg, not host mode.
>> Swap it over.
>
> To my understanding both host mode and OTG mode could  be supported by
> the hardware.
>
> Jumper J17 on
> https://www.microsemi.com/images/10/MicrosoftTeams-image%201.png.
> USB device mode selection - Open: USB client. Closed: USB host
>
> Is OTG really the most important scenario for running the board? I
> personally would prefer to run it in host mode to add more peripherals.
> What is missing on the driver side to enable host mode?

Nothing. I'll drop the the patch for v2 :)

> Can we detect the 5 Volt jumper setting via GPIO?

I have to check if a GPIO can be routed that way & I'll get back to you.
Thanks,
Conor.

>
> Best regards
>
> Heinrich
>
>>
>> Fixes: 528a5b1f2556 ("riscv: dts: microchip: add new peripherals to icicle kit device tree")
>> Signed-off-by: Conor Dooley<[email protected]>
>> ---
>>   arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts b/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
>> index 044982a11df5..121b01c8784f 100644
>> --- a/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
>> +++ b/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
>> @@ -158,5 +158,5 @@ &syscontroller {
>>
>>   &usb {
>>       status = "okay";
>> -     dr_mode = "host";
>> +     dr_mode = "otg";
>>   };
>> -- 2.36.1
>

2022-06-09 08:52:03

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH 3/3] riscv: dts: microchip: fix icicle kit's dr_mode

On 08/06/2022 13:47, Conor Dooley wrote:
> On 08/06/2022 13:21, Heinrich Schuchardt wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On 6/7/22 15:22, Conor Dooley wrote:
>>> The usb on icicle kit is actually configured for otg, not host mode.
>>> Swap it over.
>>
>> To my understanding both host mode and OTG mode could  be supported by
>> the hardware.
>>
>> Jumper J17 on
>> https://www.microsemi.com/images/10/MicrosoftTeams-image%201.png.
>> USB device mode selection - Open: USB client. Closed: USB host
>>
>> Is OTG really the most important scenario for running the board? I
>> personally would prefer to run it in host mode to add more peripherals.
>> What is missing on the driver side to enable host mode?
>
> Nothing. I'll drop the the patch for v2 :)
>
>> Can we detect the 5 Volt jumper setting via GPIO?
>
> I have to check if a GPIO can be routed that way & I'll get back to you.

Unfortunately not, that jumper can't be connected to a GPIO.

> Thanks,
> Conor.
>
>>
>> Best regards
>>
>> Heinrich
>>
>>>
>>> Fixes: 528a5b1f2556 ("riscv: dts: microchip: add new peripherals to icicle kit device tree")
>>> Signed-off-by: Conor Dooley<[email protected]>
>>> ---
>>>   arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts b/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
>>> index 044982a11df5..121b01c8784f 100644
>>> --- a/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
>>> +++ b/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
>>> @@ -158,5 +158,5 @@ &syscontroller {
>>>
>>>   &usb {
>>>       status = "okay";
>>> -     dr_mode = "host";
>>> +     dr_mode = "otg";
>>>   };
>>> -- 2.36.1
>>
>