Subject: [NEW DRIVER V1 0/7] please comment on this new PMIC driver

This is submission attempt number 1 to have this driver included in
the linux kernel source tree. This is the driver for the Dialog DA9058.

The DA9058 is a low power Power Management Integrated Circuit with extra
functionality. It is a Multi Function Device controlled only from an I2C
bus whose components can raise an interrupt request on a single IRQ line.

The driver for the DA9058 consists of a core (i2c) device driver that
instantiates the individual component device drivers for:

hwmon - 5 ADC channels
gpio - 2 available pins
onkey - 1 device
regulator - 4 BUCKS, 19 LDO and 3 fixed
rtc - low power clock
power - battery information

All the above six component device drivers depend on the 'core' driver,
which in number one in the patch series.

This driver has been tested on a Samsung SMDK6410 connected to a Dialog
DA9058 Evaluation Board via one GPIO and a 3-wire I2C connection.

All the components can be builtin to the kernel or compiled as modules.
As far as I can tell, all the latest APIs both for the core driver and
all the component drivers have been adhered to, but if I have missed
something please let me know.

Many thanks,
Anthony Olech, Dialog Semiconductor Ltd.

Tony Olech (at Home) (7):
DA9058 MFD core and ADC driver
DA9058 ONKEY driver
DA9058 POWER driver
DA9058 RTC driver
DA9058 GPIO driver
DA9058 HWMON driver
DA9058 REGULATOR driver

drivers/gpio/Kconfig | 12 +
drivers/gpio/Makefile | 1 +
drivers/gpio/gpio-da9058.c | 375 ++++++++++++++++++++++++++
drivers/hwmon/Kconfig | 10 +
drivers/hwmon/Makefile | 1 +
drivers/hwmon/da9058-hwmon.c | 389 +++++++++++++++++++++++++++
drivers/input/misc/Kconfig | 10 +
drivers/input/misc/Makefile | 1 +
drivers/input/misc/da9058_onkey.c | 170 ++++++++++++
drivers/mfd/Kconfig | 18 ++
drivers/mfd/Makefile | 3 +
drivers/mfd/da9058-core.c | 320 ++++++++++++++++++++++
drivers/mfd/da9058-i2c.c | 102 +++++++
drivers/mfd/da9058-irq.c | 66 +++++
drivers/power/Kconfig | 10 +
drivers/power/Makefile | 1 +
drivers/power/da9058_power.c | 403 ++++++++++++++++++++++++++++
drivers/regulator/Kconfig | 11 +
drivers/regulator/Makefile | 1 +
drivers/regulator/da9058-regulator.c | 336 ++++++++++++++++++++++++
drivers/rtc/Kconfig | 21 +-
drivers/rtc/Makefile | 1 +
drivers/rtc/rtc-da9058.c | 456 ++++++++++++++++++++++++++++++++
include/linux/mfd/da9058/bat.h | 33 +++
include/linux/mfd/da9058/codec.h | 21 ++
include/linux/mfd/da9058/core.h | 69 +++++
include/linux/mfd/da9058/gpio.h | 19 ++
include/linux/mfd/da9058/hwmon.h | 20 ++
include/linux/mfd/da9058/irq.h | 45 ++++
include/linux/mfd/da9058/onkey.h | 17 ++
include/linux/mfd/da9058/pdata.h | 28 ++
include/linux/mfd/da9058/registers.h | 480 ++++++++++++++++++++++++++++++++++
include/linux/mfd/da9058/regulator.h | 33 +++
include/linux/mfd/da9058/rtc.h | 17 ++
34 files changed, 3494 insertions(+), 6 deletions(-)
create mode 100644 drivers/gpio/gpio-da9058.c
create mode 100644 drivers/hwmon/da9058-hwmon.c
create mode 100644 drivers/input/misc/da9058_onkey.c
create mode 100644 drivers/mfd/da9058-core.c
create mode 100644 drivers/mfd/da9058-i2c.c
create mode 100644 drivers/mfd/da9058-irq.c
create mode 100644 drivers/power/da9058_power.c
create mode 100644 drivers/regulator/da9058-regulator.c
create mode 100644 drivers/rtc/rtc-da9058.c
create mode 100644 include/linux/mfd/da9058/bat.h
create mode 100644 include/linux/mfd/da9058/codec.h
create mode 100644 include/linux/mfd/da9058/core.h
create mode 100644 include/linux/mfd/da9058/gpio.h
create mode 100644 include/linux/mfd/da9058/hwmon.h
create mode 100644 include/linux/mfd/da9058/irq.h
create mode 100644 include/linux/mfd/da9058/onkey.h
create mode 100644 include/linux/mfd/da9058/pdata.h
create mode 100644 include/linux/mfd/da9058/registers.h
create mode 100644 include/linux/mfd/da9058/regulator.h
create mode 100644 include/linux/mfd/da9058/rtc.h

--
end-of-patch for NEW DRIVER V1


2012-08-02 10:17:21

by Mark Brown

[permalink] [raw]
Subject: Re: [NEW DRIVER V1 0/7] please comment on this new PMIC driver

On Thu, Aug 02, 2012 at 09:48:58AM +0100, Anthony Olech wrote:
> This is submission attempt number 1 to have this driver included in
> the linux kernel source tree. This is the driver for the Dialog DA9058.

I just noticed that you haven't CCed the maintainers for most of this
stuff on your patches... you should always do this if you want review.

Subject: RE: [NEW DRIVER V1 0/7] please comment on this new PMIC driver

Thanks Mark,

for your very helpful comments on all on the patches in this first submission attempt, I will digest and regurgitate a second attempt as soon as I can.

best regards,

Tony Olech

-----Original Message-----
From: Mark Brown [mailto:[email protected]]
Sent: 02 August 2012 11:17
To: Opensource [Anthony Olech]
Cc: LKML
Subject: Re: [NEW DRIVER V1 0/7] please comment on this new PMIC driver

On Thu, Aug 02, 2012 at 09:48:58AM +0100, Anthony Olech wrote:
> This is submission attempt number 1 to have this driver included in
> the linux kernel source tree. This is the driver for the Dialog DA9058.

I just noticed that you haven't CCed the maintainers for most of this stuff on your patches... you should always do this if you want review.

2012-08-03 07:16:51

by Andi Shyti

[permalink] [raw]
Subject: Re: [NEW DRIVER V1 0/7] please comment on this new PMIC driver

Hi Tony,

> for your very helpful comments on all on the patches in this first submission attempt, I will digest and regurgitate a second attempt as soon as I can.

once you have digested and regurgitated :), you could also split
the patchset in smaller patches, I would say at least one patch
per driver (you could split it in smaller patches).

To find out to whom you can send the patches you can use the
get_maintainer.pl script.

Andi