This is a fixup to two device tree nodes that have already landed but
without clock nodes since the transition to common clock happened at
the same time.
Signed-off-by: Doug Anderson <[email protected]>
---
arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 24c52e6..59be603 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -402,12 +402,18 @@
compatible = "samsung,exynos4210-ehci";
reg = <0x12110000 0x100>;
interrupts = <0 71 0>;
+
+ clocks = <&clock 285>;
+ clock-names = "usbhost";
};
usb@12120000 {
compatible = "samsung,exynos4210-ohci";
reg = <0x12120000 0x100>;
interrupts = <0 71 0>;
+
+ clocks = <&clock 285>;
+ clock-names = "usbhost";
};
amba {
--
1.8.1.3
Hi Doug,
On Wed, Mar 13, 2013 at 10:48 PM, Doug Anderson <[email protected]> wrote:
> This is a fixup to two device tree nodes that have already landed but
> without clock nodes since the transition to common clock happened at
> the same time.
>
> Signed-off-by: Doug Anderson <[email protected]>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 24c52e6..59be603 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -402,12 +402,18 @@
> compatible = "samsung,exynos4210-ehci";
> reg = <0x12110000 0x100>;
> interrupts = <0 71 0>;
> +
> + clocks = <&clock 285>;
> + clock-names = "usbhost";
> };
>
> usb@12120000 {
> compatible = "samsung,exynos4210-ohci";
> reg = <0x12120000 0x100>;
> interrupts = <0 71 0>;
> +
> + clocks = <&clock 285>;
> + clock-names = "usbhost";
It will be nice if you can please update relevant information
alongwith this, in the bindings doc for "exynos-usb".
> };
>
> amba {
> --
> 1.8.1.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Thanks & Regards
Vivek
Vivek,
On Wed, Mar 13, 2013 at 11:22 PM, Vivek Gautam
<[email protected]> wrote:
> It will be nice if you can please update relevant information
> alongwith this, in the bindings doc for "exynos-usb".
Sure. It always feels like device tree additions ought to be separate
patches from bindings patches, so I'll just send something separately.
Here it is: <https://patchwork.kernel.org/patch/2274331/>
-Doug
On Thursday, March 14, 2013 2:18 AM, Doug Anderson wrote:
>
> This is a fixup to two device tree nodes that have already landed but
> without clock nodes since the transition to common clock happened at
> the same time.
>
> Signed-off-by: Doug Anderson <[email protected]>
The clock number and name are right.
Reviewed-by: Jingoo Han <[email protected]>
Best regards,
Jingoo Han
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 24c52e6..59be603 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -402,12 +402,18 @@
> compatible = "samsung,exynos4210-ehci";
> reg = <0x12110000 0x100>;
> interrupts = <0 71 0>;
> +
> + clocks = <&clock 285>;
> + clock-names = "usbhost";
> };
>
> usb@12120000 {
> compatible = "samsung,exynos4210-ohci";
> reg = <0x12120000 0x100>;
> interrupts = <0 71 0>;
> +
> + clocks = <&clock 285>;
> + clock-names = "usbhost";
> };
>
> amba {
> --
> 1.8.1.3
Hi,
On Fri, Mar 15, 2013 at 7:07 AM, Jingoo Han <[email protected]> wrote:
>
> On Thursday, March 14, 2013 2:18 AM, Doug Anderson wrote:
>>
>> This is a fixup to two device tree nodes that have already landed but
>> without clock nodes since the transition to common clock happened at
>> the same time.
>>
>> Signed-off-by: Doug Anderson <[email protected]>
>
> The clock number and name are right.
>
> Reviewed-by: Jingoo Han <[email protected]>
>
>
> Best regards,
> Jingoo Han
>
>> ---
>> arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
>> index 24c52e6..59be603 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -402,12 +402,18 @@
>> compatible = "samsung,exynos4210-ehci";
>> reg = <0x12110000 0x100>;
>> interrupts = <0 71 0>;
>> +
>> + clocks = <&clock 285>;
>> + clock-names = "usbhost";
>> };
>>
>> usb@12120000 {
>> compatible = "samsung,exynos4210-ohci";
>> reg = <0x12120000 0x100>;
>> interrupts = <0 71 0>;
>> +
>> + clocks = <&clock 285>;
>> + clock-names = "usbhost";
tested this patch with smdk5250 h/w.
Tested-by: Vivek Gautam <[email protected]>
--
Thanks & Regards
Vivek
Vivek Gautam wrote:
>
> Hi,
>
>
> On Fri, Mar 15, 2013 at 7:07 AM, Jingoo Han <[email protected]> wrote:
> >
> > On Thursday, March 14, 2013 2:18 AM, Doug Anderson wrote:
> >>
> >> This is a fixup to two device tree nodes that have already landed but
> >> without clock nodes since the transition to common clock happened at
> >> the same time.
> >>
> >> Signed-off-by: Doug Anderson <[email protected]>
> >
> > The clock number and name are right.
> >
> > Reviewed-by: Jingoo Han <[email protected]>
> >
> >
> > Best regards,
> > Jingoo Han
> >
> >> ---
> >> arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> >> index 24c52e6..59be603 100644
> >> --- a/arch/arm/boot/dts/exynos5250.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> >> @@ -402,12 +402,18 @@
> >> compatible = "samsung,exynos4210-ehci";
> >> reg = <0x12110000 0x100>;
> >> interrupts = <0 71 0>;
> >> +
> >> + clocks = <&clock 285>;
> >> + clock-names = "usbhost";
> >> };
> >>
> >> usb@12120000 {
> >> compatible = "samsung,exynos4210-ohci";
> >> reg = <0x12120000 0x100>;
> >> interrupts = <0 71 0>;
> >> +
> >> + clocks = <&clock 285>;
> >> + clock-names = "usbhost";
>
> tested this patch with smdk5250 h/w.
>
> Tested-by: Vivek Gautam <[email protected]>
>
Vivek and Jingoo,
Thanks for your review and test.
Looks good to me and I applied in my local.
Just note that this should be seen in my public tree tomorrow night(KST).
- Kukjin