2023-08-23 07:30:10

by Jesper Dangaard Brouer

[permalink] [raw]
Subject: Re: [PATCH v2 net] octeontx2-pf: fix page_pool creation fail for rings > 32k



On 23/08/2023 04.53, Ratheesh Kannoth wrote:
> octeontx2 driver calls page_pool_create() during driver probe()
> and fails if queue size > 32k. Page pool infra uses these buffers
> as shock absorbers for burst traffic. These pages are pinned down
> over time as working sets varies, due to the recycling nature
> of page pool, given page pool (currently) don't have a shrinker
> mechanism, the pages remain pinned down in ptr_ring.
> Instead of clamping page_pool size to 32k at
> most, limit it even more to 2k to avoid wasting memory.
>
> This have been tested on octeontx2 CN10KA hardware.
> TCP and UDP tests using iperf shows no performance regressions.
>
> Fixes: b2e3406a38f0 ("octeontx2-pf: Add support for page pool")
> Suggested-by: Alexander Lobakin<[email protected]>
> Reviewed-by: Sunil Goutham<[email protected]>
> Signed-off-by: Ratheesh Kannoth<[email protected]>

LGTM

Acked-by: Jesper Dangaard Brouer <[email protected]>