Of course, we should do that AFAP. Thanks for your comments :)
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Michal Hocko
Sent: Thursday, November 30, 2017 5:45 PM
To: Wang, Kemi <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>; Andrew Morton <[email protected]>; Vlastimil Babka <[email protected]>; Mel Gorman <[email protected]>; Johannes Weiner <[email protected]>; Christopher Lameter <[email protected]>; YASUAKI ISHIMATSU <[email protected]>; Andrey Ryabinin <[email protected]>; Nikolay Borisov <[email protected]>; Pavel Tatashin <[email protected]>; David Rientjes <[email protected]>; Sebastian Andrzej Siewior <[email protected]>; Dave <[email protected]>; Kleen, Andi <[email protected]>; Chen, Tim C <[email protected]>; Jesper Dangaard Brouer <[email protected]>; Huang, Ying <[email protected]>; Lu, Aaron <[email protected]>; Li, Aubrey <[email protected]>; Linux MM <[email protected]>; Linux Kernel <[email protected]>
Subject: Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement
On Thu 30-11-17 17:32:08, kemi wrote:
[...]
> Your patch saves more code than mine because the node stats framework
> is reused for numa stats. But it has a performance regression because
> of the limitation of threshold size (125 at most, see
> calculate_normal_threshold() in vmstat.c) in inc_node_state().
But this "regression" would be visible only on those workloads which really need to squeeze every single cycle out of the allocation hot path and those are supposed to disable the accounting altogether. Or is this visible on a wider variety of workloads.
Do not get me wrong. If we want to make per-node stats more optimal, then by all means let's do that. But having 3 sets of counters is just way to much.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
From 1585483821488591184@xxx Thu Nov 30 09:46:39 +0000 2017
X-GM-THRID: 1585288579833195240
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread