2014-10-08 07:25:34

by Maarten ter Huurne

[permalink] [raw]
Subject: Re: [PATCH] fonts: Add 6x10 font

On Tuesday 30 September 2014 12:41:46 Tomi Valkeinen wrote:
> Hi,
>
> On 09/09/14 14:46, Maarten ter Huurne wrote:
> > This font is suitable for framebuffer consoles on devices with a
> > 320x240 screen, to get a reasonable number of characters (53x24) that
> > are still at a readable size.
> >
> > The font is derived from the existing 6x11 font, but gets 3 extra
> > lines without sacrificing readability. Also I redesigned a some glyhps
> > so they are more distinct and better fill the available space.
> >
> > Signed-off-by: Maarten ter Huurne <[email protected]>
> > ---
> >
> > include/linux/font.h | 4 +-
> > lib/fonts/Kconfig | 9 +
> > lib/fonts/Makefile | 1 +
> > lib/fonts/font_6x10.c | 3086
> > +++++++++++++++++++++++++++++++++++++++++++++++++ lib/fonts/fonts.c
> > | 4 +
> > 5 files changed, 3103 insertions(+), 1 deletion(-)
> > create mode 100644 lib/fonts/font_6x10.c
>
> I think the patch is fine, but there hasn't been any comments or acks
> for this. I'm a bit reluctant to add this much data to the kernel if
> there are no users (except you) for this.

Are you counting end users, developers or projects? We've got at least
several thousand end users in OpenDingux for Dingoo A320 and GCW Zero
combined. I could ask a few fellow developers for signed-off-by lines, if
that helps. But it's all from the same project.

I think the font fills a space that is currently unoccupied: the 4x6 font is
space efficient but barely readable, the 8x8 font gets only 40 columns on
320x240 and the 6x11 font doesn't use the vertical space efficiently.

Bye,
Maarten


2014-10-09 09:02:36

by Tomi Valkeinen

[permalink] [raw]
Subject: Re: [PATCH] fonts: Add 6x10 font

On 08/10/14 10:25, Maarten ter Huurne wrote:
> On Tuesday 30 September 2014 12:41:46 Tomi Valkeinen wrote:
>> Hi,
>>
>> On 09/09/14 14:46, Maarten ter Huurne wrote:
>>> This font is suitable for framebuffer consoles on devices with a
>>> 320x240 screen, to get a reasonable number of characters (53x24) that
>>> are still at a readable size.
>>>
>>> The font is derived from the existing 6x11 font, but gets 3 extra
>>> lines without sacrificing readability. Also I redesigned a some glyhps
>>> so they are more distinct and better fill the available space.
>>>
>>> Signed-off-by: Maarten ter Huurne <[email protected]>
>>> ---
>>>
>>> include/linux/font.h | 4 +-
>>> lib/fonts/Kconfig | 9 +
>>> lib/fonts/Makefile | 1 +
>>> lib/fonts/font_6x10.c | 3086
>>> +++++++++++++++++++++++++++++++++++++++++++++++++ lib/fonts/fonts.c
>>> | 4 +
>>> 5 files changed, 3103 insertions(+), 1 deletion(-)
>>> create mode 100644 lib/fonts/font_6x10.c
>>
>> I think the patch is fine, but there hasn't been any comments or acks
>> for this. I'm a bit reluctant to add this much data to the kernel if
>> there are no users (except you) for this.
>
> Are you counting end users, developers or projects? We've got at least
> several thousand end users in OpenDingux for Dingoo A320 and GCW Zero
> combined. I could ask a few fellow developers for signed-off-by lines, if
> that helps. But it's all from the same project.
>
> I think the font fills a space that is currently unoccupied: the 4x6 font is
> space efficient but barely readable, the 8x8 font gets only 40 columns on
> 320x240 and the 6x11 font doesn't use the vertical space efficiently.

Ok, sounds good enough for me. Queueing for 3.18.

Tomi



Attachments:
signature.asc (819.00 B)
OpenPGP digital signature