2020-08-26 03:57:50

by Yue Haibing

Subject: [PATCH -next] irqchip/ti-sci-inta: Fix unsigned comparison to zero

ti_sci_inta_xlate_irq() return -ENOENT on fail, p_hwirq
should be int type.

Fixes: 5c4b585d2910 ("irqchip/ti-sci-inta: Add support for INTA directly connecting to GIC")
Signed-off-by: YueHaibing <[email protected]>
---
drivers/irqchip/irq-ti-sci-inta.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
index d4e97605456b..05bf94b87b93 100644
--- a/drivers/irqchip/irq-ti-sci-inta.c
+++ b/drivers/irqchip/irq-ti-sci-inta.c
@@ -175,8 +175,8 @@ static struct ti_sci_inta_vint_desc *ti_sci_inta_alloc_parent_irq(struct irq_dom
struct irq_fwspec parent_fwspec;
struct device_node *parent_node;
unsigned int parent_virq;
- u16 vint_id, p_hwirq;
- int ret;
+ int p_hwirq, ret;
+ u16 vint_id;

vint_id = ti_sci_get_free_resource(inta->vint);
if (vint_id == TI_SCI_RESOURCE_NULL)
--
2.20.1

2020-08-26 04:01:32

by Lokesh Vutla

Subject: Re: [PATCH -next] irqchip/ti-sci-inta: Fix unsigned comparison to zero

On 26/08/20 9:24 am, YueHaibing wrote:
> ti_sci_inta_xlate_irq() return -ENOENT on fail, p_hwirq
> should be int type.
>
> Fixes: 5c4b585d2910 ("irqchip/ti-sci-inta: Add support for INTA directly connecting to GIC")
> Signed-off-by: YueHaibing <[email protected]>


Acked-by: Lokesh Vutla <[email protected]>

Thanks and regards,
Lokesh

2020-09-13 15:21:38

by Marc Zyngier

Subject: Re: [PATCH -next] irqchip/ti-sci-inta: Fix unsigned comparison to zero

On Wed, 26 Aug 2020 11:54:30 +0800, YueHaibing wrote:
> ti_sci_inta_xlate_irq() return -ENOENT on fail, p_hwirq
> should be int type.

Applied to irq/irqchip-fixes-5.9, thanks!

[1/1] irqchip/ti-sci-inta: Fix unsigned comparison to zero
commit: 4c9b1bfaa5039fee650f4de514a8e70ae976fc2f

Cheers,

M.
--
Without deviation from the norm, progress is not possible.

2020-10-11 18:13:06

by tip-bot2 for Jacob Pan

Subject: [tip: irq/core] irqchip/ti-sci-inta: Fix unsigned comparison to zero

The following commit has been merged into the irq/core branch of tip:

Commit-ID: 4c9b1bfaa5039fee650f4de514a8e70ae976fc2f
Gitweb: https://git.kernel.org/tip/4c9b1bfaa5039fee650f4de514a8e70ae976fc2f
Author: YueHaibing <[email protected]>
AuthorDate: Wed, 26 Aug 2020 11:54:30 +08:00
Committer: Marc Zyngier <[email protected]>
CommitterDate: Sun, 13 Sep 2020 15:30:00 +01:00

irqchip/ti-sci-inta: Fix unsigned comparison to zero

ti_sci_inta_xlate_irq() return -ENOENT on fail, p_hwirq
should be int type.

Fixes: 5c4b585d2910 ("irqchip/ti-sci-inta: Add support for INTA directly connecting to GIC")
Signed-off-by: YueHaibing <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
Acked-by: Lokesh Vutla <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/irqchip/irq-ti-sci-inta.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
index d4e9760..05bf94b 100644
--- a/drivers/irqchip/irq-ti-sci-inta.c
+++ b/drivers/irqchip/irq-ti-sci-inta.c
@@ -175,8 +175,8 @@ static struct ti_sci_inta_vint_desc *ti_sci_inta_alloc_parent_irq(struct irq_dom
struct irq_fwspec parent_fwspec;
struct device_node *parent_node;
unsigned int parent_virq;
- u16 vint_id, p_hwirq;
- int ret;
+ int p_hwirq, ret;
+ u16 vint_id;

vint_id = ti_sci_get_free_resource(inta->vint);
if (vint_id == TI_SCI_RESOURCE_NULL)