2021-05-06 15:29:35

by Mauro Carvalho Chehab

Subject: [PATCH v5 16/25] media: rcar-fcp: use pm_runtime_resume_and_get()

Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.

Use the new API, in order to cleanup the error check logic.

As a bonus, pm_runtime_resume_and_get() always return 0 on success.
So, the code can be simplified.

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---
drivers/media/platform/rcar-fcp.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/media/platform/rcar-fcp.c b/drivers/media/platform/rcar-fcp.c
index 5c03318ae07b..a3a7afc03d7b 100644
--- a/drivers/media/platform/rcar-fcp.c
+++ b/drivers/media/platform/rcar-fcp.c
@@ -101,13 +101,7 @@ int rcar_fcp_enable(struct rcar_fcp_device *fcp)
if (!fcp)
return 0;

- ret = pm_runtime_get_sync(fcp->dev);
- if (ret < 0) {
- pm_runtime_put_noidle(fcp->dev);
- return ret;
- }
-
- return 0;
+ return pm_runtime_resume_and_get(fcp->dev);
}
EXPORT_SYMBOL_GPL(rcar_fcp_enable);

--
2.30.2

2021-05-06 19:34:17

by Laurent Pinchart

Subject: Re: [PATCH v5 16/25] media: rcar-fcp: use pm_runtime_resume_and_get()

Hi Mauro,

Thank you for the patch.

On Thu, May 06, 2021 at 05:25:54PM +0200, Mauro Carvalho Chehab wrote:
> Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
> added pm_runtime_resume_and_get() in order to automatically handle
> dev->power.usage_count decrement on errors.
>
> Use the new API, in order to cleanup the error check logic.
>
> As a bonus, pm_runtime_resume_and_get() always return 0 on success.
> So, the code can be simplified.
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/media/platform/rcar-fcp.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/media/platform/rcar-fcp.c b/drivers/media/platform/rcar-fcp.c
> index 5c03318ae07b..a3a7afc03d7b 100644
> --- a/drivers/media/platform/rcar-fcp.c
> +++ b/drivers/media/platform/rcar-fcp.c
> @@ -101,13 +101,7 @@ int rcar_fcp_enable(struct rcar_fcp_device *fcp)
> if (!fcp)
> return 0;
>
> - ret = pm_runtime_get_sync(fcp->dev);
> - if (ret < 0) {
> - pm_runtime_put_noidle(fcp->dev);
> - return ret;
> - }
> -
> - return 0;
> + return pm_runtime_resume_and_get(fcp->dev);
> }
> EXPORT_SYMBOL_GPL(rcar_fcp_enable);
>

--
Regards,

Laurent Pinchart