2021-11-25 08:35:48

by [email protected]

[permalink] [raw]
Subject: [PATCH v2] acpi/tables: Add AEST in ACPI Table Definition

When We added AEST using the Upgrading ACPI tables via initrd function,
the kernel could not recognize the AEST, so added the AEST table to
the list to enable the table upgrade function.

Change log:
v2 : The reason for committing in the commit log was not clear,
so it was pointed out and corrected.

Signed-off-by: Shuuichirou Ishii <[email protected]>
---
drivers/acpi/tables.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index 71419eb16e09..2699bf7e21ab 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -500,7 +500,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
- ACPI_SIG_NHLT };
+ ACPI_SIG_NHLT, ACPI_SIG_AEST };

#define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)

--
2.27.0



2021-11-27 03:03:36

by Hanjun Guo

[permalink] [raw]
Subject: Re: [PATCH v2] acpi/tables: Add AEST in ACPI Table Definition

On 2021/11/25 16:32, Shuuichirou Ishii wrote:
> When We added AEST using the Upgrading ACPI tables via initrd function,
> the kernel could not recognize the AEST, so added the AEST table to
> the list to enable the table upgrade function.
>
> Change log:
> v2 : The reason for committing in the commit log was not clear,
> so it was pointed out and corrected.

Please remove the change log in the commit message.

>
> Signed-off-by: Shuuichirou Ishii <[email protected]>
> ---

You can put the change log here then it will be removed
when applying this patch.

Thanks
Hanjun

2021-11-28 23:56:22

by [email protected]

[permalink] [raw]
Subject: RE: [PATCH v2] acpi/tables: Add AEST in ACPI Table Definition

Hi, Hanjun.

Thank you for your comment.
We apologize for the basic mistake.

We will try to fix it as follows, is it OK?

---
Subject: [PATCH v3] acpi/tables: Add AEST in ACPI Table Definition

When We added AEST using the Upgrading ACPI tables via initrd function,
the kernel could not recognize the AEST, so added the AEST table to
the list to enable the table upgrade function.

Signed-off-by: Shuuichirou Ishii <[email protected]>
---
v3 : Changed the location of the change log so that it does not
disappear when the patch is applied.

v2 : The reason for committing in the commit log was not clear,
so it was pointed out and corrected.

drivers/acpi/tables.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index 71419eb16e09..2699bf7e21ab 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -500,7 +500,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
- ACPI_SIG_NHLT };
+ ACPI_SIG_NHLT, ACPI_SIG_AEST };

#define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)

--

Best regards,
Shuuichrou.

> -----Original Message-----
> From: Hanjun Guo <[email protected]>
> Sent: Saturday, November 27, 2021 12:01 PM
> To: Ishii, Shuuichirou/石井 周一郎 <[email protected]>;
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]
> Cc: [email protected]
> Subject: Re: [PATCH v2] acpi/tables: Add AEST in ACPI Table Definition
>
> On 2021/11/25 16:32, Shuuichirou Ishii wrote:
> > When We added AEST using the Upgrading ACPI tables via initrd
> > function, the kernel could not recognize the AEST, so added the AEST
> > table to the list to enable the table upgrade function.
> >
> > Change log:
> > v2 : The reason for committing in the commit log was not clear,
> > so it was pointed out and corrected.
>
> Please remove the change log in the commit message.
>
> >
> > Signed-off-by: Shuuichirou Ishii <[email protected]>
> > ---
>
> You can put the change log here then it will be removed when applying this patch.
>
> Thanks
> Hanjun

2021-11-29 01:03:32

by Hanjun Guo

[permalink] [raw]
Subject: Re: [PATCH v2] acpi/tables: Add AEST in ACPI Table Definition

On 2021/11/29 7:54, [email protected] wrote:
> Hi, Hanjun.
>
> Thank you for your comment.
> We apologize for the basic mistake.
>
> We will try to fix it as follows, is it OK?
>
> ---
> Subject: [PATCH v3] acpi/tables: Add AEST in ACPI Table Definition
>
> When We added AEST using the Upgrading ACPI tables via initrd function,
> the kernel could not recognize the AEST, so added the AEST table to
> the list to enable the table upgrade function.
>
> Signed-off-by: Shuuichirou Ishii <[email protected]>
> ---
> v3 : Changed the location of the change log so that it does not
> disappear when the patch is applied.
>
> v2 : The reason for committing in the commit log was not clear,
> so it was pointed out and corrected.

Looks good to me.

Thanks
Hanjun

2021-11-29 01:35:50

by [email protected]

[permalink] [raw]
Subject: RE: [PATCH v2] acpi/tables: Add AEST in ACPI Table Definition

Thanks for the review.
We will repost the patch to reflect the contents.

Best regards,
Shuuichirou.

> -----Original Message-----
> From: Hanjun Guo <[email protected]>
> Sent: Monday, November 29, 2021 10:01 AM
> To: Ishii, Shuuichirou/石井 周一郎 <[email protected]>;
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]
> Cc: [email protected]
> Subject: Re: [PATCH v2] acpi/tables: Add AEST in ACPI Table Definition
>
> On 2021/11/29 7:54, [email protected] wrote:
> > Hi, Hanjun.
> >
> > Thank you for your comment.
> > We apologize for the basic mistake.
> >
> > We will try to fix it as follows, is it OK?
> >
> > ---
> > Subject: [PATCH v3] acpi/tables: Add AEST in ACPI Table Definition
> >
> > When We added AEST using the Upgrading ACPI tables via initrd
> > function, the kernel could not recognize the AEST, so added the AEST
> > table to the list to enable the table upgrade function.
> >
> > Signed-off-by: Shuuichirou Ishii <[email protected]>
> > ---
> > v3 : Changed the location of the change log so that it does not
> > disappear when the patch is applied.
> >
> > v2 : The reason for committing in the commit log was not clear,
> > so it was pointed out and corrected.
>
> Looks good to me.
>
> Thanks
> Hanjun