2013-03-22 10:43:31

by Wolfram Sang

Subject: Re: I2C: Fix i2c fail problem when a process is terminated by a signal on octeon in 3.8

On Tue, Feb 26, 2013 at 09:08:43PM +0000, 송은봉 wrote:
>
> I've been debugging the abnormal operation of i2c on octeon.
> If a process is terminated by signal in the middle of i2c operation,
> next i2c read operation which is done by another process was failed.
> So i changed to ignore signal in the middle of i2c operation.
> After that the problem was not reproduced.
>
>
>
> Signed-off-by: EunBong Song <[email protected]>

Basically OK, but you have lots of whitespace issues, so I can't apply
your patch. Please resend and make sure it applies.

Thanks,

Wolfram

2013-03-22 15:03:32

by EUNBONG SONG

Subject: Re: Re: I2C: Fix i2c fail problem when a process is terminated by a signal on octeon in 3.8

>Basically OK, but you have lots of whitespace issues, so I can't apply
>your patch. Please resend and make sure it applies.

Sorry, I rewrite my patch here.

Signed-off-by: EunBong Song <[email protected]>
---
drivers/i2c/busses/i2c-octeon.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c
index 935585e..b2e3259 100644
--- a/drivers/i2c/busses/i2c-octeon.c
+++ b/drivers/i2c/busses/i2c-octeon.c
@@ -183,7 +183,7 @@ static irqreturn_t octeon_i2c_isr(int irq, void *dev_id)
struct octeon_i2c *i2c = dev_id;

octeon_i2c_int_disable(i2c);
- wake_up_interruptible(&i2c->queue);
+ wake_up(&i2c->queue);

return IRQ_HANDLED;
}
@@ -206,9 +206,9 @@ static int octeon_i2c_wait(struct octeon_i2c *i2c)

octeon_i2c_int_enable(i2c);

- result = wait_event_interruptible_timeout(i2c->queue,
- octeon_i2c_test_iflg(i2c),
- i2c->adap.timeout);
+ result = wait_event_timeout(i2c->queue,
+ octeon_i2c_test_iflg(i2c),
+ i2c->adap.timeout);

octeon_i2c_int_disable(i2c);

--
1.7.0.1

Thanks.????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?