2015-06-29 12:23:48

by Geert Uytterhoeven

Subject: [PATCH] [media] mt9v032: Add missing initialization of pdata in mt9v032_get_pdata()

drivers/media/i2c/mt9v032.c: In function ‘mt9v032_get_pdata’:
drivers/media/i2c/mt9v032.c:885: warning: ‘pdata’ may be used uninitialized in this function

If parsing the endpoint node properties fails, mt9v032_get_pdata() will
return an uninitialized pointer value.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/media/i2c/mt9v032.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c
index 977f4006edbd496d..a68ce94ee097604a 100644
--- a/drivers/media/i2c/mt9v032.c
+++ b/drivers/media/i2c/mt9v032.c
@@ -882,7 +882,7 @@ static const struct regmap_config mt9v032_regmap_config = {
static struct mt9v032_platform_data *
mt9v032_get_pdata(struct i2c_client *client)
{
- struct mt9v032_platform_data *pdata;
+ struct mt9v032_platform_data *pdata = NULL;
struct v4l2_of_endpoint endpoint;
struct device_node *np;
struct property *prop;
--
1.9.1

2015-06-30 09:05:14

by Laurent Pinchart

Subject: Re: [PATCH] [media] mt9v032: Add missing initialization of pdata in mt9v032_get_pdata()

Hi Geert,

Thank you for the patch.

On Monday 29 June 2015 14:23:41 Geert Uytterhoeven wrote:
> drivers/media/i2c/mt9v032.c: In function ‘mt9v032_get_pdata’:
> drivers/media/i2c/mt9v032.c:885: warning: ‘pdata’ may be used uninitialized
> in this function
>
> If parsing the endpoint node properties fails, mt9v032_get_pdata() will
> return an uninitialized pointer value.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Acked-by: Laurent Pinchart <[email protected]>

and applied to my tree.

> ---
> drivers/media/i2c/mt9v032.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c
> index 977f4006edbd496d..a68ce94ee097604a 100644
> --- a/drivers/media/i2c/mt9v032.c
> +++ b/drivers/media/i2c/mt9v032.c
> @@ -882,7 +882,7 @@ static const struct regmap_config mt9v032_regmap_config
> = { static struct mt9v032_platform_data *
> mt9v032_get_pdata(struct i2c_client *client)
> {
> - struct mt9v032_platform_data *pdata;
> + struct mt9v032_platform_data *pdata = NULL;
> struct v4l2_of_endpoint endpoint;
> struct device_node *np;
> struct property *prop;

--
Regards,

Laurent Pinchart