Hi Samuel,
Today's linux-next build (x86_64 allmodconfig) failed like this:
drivers/built-in.o: In function `pm8607_write_device':
88pm8607.c:(.text+0xd02e9): undefined reference to `i2c_master_send'
drivers/built-in.o: In function `pm8607_read_device':
88pm8607.c:(.text+0xd033b): undefined reference to `i2c_master_send'
88pm8607.c:(.text+0xd035c): undefined reference to `i2c_master_recv'
drivers/built-in.o: In function `pm8607_init':
88pm8607.c:(.init.text+0xa9bd): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `pm8607_probe':
88pm8607.c:(.devinit.text+0x4db6): undefined reference to `mfd_add_devices'
drivers/built-in.o: In function `pm8607_exit':
88pm8607.c:(.exit.text+0x598): undefined reference to `i2c_del_driver'
drivers/built-in.o: In function `pm8607_remove':
88pm8607.c:(.devexit.text+0x198): undefined reference to `mfd_remove_devices'
Obviously caused by commit 9ec6cd8f2235ddeee5b39068956f14238a12a617
("mfd: Add 88PM8607 driver").
This build has CONFIG_I2C=m and CONFIG_MFD_CORE=m.
I have used the version of the mfd tree form next-20091005 for today.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
Hi Stephen,
Could you send your .config file to me? The 88pm8607 patch is just for mfd-2.6 git tree. I didn't try it in linux-next git tree before. I can try it now. If I could have your .config file, it would be better.
Thanks
Haojian
-----Original Message-----
From: Stephen Rothwell [mailto:[email protected]]
Sent: 2009??10??6?? 10:02 AM
To: Samuel Ortiz
Cc: [email protected]; [email protected]; Haojian Zhuang; Mark Brown
Subject: linux-next: mfd tree build failure
Hi Samuel,
Today's linux-next build (x86_64 allmodconfig) failed like this:
drivers/built-in.o: In function `pm8607_write_device':
88pm8607.c:(.text+0xd02e9): undefined reference to `i2c_master_send'
drivers/built-in.o: In function `pm8607_read_device':
88pm8607.c:(.text+0xd033b): undefined reference to `i2c_master_send'
88pm8607.c:(.text+0xd035c): undefined reference to `i2c_master_recv'
drivers/built-in.o: In function `pm8607_init':
88pm8607.c:(.init.text+0xa9bd): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `pm8607_probe':
88pm8607.c:(.devinit.text+0x4db6): undefined reference to `mfd_add_devices'
drivers/built-in.o: In function `pm8607_exit':
88pm8607.c:(.exit.text+0x598): undefined reference to `i2c_del_driver'
drivers/built-in.o: In function `pm8607_remove':
88pm8607.c:(.devexit.text+0x198): undefined reference to `mfd_remove_devices'
Obviously caused by commit 9ec6cd8f2235ddeee5b39068956f14238a12a617
("mfd: Add 88PM8607 driver").
This build has CONFIG_I2C=m and CONFIG_MFD_CORE=m.
I have used the version of the mfd tree form next-20091005 for today.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay? ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?
Hi Haojian,
On Mon, 5 Oct 2009 19:35:05 -0700 Haojian Zhuang <[email protected]> wrote:
>
> Could you send your .config file to me? The 88pm8607 patch is just for mfd-2.6 git tree. I didn't try it in linux-next git tree before. I can try it now. If I could have your .config file, it would be better.
I am sorry, but I don't have the exact .config file any more (I have
moved on in my creation of linux-next) however, as I said, this was an
allmodconfig build on x86_64. I also noted that CONFIG_I2C=m and
CONFIG_MFD_CORE=m, while the config entry that controls the building of
this driver is a bool so must have been 'y'. So from a builtin driver,
you are referring to symbols that are only defined in modules.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
Hi Stephen,
Thanks a lot for your help. I fix it now. Please help to review it. It's already passed the build test.
Best Regards
Haojian
-----Original Message-----
From: Stephen Rothwell [mailto:[email protected]]
Sent: 2009??10??6?? 11:54 AM
To: Haojian Zhuang
Cc: Samuel Ortiz; [email protected]; [email protected]; Mark Brown
Subject: Re: linux-next: mfd tree build failure
Hi Haojian,
On Mon, 5 Oct 2009 19:35:05 -0700 Haojian Zhuang <[email protected]> wrote:
>
> Could you send your .config file to me? The 88pm8607 patch is just for mfd-2.6 git tree. I didn't try it in linux-next git tree before. I can try it now. If I could have your .config file, it would be better.
I am sorry, but I don't have the exact .config file any more (I have
moved on in my creation of linux-next) however, as I said, this was an
allmodconfig build on x86_64. I also noted that CONFIG_I2C=m and
CONFIG_MFD_CORE=m, while the config entry that controls the building of
this driver is a bool so must have been 'y'. So from a builtin driver,
you are referring to symbols that are only defined in modules.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
> -----Original Message-----
> From: Stephen Rothwell [mailto:[email protected]]
> Sent: 2009??10??6?? 11:54 AM
> To: Haojian Zhuang
> Cc: Samuel Ortiz; [email protected]; [email protected]; Mark Brown
> Subject: Re: linux-next: mfd tree build failure
>
> Hi Haojian,
>
> On Mon, 5 Oct 2009 19:35:05 -0700 Haojian Zhuang <[email protected]> wrote:
>>
>> Could you send your .config file to me? The 88pm8607 patch is just for mfd-2.6 git tree. I didn't try it in linux-next git tree before. I can try it now. If I could have your .config file, it would be better.
>
> I am sorry, but I don't have the exact .config file any more (I have
> moved on in my creation of linux-next) however, as I said, this was an
> allmodconfig build on x86_64. I also noted that CONFIG_I2C=m and
> CONFIG_MFD_CORE=m, while the config entry that controls the building of
> this driver is a bool so must have been 'y'. So from a builtin driver,
> you are referring to symbols that are only defined in modules.
>
> --
> Cheers,
> Stephen Rothwell [email protected]
> http://www.canb.auug.org.au/~sfr/
>
Hi Stephen & Samuel,
Please ignore the original fix patch on 88pm8607 dependancy. I write a
new patch on it and paste it in below. Please help to review it.
Thanks
Haojian
>From 26174b67184759ac2fe33748eeb43d3738732e21 Mon Sep 17 00:00:00 2001
From: Haojian Zhuang <[email protected]>
Date: Thu, 8 Oct 2009 09:07:05 -0400
Subject: [PATCH] mfd: fix the dependancy of 88PM8607
88PM8607 module is dependant on I2C. I2C module must be built-in.
Signed-off-by: Haojian Zhuang <[email protected]>
---
drivers/mfd/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index fbe684b..00064e2 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -307,7 +307,7 @@ config EZX_PCAP
config MFD_88PM8607
bool "Support Marvell 88PM8607"
- depends on I2C
+ depends on I2C=y
select MFD_CORE
help
This supports for Marvell 88PM8607 Power Management IC. This includes
--
1.5.6.5
Hi Samuel,
On Tue, 6 Oct 2009 13:02:02 +1100 Stephen Rothwell <[email protected]> wrote:
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> drivers/built-in.o: In function `pm8607_write_device':
> 88pm8607.c:(.text+0xd02e9): undefined reference to `i2c_master_send'
> drivers/built-in.o: In function `pm8607_read_device':
> 88pm8607.c:(.text+0xd033b): undefined reference to `i2c_master_send'
> 88pm8607.c:(.text+0xd035c): undefined reference to `i2c_master_recv'
> drivers/built-in.o: In function `pm8607_init':
> 88pm8607.c:(.init.text+0xa9bd): undefined reference to `i2c_register_driver'
> drivers/built-in.o: In function `pm8607_probe':
> 88pm8607.c:(.devinit.text+0x4db6): undefined reference to `mfd_add_devices'
> drivers/built-in.o: In function `pm8607_exit':
> 88pm8607.c:(.exit.text+0x598): undefined reference to `i2c_del_driver'
> drivers/built-in.o: In function `pm8607_remove':
> 88pm8607.c:(.devexit.text+0x198): undefined reference to `mfd_remove_devices'
>
> Obviously caused by commit 9ec6cd8f2235ddeee5b39068956f14238a12a617
> ("mfd: Add 88PM8607 driver").
>
> This build has CONFIG_I2C=m and CONFIG_MFD_CORE=m.
>
> I have used the version of the mfd tree form next-20091005 for today.
This build failure is still happening and I am still using the mfd tree
from next-20091005.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/