2010-02-08 16:01:27

by Roel Kluin

[permalink] [raw]
Subject: FRV: possibly bad unsigned comparison in show_backtrace()

In arch/frv/kernel/traps.c, show_backtrace(), if sp is 0
then the dump does not succeed because stop was set to 0
and unaltered when we reach the unsigned comparison:

while (tos < stop) {...}

The naming stop may on the other hand suggest that this
is desired, is it?

Roel


2010-02-08 18:43:52

by Roel Kluin

[permalink] [raw]
Subject: Re: FRV: possibly bad unsigned comparison in show_backtrace()

On Mon, Feb 8, 2010 at 5:08 PM, Roel Kluin <[email protected]> wrote:
> In arch/frv/kernel/traps.c, show_backtrace(), if sp is 0
> then the dump does not succeed because stop was set to 0
> and unaltered when we reach the unsigned comparison:
>
>  while (tos < stop) {...}

I was mistaken, a while (tos >= stop) won't end

Roel