2017-11-22 06:09:49

by Timur Tabi

[permalink] [raw]
Subject: Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function

On 11/21/17 11:55 PM, Sinan Kaya wrote:
> For places where domain number information is available, I extracted domain number
> and added into pci_get_domain_bus_and_slot() call such as xen or bn drivers.

My suggestion is that you restrict your first patch set to only these
patches.

> The assumption at this point is for pci_get_bus_and_slot() usages to be caught
> in code-review.

How about this:

static inline struct pci_dev * __deprecated
pci_get_bus_and_slot(unsigned int bus,
unsigned int devfn)
{
return pci_get_domain_bus_and_slot(0, bus, devfn);
}


--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

From 1584744601579201770@xxx Wed Nov 22 05:57:04 +0000 2017
X-GM-THRID: 1584743149582609571
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread