2021-11-05 18:35:02

by Rafael J. Wysocki

Subject: [PATCH] thermal: Replace pr_warn() with pr_warn_once() in user_space_bind()

From: Rafael J. Wysocki <[email protected]>

Use pr_warn_once() instead of pr_warn() to print the user space
governor deprecation message in user_space_bind() to reduce the
kernel log noise.

Fixes: 0275c9fb0eff ("thermal/core: Make the userspace governor deprecated")
Signed-off-by: Rafael J. Wysocki <[email protected]>
---
drivers/thermal/gov_user_space.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-pm/drivers/thermal/gov_user_space.c
===================================================================
--- linux-pm.orig/drivers/thermal/gov_user_space.c
+++ linux-pm/drivers/thermal/gov_user_space.c
@@ -17,8 +17,8 @@

static int user_space_bind(struct thermal_zone_device *tz)
{
- pr_warn("Userspace governor deprecated: use thermal netlink " \
- "notification instead\n");
+ pr_warn_once("Userspace governor deprecated: use thermal netlink " \
+ "notification instead\n");

return 0;
}

2021-11-05 18:50:01

by Daniel Lezcano

Subject: Re: [PATCH] thermal: Replace pr_warn() with pr_warn_once() in user_space_bind()

On 05/11/2021 17:31, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <[email protected]>
>
> Use pr_warn_once() instead of pr_warn() to print the user space
> governor deprecation message in user_space_bind() to reduce the
> kernel log noise.
>
> Fixes: 0275c9fb0eff ("thermal/core: Make the userspace governor deprecated")
> Signed-off-by: Rafael J. Wysocki <[email protected]>
Acked-by: Daniel Lezcano <[email protected]>

> ---
> drivers/thermal/gov_user_space.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-pm/drivers/thermal/gov_user_space.c
> ===================================================================
> --- linux-pm.orig/drivers/thermal/gov_user_space.c
> +++ linux-pm/drivers/thermal/gov_user_space.c
> @@ -17,8 +17,8 @@
>
> static int user_space_bind(struct thermal_zone_device *tz)
> {
> - pr_warn("Userspace governor deprecated: use thermal netlink " \
> - "notification instead\n");
> + pr_warn_once("Userspace governor deprecated: use thermal netlink " \
> + "notification instead\n");
>
> return 0;
> }
>
>
>


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog