2020-04-01 21:48:30

by Zach van Rijn

[permalink] [raw]
Subject: [PATCH] um: add include: memset() and memcpy() are in <string.h>

These two functions are otherwise unknown to the pedantic compiler.
Include the correct header to enable the build to succeed.

Signed-off-by: Zach van Rijn <[email protected]>
---
arch/um/os-Linux/file.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/um/os-Linux/file.c b/arch/um/os-Linux/file.c
index 26ecbd64c409..044836ad7392 100644
--- a/arch/um/os-Linux/file.c
+++ b/arch/um/os-Linux/file.c
@@ -6,6 +6,7 @@
#include <stdio.h>
#include <unistd.h>
#include <stdlib.h>
+#include <string.h>
#include <errno.h>
#include <fcntl.h>
#include <signal.h>
--
2.25.1



2020-04-02 07:45:47

by Anton Ivanov

[permalink] [raw]
Subject: Re: [PATCH] um: add include: memset() and memcpy() are in <string.h>



On 01/04/2020 22:30, Zach van Rijn wrote:
> These two functions are otherwise unknown to the pedantic compiler.
> Include the correct header to enable the build to succeed.
>
> Signed-off-by: Zach van Rijn <[email protected]>
> ---
> arch/um/os-Linux/file.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/um/os-Linux/file.c b/arch/um/os-Linux/file.c
> index 26ecbd64c409..044836ad7392 100644
> --- a/arch/um/os-Linux/file.c
> +++ b/arch/um/os-Linux/file.c
> @@ -6,6 +6,7 @@
> #include <stdio.h>
> #include <unistd.h>
> #include <stdlib.h>
> +#include <string.h>
> #include <errno.h>
> #include <fcntl.h>
> #include <signal.h>
>

Acked-By: Anton Ivanov <[email protected]>

--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/