2020-05-19 20:57:50

by Matt Helsley

Subject: [PATCH 1/3] objtool: Exit successfully when requesting help

When the user requests help it's not an error so do not exit with
a non-zero exit code. This is not especially useful for a user but
any script that might wish to check that objtool --help is at least
available can't rely on the exit code to crudely check that, for
example, building an objtool executable succeeds.

Signed-off-by: Matt Helsley <[email protected]>
---
tools/objtool/objtool.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/objtool/objtool.c b/tools/objtool/objtool.c
index 0b3528f05053..58fdda510653 100644
--- a/tools/objtool/objtool.c
+++ b/tools/objtool/objtool.c
@@ -58,7 +58,9 @@ static void cmd_usage(void)

printf("\n");

- exit(129);
+ if (!help)
+ exit(129);
+ exit(0);
}

static void handle_options(int *argc, const char ***argv)
--
2.20.1

2020-05-27 21:44:46

by Kamalesh Babulal

Subject: Re: [PATCH 1/3] objtool: Exit successfully when requesting help

On 5/20/20 2:25 AM, Matt Helsley wrote:
> When the user requests help it's not an error so do not exit with
> a non-zero exit code. This is not especially useful for a user but
> any script that might wish to check that objtool --help is at least
> available can't rely on the exit code to crudely check that, for
> example, building an objtool executable succeeds.
>
> Signed-off-by: Matt Helsley <[email protected]>

Reviewed-by: Kamalesh Babulal <[email protected]>

--
Kamalesh