This patchset enables more drivers for devices present on
Samsung Aries based devices.
First patch switches fimd to correct variant, which wasn't
present at moment of adding aries dts.
Next two patches removes hardcoded bootargs from dts files
for galaxys and fascinate4g, because now we have working bootloader
which can pass those values.
One of the patches also reserves memory for Samsung S5P MFC
video codec, so it's possible to use it.
Last two patches adds and enables more drivers.
Jonathan Bakker (1):
ARM: dts: s5pv210: aries: Support for more devices present on Aries
Paweł Chmiel (5):
ARM: dts: s5pv210: Use correct fimd variant
ARM: dts: s5pv210: galaxys: Remove hardcoded bootargs
ARM: dts: s5pv210: fascinate4g: Remove hardcoded bootargs
ARM: dts: s5pv210: aries: Add reserved memory for mfc
ARM: defconfig: s5pv210: Enable more drivers present on Samsung Aries
arch/arm/boot/dts/s5pv210-aries.dtsi | 90 +++++++++++++++++++++++
arch/arm/boot/dts/s5pv210-fascinate4g.dts | 7 --
arch/arm/boot/dts/s5pv210-galaxys.dts | 7 --
arch/arm/boot/dts/s5pv210.dtsi | 2 +-
arch/arm/configs/s5pv210_defconfig | 41 ++++++++---
5 files changed, 121 insertions(+), 26 deletions(-)
--
2.17.1
From: Jonathan Bakker <[email protected]>
This commit enables following devices present on Aries based phones:
- pwm-vibrator attached to PWM 1
- poweroff support
- Atmel maXTouch touchscreen. It's connected to i2c2
- Broadcom BCM4329 bluetooth over uart0
Signed-off-by: Jonathan Bakker <[email protected]>
Signed-off-by: Paweł Chmiel <[email protected]>
---
arch/arm/boot/dts/s5pv210-aries.dtsi | 68 ++++++++++++++++++++++++++++
1 file changed, 68 insertions(+)
diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
index 35ba009a1a33..b7246f879648 100644
--- a/arch/arm/boot/dts/s5pv210-aries.dtsi
+++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
@@ -41,6 +41,13 @@
};
};
+ vibrator_pwr: regulator-fixed-0 {
+ compatible = "regulator-fixed";
+ regulator-name = "vibrator-en";
+ enable-active-high;
+ gpio = <&gpj1 1 GPIO_ACTIVE_HIGH>;
+ };
+
wifi_pwrseq: wifi-pwrseq {
compatible = "mmc-pwrseq-simple";
reset-gpios = <&gpg1 2 GPIO_ACTIVE_LOW>;
@@ -314,6 +321,22 @@
reg = <0x36>;
};
};
+
+ vibrator: pwm-vibrator {
+ compatible = "pwm-vibrator";
+ pwms = <&pwm 1 44642 0>;
+ pwm-names = "enable";
+ vcc-supply = <&vibrator_pwr>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pwm1_out>;
+ };
+
+ poweroff: syscon-poweroff {
+ compatible = "syscon-poweroff";
+ regmap = <&pmu_syscon>;
+ offset = <0x681c>; /* PS_HOLD_CONTROL */
+ value = <0x5200>;
+ };
};
&fimd {
@@ -347,6 +370,23 @@
status = "okay";
};
+&i2c2 {
+ samsung,i2c-sda-delay = <100>;
+ samsung,i2c-max-bus-freq = <400000>;
+ samsung,i2c-slave-addr = <0x10>;
+ status = "okay";
+
+ touchscreen@4a {
+ compatible = "atmel,maxtouch";
+ reg = <0x4a>;
+ interrupt-parent = <&gpj0>;
+ interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&ts_irq>;
+ reset-gpios = <&gpj1 3 GPIO_ACTIVE_HIGH>;
+ };
+};
+
&mfc {
memory-region = <&mfc_left>, <&mfc_right>;
};
@@ -372,6 +412,13 @@
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
};
+ bt_host_wake: bt-host-wake {
+ samsung,pins = "gph2-5";
+ samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
+ samsung,pin-pud = <S3C64XX_PIN_PULL_DOWN>;
+ samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
+ };
+
tf_detect: tf-detect {
samsung,pins = "gph3-4";
samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
@@ -384,6 +431,17 @@
samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
};
+
+ ts_irq: ts-irq {
+ samsung,pins = "gpj0-5";
+ samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
+ samsung,pin-pud = <S3C64XX_PIN_PULL_UP>;
+ samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
+ };
+};
+
+&pwm {
+ samsung,pwm-outputs = <1>;
};
&sdhci1 {
@@ -421,6 +479,16 @@
&uart0 {
status = "okay";
+
+ bluetooth {
+ compatible = "brcm,bcm43438-bt";
+ max-speed = <115200>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart0_data &uart0_fctl &bt_host_wake>;
+ shutdown-gpios = <&gpb 3 GPIO_ACTIVE_HIGH>;
+ device-wakeup-gpios = <&gpg3 4 GPIO_ACTIVE_HIGH>;
+ host-wakeup-gpios = <&gph2 5 GPIO_ACTIVE_HIGH>;
+ };
};
&uart1 {
--
2.17.1
Since we have separate compatible for our SOC,
let's use it rather using one from exynos4210.
Signed-off-by: Paweł Chmiel <[email protected]>
---
arch/arm/boot/dts/s5pv210.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
index 75f454a210d6..3d6e5ad1ea35 100644
--- a/arch/arm/boot/dts/s5pv210.dtsi
+++ b/arch/arm/boot/dts/s5pv210.dtsi
@@ -511,7 +511,7 @@
};
fimd: fimd@f8000000 {
- compatible = "samsung,exynos4210-fimd";
+ compatible = "samsung,s5pv210-fimd";
interrupt-parent = <&vic2>;
reg = <0xf8000000 0x20000>;
interrupt-names = "fifo", "vsync", "lcd_sys";
--
2.17.1
This commit enables following drivers:
- i2c support (using s3c2410 driver)
- s5p-jpeg
- s5p-mfc
- exynos drm rotator
- pwm support
- pwm vibrator
- fixed regulator
- syscon poweroff
- Atmel maXTouch touchscreen
- Broadcom BCM4329 bluetooth over uart0
- dma devices (so we can use pl330 dma driver)
Disable DEBUG_LL. It's currently set to uart1, but if we want to use
it on Aries, we would need to switch uart2, to get any logs.
Signed-off-by: Paweł Chmiel <[email protected]>
Signed-off-by: Jonathan Bakker <[email protected]>
---
arch/arm/configs/s5pv210_defconfig | 41 ++++++++++++++++++++++--------
1 file changed, 30 insertions(+), 11 deletions(-)
diff --git a/arch/arm/configs/s5pv210_defconfig b/arch/arm/configs/s5pv210_defconfig
index a077597369f1..951196bdf008 100644
--- a/arch/arm/configs/s5pv210_defconfig
+++ b/arch/arm/configs/s5pv210_defconfig
@@ -1,24 +1,24 @@
CONFIG_SYSVIPC=y
CONFIG_NO_HZ=y
CONFIG_HIGH_RES_TIMERS=y
+CONFIG_PREEMPT=y
CONFIG_CGROUPS=y
CONFIG_SYSFS_DEPRECATED=y
CONFIG_SYSFS_DEPRECATED_V2=y
CONFIG_BLK_DEV_INITRD=y
CONFIG_KALLSYMS_ALL=y
-CONFIG_MODULES=y
-CONFIG_MODULE_UNLOAD=y
-# CONFIG_BLK_DEV_BSG is not set
-CONFIG_PARTITION_ADVANCED=y
-CONFIG_BSD_DISKLABEL=y
-CONFIG_SOLARIS_X86_PARTITION=y
CONFIG_ARCH_S5PV210=y
CONFIG_VMSPLIT_2G=y
-CONFIG_PREEMPT=y
CONFIG_ARM_APPENDED_DTB=y
CONFIG_CMDLINE="root=/dev/ram0 rw ramdisk=8192 initrd=0x20800000,8M console=ttySAC1,115200 init=/linuxrc"
CONFIG_VFP=y
CONFIG_NEON=y
+CONFIG_MODULES=y
+CONFIG_MODULE_UNLOAD=y
+# CONFIG_BLK_DEV_BSG is not set
+CONFIG_PARTITION_ADVANCED=y
+CONFIG_BSD_DISKLABEL=y
+CONFIG_SOLARIS_X86_PARTITION=y
CONFIG_NET=y
CONFIG_PACKET=y
CONFIG_UNIX=y
@@ -27,6 +27,11 @@ CONFIG_IP_PNP=y
CONFIG_IP_PNP_DHCP=y
CONFIG_IP_PNP_BOOTP=y
CONFIG_IP_PNP_RARP=y
+CONFIG_BT=m
+CONFIG_BT_RFCOMM=y
+CONFIG_BT_BNEP=y
+CONFIG_BT_HCIUART=m
+CONFIG_BT_HCIUART_BCM=y
CONFIG_CFG80211=m
CONFIG_MAC80211=m
CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
@@ -44,21 +49,35 @@ CONFIG_INPUT_EVDEV=y
CONFIG_KEYBOARD_GPIO=y
# CONFIG_INPUT_MOUSE is not set
CONFIG_INPUT_TOUCHSCREEN=y
+CONFIG_TOUCHSCREEN_ATMEL_MXT=m
+CONFIG_INPUT_MISC=y
+CONFIG_INPUT_PWM_VIBRA=m
CONFIG_SERIAL_8250=y
CONFIG_SERIAL_SAMSUNG=y
CONFIG_SERIAL_SAMSUNG_CONSOLE=y
+CONFIG_SERIAL_DEV_BUS=y
CONFIG_HW_RANDOM=y
CONFIG_I2C_GPIO=y
+CONFIG_I2C_S3C2410=y
+CONFIG_POWER_RESET=y
+CONFIG_POWER_RESET_SYSCON_POWEROFF=y
CONFIG_POWER_SUPPLY=y
CONFIG_BATTERY_MAX17040=y
# CONFIG_HWMON is not set
CONFIG_MFD_MAX8998=y
CONFIG_REGULATOR=y
+CONFIG_REGULATOR_FIXED_VOLTAGE=y
CONFIG_REGULATOR_MAX8998=y
+CONFIG_MEDIA_SUPPORT=m
+CONFIG_MEDIA_CAMERA_SUPPORT=y
+CONFIG_V4L_MEM2MEM_DRIVERS=y
+CONFIG_VIDEO_SAMSUNG_S5P_JPEG=m
+CONFIG_VIDEO_SAMSUNG_S5P_MFC=m
CONFIG_DRM=y
CONFIG_DRM_EXYNOS=y
CONFIG_DRM_EXYNOS_FIMD=y
CONFIG_DRM_EXYNOS_DPI=y
+CONFIG_DRM_EXYNOS_ROTATOR=y
CONFIG_USB=y
CONFIG_USB_OTG=y
CONFIG_USB_EHCI_HCD=y
@@ -72,6 +91,9 @@ CONFIG_MMC_SDHCI_S3C=y
CONFIG_MMC_SDHCI_S3C_DMA=y
CONFIG_RTC_CLASS=y
CONFIG_RTC_DRV_MAX8998=m
+CONFIG_DMADEVICES=y
+CONFIG_PWM=y
+CONFIG_PWM_SAMSUNG=y
CONFIG_PHY_SAMSUNG_USB2=m
CONFIG_PHY_S5PV210_USB2=y
CONFIG_EXT2_FS=y
@@ -87,6 +109,7 @@ CONFIG_NLS_CODEPAGE_437=y
CONFIG_NLS_ASCII=y
CONFIG_NLS_ISO8859_1=y
CONFIG_NLS_UTF8=y
+CONFIG_CRC_CCITT=y
CONFIG_DEBUG_INFO=y
CONFIG_MAGIC_SYSRQ=y
CONFIG_DEBUG_KERNEL=y
@@ -96,7 +119,3 @@ CONFIG_DEBUG_SPINLOCK=y
CONFIG_DEBUG_MUTEXES=y
CONFIG_DEBUG_ATOMIC_SLEEP=y
CONFIG_DEBUG_USER=y
-CONFIG_DEBUG_LL=y
-CONFIG_DEBUG_S3C_UART1=y
-CONFIG_EARLY_PRINTK=y
-CONFIG_CRC_CCITT=y
--
2.17.1
Since we have uboot (flashed in place of stock kernel),
it's not needed anymore to hardcode bootargs.
Signed-off-by: Paweł Chmiel <[email protected]>
---
arch/arm/boot/dts/s5pv210-galaxys.dts | 7 -------
1 file changed, 7 deletions(-)
diff --git a/arch/arm/boot/dts/s5pv210-galaxys.dts b/arch/arm/boot/dts/s5pv210-galaxys.dts
index 842276749717..cf161bbfbacf 100644
--- a/arch/arm/boot/dts/s5pv210-galaxys.dts
+++ b/arch/arm/boot/dts/s5pv210-galaxys.dts
@@ -11,13 +11,6 @@
chosen {
stdout-path = &uart2;
- /*
- * It's hard to change those parameters in stock bootloader,
- * since it requires special hardware/cable.
- * Let's hardocde bootargs for now, till u-boot port is finished,
- * with which it should be easier.
- */
- bootargs = "root=/dev/mmcblk2p1 rw rootwait ignore_loglevel earlyprintk";
};
nand_pwrseq: nand-pwrseq {
--
2.17.1
Since we have uboot (flashed in place of stock kernel),
it's not needed anymore to hardcode bootargs.
Signed-off-by: Paweł Chmiel <[email protected]>
---
arch/arm/boot/dts/s5pv210-fascinate4g.dts | 7 -------
1 file changed, 7 deletions(-)
diff --git a/arch/arm/boot/dts/s5pv210-fascinate4g.dts b/arch/arm/boot/dts/s5pv210-fascinate4g.dts
index ccf761b1babf..07a8d9bbe5b8 100644
--- a/arch/arm/boot/dts/s5pv210-fascinate4g.dts
+++ b/arch/arm/boot/dts/s5pv210-fascinate4g.dts
@@ -11,13 +11,6 @@
chosen {
stdout-path = &uart2;
- /*
- * It's hard to change those parameters in stock bootloader,
- * since it requires special hardware/cable.
- * Let's hardocde bootargs for now, till u-boot port is finished,
- * with which it should be easier.
- */
- bootargs = "root=/dev/mmcblk1p1 rw rootwait ignore_loglevel earlyprintk";
};
gpio-keys {
--
2.17.1
This commit adds memory reservation required by MFC to run.
On S5PV210 both regions needs to be on separate memory banks.
Size of both regions is taken from stock sources.
Signed-off-by: Paweł Chmiel <[email protected]>
---
arch/arm/boot/dts/s5pv210-aries.dtsi | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
index 575094ea7024..35ba009a1a33 100644
--- a/arch/arm/boot/dts/s5pv210-aries.dtsi
+++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
@@ -23,6 +23,24 @@
0x50000000 0x08000000>;
};
+ reserved-memory {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ mfc_left: region_mfc_left@43000000 {
+ compatible = "shared-dma-pool";
+ no-map;
+ reg = <0x43000000 0x2000000>;
+ };
+
+ mfc_right: region_mfc_right@51000000 {
+ compatible = "shared-dma-pool";
+ no-map;
+ reg = <0x51000000 0x2000000>;
+ };
+ };
+
wifi_pwrseq: wifi-pwrseq {
compatible = "mmc-pwrseq-simple";
reset-gpios = <&gpg1 2 GPIO_ACTIVE_LOW>;
@@ -329,6 +347,10 @@
status = "okay";
};
+&mfc {
+ memory-region = <&mfc_left>, <&mfc_right>;
+};
+
&pinctrl0 {
wlan_bt_en: wlan-bt-en {
samsung,pins = "gpb-5";
--
2.17.1
On Fri, 28 Dec 2018 at 17:18, Paweł Chmiel
<[email protected]> wrote:
>
> Since we have separate compatible for our SOC,
> let's use it rather using one from exynos4210.
Please fix
your editor
to wrap lines
matching Linux
style because
it is difficult
to read.
You have unusual configuration because most of the editors wrap git
commit as expected.
https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L633
Best regards,
Krzysztof
>
> Signed-off-by: Paweł Chmiel <[email protected]>
> ---
> arch/arm/boot/dts/s5pv210.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
> index 75f454a210d6..3d6e5ad1ea35 100644
> --- a/arch/arm/boot/dts/s5pv210.dtsi
> +++ b/arch/arm/boot/dts/s5pv210.dtsi
> @@ -511,7 +511,7 @@
> };
>
> fimd: fimd@f8000000 {
> - compatible = "samsung,exynos4210-fimd";
> + compatible = "samsung,s5pv210-fimd";
> interrupt-parent = <&vic2>;
> reg = <0xf8000000 0x20000>;
> interrupt-names = "fifo", "vsync", "lcd_sys";
> --
> 2.17.1
>
On Fri, 28 Dec 2018 at 17:18, Paweł Chmiel
<[email protected]> wrote:
>
> This commit adds memory reservation required by MFC to run.
> On S5PV210 both regions needs to be on separate memory banks.
> Size of both regions is taken from stock sources.
>
> Signed-off-by: Paweł Chmiel <[email protected]>
> ---
> arch/arm/boot/dts/s5pv210-aries.dtsi | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
> index 575094ea7024..35ba009a1a33 100644
> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi
> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
> @@ -23,6 +23,24 @@
> 0x50000000 0x08000000>;
> };
>
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + mfc_left: region_mfc_left@43000000 {
Although you used the same naming convention as existing
exynos-mfc-reserved-memory.dtsi, the name of nodes should be generic,
so:
mfc_left: region@43000000
Best regards,
Krzysztof
> + compatible = "shared-dma-pool";
> + no-map;
> + reg = <0x43000000 0x2000000>;
> + };
> +
> + mfc_right: region_mfc_right@51000000 {
> + compatible = "shared-dma-pool";
> + no-map;
> + reg = <0x51000000 0x2000000>;
> + };
> + };
> +
> wifi_pwrseq: wifi-pwrseq {
> compatible = "mmc-pwrseq-simple";
> reset-gpios = <&gpg1 2 GPIO_ACTIVE_LOW>;
> @@ -329,6 +347,10 @@
> status = "okay";
> };
>
> +&mfc {
> + memory-region = <&mfc_left>, <&mfc_right>;
> +};
> +
> &pinctrl0 {
> wlan_bt_en: wlan-bt-en {
> samsung,pins = "gpb-5";
> --
> 2.17.1
>
On Fri, 28 Dec 2018 at 17:18, Paweł Chmiel
<[email protected]> wrote:
>
> This commit enables following drivers:
> - i2c support (using s3c2410 driver)
> - s5p-jpeg
> - s5p-mfc
> - exynos drm rotator
> - pwm support
> - pwm vibrator
> - fixed regulator
> - syscon poweroff
> - Atmel maXTouch touchscreen
> - Broadcom BCM4329 bluetooth over uart0
> - dma devices (so we can use pl330 dma driver)
>
> Disable DEBUG_LL. It's currently set to uart1, but if we want to use
> it on Aries, we would need to switch uart2, to get any logs.
>
> Signed-off-by: Paweł Chmiel <[email protected]>
> Signed-off-by: Jonathan Bakker <[email protected]>
> ---
> arch/arm/configs/s5pv210_defconfig | 41 ++++++++++++++++++++++--------
> 1 file changed, 30 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm/configs/s5pv210_defconfig b/arch/arm/configs/s5pv210_defconfig
> index a077597369f1..951196bdf008 100644
> --- a/arch/arm/configs/s5pv210_defconfig
> +++ b/arch/arm/configs/s5pv210_defconfig
> @@ -1,24 +1,24 @@
> CONFIG_SYSVIPC=y
> CONFIG_NO_HZ=y
> CONFIG_HIGH_RES_TIMERS=y
> +CONFIG_PREEMPT=y
This and few other look like effect of savedefconfig. Please split
such change to separate commit, before adding new features.
Best regards,
Krzysztof
> CONFIG_CGROUPS=y
> CONFIG_SYSFS_DEPRECATED=y
> CONFIG_SYSFS_DEPRECATED_V2=y
> CONFIG_BLK_DEV_INITRD=y
> CONFIG_KALLSYMS_ALL=y
> -CONFIG_MODULES=y
> -CONFIG_MODULE_UNLOAD=y
> -# CONFIG_BLK_DEV_BSG is not set
> -CONFIG_PARTITION_ADVANCED=y
> -CONFIG_BSD_DISKLABEL=y
> -CONFIG_SOLARIS_X86_PARTITION=y
> CONFIG_ARCH_S5PV210=y
> CONFIG_VMSPLIT_2G=y
> -CONFIG_PREEMPT=y
> CONFIG_ARM_APPENDED_DTB=y
> CONFIG_CMDLINE="root=/dev/ram0 rw ramdisk=8192 initrd=0x20800000,8M console=ttySAC1,115200 init=/linuxrc"
> CONFIG_VFP=y
> CONFIG_NEON=y
> +CONFIG_MODULES=y
> +CONFIG_MODULE_UNLOAD=y
> +# CONFIG_BLK_DEV_BSG is not set
> +CONFIG_PARTITION_ADVANCED=y
> +CONFIG_BSD_DISKLABEL=y
> +CONFIG_SOLARIS_X86_PARTITION=y
> CONFIG_NET=y
> CONFIG_PACKET=y
> CONFIG_UNIX=y
> @@ -27,6 +27,11 @@ CONFIG_IP_PNP=y
> CONFIG_IP_PNP_DHCP=y
> CONFIG_IP_PNP_BOOTP=y
> CONFIG_IP_PNP_RARP=y
> +CONFIG_BT=m
> +CONFIG_BT_RFCOMM=y
> +CONFIG_BT_BNEP=y
> +CONFIG_BT_HCIUART=m
> +CONFIG_BT_HCIUART_BCM=y
> CONFIG_CFG80211=m
> CONFIG_MAC80211=m
> CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
> @@ -44,21 +49,35 @@ CONFIG_INPUT_EVDEV=y
> CONFIG_KEYBOARD_GPIO=y
> # CONFIG_INPUT_MOUSE is not set
> CONFIG_INPUT_TOUCHSCREEN=y
> +CONFIG_TOUCHSCREEN_ATMEL_MXT=m
> +CONFIG_INPUT_MISC=y
> +CONFIG_INPUT_PWM_VIBRA=m
> CONFIG_SERIAL_8250=y
> CONFIG_SERIAL_SAMSUNG=y
> CONFIG_SERIAL_SAMSUNG_CONSOLE=y
> +CONFIG_SERIAL_DEV_BUS=y
> CONFIG_HW_RANDOM=y
> CONFIG_I2C_GPIO=y
> +CONFIG_I2C_S3C2410=y
> +CONFIG_POWER_RESET=y
> +CONFIG_POWER_RESET_SYSCON_POWEROFF=y
> CONFIG_POWER_SUPPLY=y
> CONFIG_BATTERY_MAX17040=y
> # CONFIG_HWMON is not set
> CONFIG_MFD_MAX8998=y
> CONFIG_REGULATOR=y
> +CONFIG_REGULATOR_FIXED_VOLTAGE=y
> CONFIG_REGULATOR_MAX8998=y
> +CONFIG_MEDIA_SUPPORT=m
> +CONFIG_MEDIA_CAMERA_SUPPORT=y
> +CONFIG_V4L_MEM2MEM_DRIVERS=y
> +CONFIG_VIDEO_SAMSUNG_S5P_JPEG=m
> +CONFIG_VIDEO_SAMSUNG_S5P_MFC=m
> CONFIG_DRM=y
> CONFIG_DRM_EXYNOS=y
> CONFIG_DRM_EXYNOS_FIMD=y
> CONFIG_DRM_EXYNOS_DPI=y
> +CONFIG_DRM_EXYNOS_ROTATOR=y
> CONFIG_USB=y
> CONFIG_USB_OTG=y
> CONFIG_USB_EHCI_HCD=y
> @@ -72,6 +91,9 @@ CONFIG_MMC_SDHCI_S3C=y
> CONFIG_MMC_SDHCI_S3C_DMA=y
> CONFIG_RTC_CLASS=y
> CONFIG_RTC_DRV_MAX8998=m
> +CONFIG_DMADEVICES=y
> +CONFIG_PWM=y
> +CONFIG_PWM_SAMSUNG=y
> CONFIG_PHY_SAMSUNG_USB2=m
> CONFIG_PHY_S5PV210_USB2=y
> CONFIG_EXT2_FS=y
> @@ -87,6 +109,7 @@ CONFIG_NLS_CODEPAGE_437=y
> CONFIG_NLS_ASCII=y
> CONFIG_NLS_ISO8859_1=y
> CONFIG_NLS_UTF8=y
> +CONFIG_CRC_CCITT=y
> CONFIG_DEBUG_INFO=y
> CONFIG_MAGIC_SYSRQ=y
> CONFIG_DEBUG_KERNEL=y
> @@ -96,7 +119,3 @@ CONFIG_DEBUG_SPINLOCK=y
> CONFIG_DEBUG_MUTEXES=y
> CONFIG_DEBUG_ATOMIC_SLEEP=y
> CONFIG_DEBUG_USER=y
> -CONFIG_DEBUG_LL=y
> -CONFIG_DEBUG_S3C_UART1=y
> -CONFIG_EARLY_PRINTK=y
> -CONFIG_CRC_CCITT=y
> --
> 2.17.1
>
On Fri, 28 Dec 2018 at 17:18, Paweł Chmiel
<[email protected]> wrote:
>
> From: Jonathan Bakker <[email protected]>
>
> This commit enables following devices present on Aries based phones:
> - pwm-vibrator attached to PWM 1
> - poweroff support
> - Atmel maXTouch touchscreen. It's connected to i2c2
> - Broadcom BCM4329 bluetooth over uart0
>
> Signed-off-by: Jonathan Bakker <[email protected]>
> Signed-off-by: Paweł Chmiel <[email protected]>
> ---
> arch/arm/boot/dts/s5pv210-aries.dtsi | 68 ++++++++++++++++++++++++++++
> 1 file changed, 68 insertions(+)
>
> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
> index 35ba009a1a33..b7246f879648 100644
> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi
> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
> @@ -41,6 +41,13 @@
> };
> };
>
> + vibrator_pwr: regulator-fixed-0 {
> + compatible = "regulator-fixed";
> + regulator-name = "vibrator-en";
> + enable-active-high;
> + gpio = <&gpj1 1 GPIO_ACTIVE_HIGH>;
> + };
> +
> wifi_pwrseq: wifi-pwrseq {
> compatible = "mmc-pwrseq-simple";
> reset-gpios = <&gpg1 2 GPIO_ACTIVE_LOW>;
> @@ -314,6 +321,22 @@
> reg = <0x36>;
> };
> };
> +
> + vibrator: pwm-vibrator {
> + compatible = "pwm-vibrator";
> + pwms = <&pwm 1 44642 0>;
> + pwm-names = "enable";
> + vcc-supply = <&vibrator_pwr>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pwm1_out>;
> + };
> +
> + poweroff: syscon-poweroff {
> + compatible = "syscon-poweroff";
> + regmap = <&pmu_syscon>;
> + offset = <0x681c>; /* PS_HOLD_CONTROL */
> + value = <0x5200>;
> + };
> };
>
> &fimd {
> @@ -347,6 +370,23 @@
> status = "okay";
> };
>
> +&i2c2 {
> + samsung,i2c-sda-delay = <100>;
> + samsung,i2c-max-bus-freq = <400000>;
> + samsung,i2c-slave-addr = <0x10>;
> + status = "okay";
> +
> + touchscreen@4a {
> + compatible = "atmel,maxtouch";
> + reg = <0x4a>;
> + interrupt-parent = <&gpj0>;
> + interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&ts_irq>;
> + reset-gpios = <&gpj1 3 GPIO_ACTIVE_HIGH>;
> + };
> +};
> +
> &mfc {
> memory-region = <&mfc_left>, <&mfc_right>;
> };
> @@ -372,6 +412,13 @@
> samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> };
>
> + bt_host_wake: bt-host-wake {
> + samsung,pins = "gph2-5";
> + samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
> + samsung,pin-pud = <S3C64XX_PIN_PULL_DOWN>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> tf_detect: tf-detect {
> samsung,pins = "gph3-4";
> samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
> @@ -384,6 +431,17 @@
> samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> };
> +
> + ts_irq: ts-irq {
> + samsung,pins = "gpj0-5";
> + samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
> + samsung,pin-pud = <S3C64XX_PIN_PULL_UP>;
It seems there is a difference here between Aries and Fascinate. At
least in vendor kernel. One disables pull and second pulls down.
Anyway neither of them pulls it up.
Best regards,
Krzysztof
On Fri, Dec 28, 2018 at 05:18:15PM +0100, Paweł Chmiel wrote:
> Since we have uboot (flashed in place of stock kernel),
> it's not needed anymore to hardcode bootargs.
>
> Signed-off-by: Paweł Chmiel <[email protected]>
> ---
> arch/arm/boot/dts/s5pv210-galaxys.dts | 7 -------
Thanks, applied.
Best regards,
Krzysztof
On Fri, Dec 28, 2018 at 05:18:16PM +0100, Paweł Chmiel wrote:
> Since we have uboot (flashed in place of stock kernel),
> it's not needed anymore to hardcode bootargs.
>
> Signed-off-by: Paweł Chmiel <[email protected]>
> ---
> arch/arm/boot/dts/s5pv210-fascinate4g.dts | 7 -------
Thanks, applied (squashed with previous one).
Best regards,
Krzysztof
On Fri, Dec 28, 2018 at 05:18:14PM +0100, Paweł Chmiel wrote:
> Since we have separate compatible for our SOC,
> let's use it rather using one from exynos4210.
>
> Signed-off-by: Paweł Chmiel <[email protected]>
> ---
> arch/arm/boot/dts/s5pv210.dtsi | 2 +-
Thanks, applied.
Best regards,
Krzysztof
Dnia poniedziałek, 31 grudnia 2018 14:35:55 CET Krzysztof Kozlowski pisze:
> On Fri, 28 Dec 2018 at 17:18, Paweł Chmiel
> <[email protected]> wrote:
> >
> > From: Jonathan Bakker <[email protected]>
> >
> > This commit enables following devices present on Aries based phones:
> > - pwm-vibrator attached to PWM 1
> > - poweroff support
> > - Atmel maXTouch touchscreen. It's connected to i2c2
> > - Broadcom BCM4329 bluetooth over uart0
> >
> > Signed-off-by: Jonathan Bakker <[email protected]>
> > Signed-off-by: Paweł Chmiel <[email protected]>
> > ---
> > arch/arm/boot/dts/s5pv210-aries.dtsi | 68 ++++++++++++++++++++++++++++
> > 1 file changed, 68 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
> > index 35ba009a1a33..b7246f879648 100644
> > --- a/arch/arm/boot/dts/s5pv210-aries.dtsi
> > +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
> > @@ -41,6 +41,13 @@
> > };
> > };
> >
> > + vibrator_pwr: regulator-fixed-0 {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vibrator-en";
> > + enable-active-high;
> > + gpio = <&gpj1 1 GPIO_ACTIVE_HIGH>;
> > + };
> > +
> > wifi_pwrseq: wifi-pwrseq {
> > compatible = "mmc-pwrseq-simple";
> > reset-gpios = <&gpg1 2 GPIO_ACTIVE_LOW>;
> > @@ -314,6 +321,22 @@
> > reg = <0x36>;
> > };
> > };
> > +
> > + vibrator: pwm-vibrator {
> > + compatible = "pwm-vibrator";
> > + pwms = <&pwm 1 44642 0>;
> > + pwm-names = "enable";
> > + vcc-supply = <&vibrator_pwr>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pwm1_out>;
> > + };
> > +
> > + poweroff: syscon-poweroff {
> > + compatible = "syscon-poweroff";
> > + regmap = <&pmu_syscon>;
> > + offset = <0x681c>; /* PS_HOLD_CONTROL */
> > + value = <0x5200>;
> > + };
> > };
> >
> > &fimd {
> > @@ -347,6 +370,23 @@
> > status = "okay";
> > };
> >
> > +&i2c2 {
> > + samsung,i2c-sda-delay = <100>;
> > + samsung,i2c-max-bus-freq = <400000>;
> > + samsung,i2c-slave-addr = <0x10>;
> > + status = "okay";
> > +
> > + touchscreen@4a {
> > + compatible = "atmel,maxtouch";
> > + reg = <0x4a>;
> > + interrupt-parent = <&gpj0>;
> > + interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&ts_irq>;
> > + reset-gpios = <&gpj1 3 GPIO_ACTIVE_HIGH>;
> > + };
> > +};
> > +
> > &mfc {
> > memory-region = <&mfc_left>, <&mfc_right>;
> > };
> > @@ -372,6 +412,13 @@
> > samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> > };
> >
> > + bt_host_wake: bt-host-wake {
> > + samsung,pins = "gph2-5";
> > + samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
> > + samsung,pin-pud = <S3C64XX_PIN_PULL_DOWN>;
> > + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> > + };
> > +
> > tf_detect: tf-detect {
> > samsung,pins = "gph3-4";
> > samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
> > @@ -384,6 +431,17 @@
> > samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> > samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> > };
> > +
> > + ts_irq: ts-irq {
> > + samsung,pins = "gpj0-5";
> > + samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
> > + samsung,pin-pud = <S3C64XX_PIN_PULL_UP>;
>
> It seems there is a difference here between Aries and Fascinate. At
> least in vendor kernel. One disables pull and second pulls down.
> Anyway neither of them pulls it up.
Fixed with all other issues in v2.
Thanks
>
> Best regards,
> Krzysztof