2009-10-16 22:18:59

by Hartley Sweeten

Subject: [PATCH] clockevents.c: fix symbol was not declared noise

Include "tick-internal.h" in order to pick up the extern function
prototype for clockevents_shutdown(). This quiets the following
spares build noise:

warning: symbol 'clockevents_shutdown' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <[email protected]>

---

diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
index 620b58a..c30ba1f 100644
--- a/kernel/time/clockevents.c
+++ b/kernel/time/clockevents.c
@@ -20,6 +20,8 @@
#include <linux/sysdev.h>
#include <linux/tick.h>

+#include "tick-internal.h"
+
/* The registered clock event devices */
static LIST_HEAD(clockevent_devices);
static LIST_HEAD(clockevents_released);

2009-10-18 06:32:05

by Yong Zhang

Subject: Re: [PATCH] clockevents.c: fix symbol was not declared noise

On Sat, Oct 17, 2009 at 6:19 AM, H Hartley Sweeten
<[email protected]> wrote:
> Include "tick-internal.h" in order to pick up the extern function
> prototype for clockevents_shutdown().  This quiets the following
> spares build noise:
>
>  warning: symbol 'clockevents_shutdown' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
>

Looks good.
Reviewed-by: Yong Zhang <[email protected]>

Cc'ed some experts.

> ---
>
> diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
> index 620b58a..c30ba1f 100644
> --- a/kernel/time/clockevents.c
> +++ b/kernel/time/clockevents.c
> @@ -20,6 +20,8 @@
>  #include <linux/sysdev.h>
>  #include <linux/tick.h>
>
> +#include "tick-internal.h"
> +
>  /* The registered clock event devices */
>  static LIST_HEAD(clockevent_devices);
>  static LIST_HEAD(clockevents_released);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

2009-11-18 11:37:13

by Hartley Sweeten

Subject: [tip:timers/core] clockevents: Add missing include to pacify sparse

Commit-ID: 8e1a928a2ed7e8d5cad97c8e985294b4caedd168
Gitweb: http://git.kernel.org/tip/8e1a928a2ed7e8d5cad97c8e985294b4caedd168
Author: H Hartley Sweeten <[email protected]>
AuthorDate: Fri, 16 Oct 2009 18:19:01 -0400
Committer: Thomas Gleixner <[email protected]>
CommitDate: Wed, 18 Nov 2009 12:31:48 +0100

clockevents: Add missing include to pacify sparse

Include "tick-internal.h" in order to pick up the extern function
prototype for clockevents_shutdown(). This quiets the following sparse
build noise:

warning: symbol 'clockevents_shutdown' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <[email protected]>
LKML-Reference: <[email protected]>
Reviewed-by: Yong Zhang <[email protected]>
Cc: [email protected]
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
---
kernel/time/clockevents.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
index 05e8aee..20a8920 100644
--- a/kernel/time/clockevents.c
+++ b/kernel/time/clockevents.c
@@ -20,6 +20,8 @@
#include <linux/sysdev.h>
#include <linux/tick.h>

+#include "tick-internal.h"
+
/* The registered clock event devices */
static LIST_HEAD(clockevent_devices);
static LIST_HEAD(clockevents_released);