2014-01-02 07:57:31

by Baruch Siach

Subject: [PATCH v2] perf: add support for the xtensa architecture

Signed-off-by: Baruch Siach <[email protected]>
---
v2: use the "core ID" field from /proc/cpuinfo (Max Filippov)
---
tools/perf/perf.h | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/tools/perf/perf.h b/tools/perf/perf.h
index b079304bd53d..e441864dbe03 100644
--- a/tools/perf/perf.h
+++ b/tools/perf/perf.h
@@ -132,6 +132,13 @@
#define CPUINFO_PROC "CPU"
#endif

+#ifdef __xtensa__
+#define mb() asm volatile("memw" ::: "memory")
+#define wmb() asm volatile("memw" ::: "memory")
+#define rmb() asm volatile("" ::: "memory")
+#define CPUINFO_PROC "core ID"
+#endif
+
#define barrier() asm volatile ("" ::: "memory")

#ifndef cpu_relax
--
1.8.5.2

2014-01-02 08:11:05

by Max Filippov

Subject: Re: [Linux-Xtensa] [PATCH v2] perf: add support for the xtensa architecture

On Thu, Jan 2, 2014 at 11:57 AM, Baruch Siach <[email protected]> wrote:
> Signed-off-by: Baruch Siach <[email protected]>
> ---
> v2: use the "core ID" field from /proc/cpuinfo (Max Filippov)
> ---
> tools/perf/perf.h | 7 +++++++
> 1 file changed, 7 insertions(+)

Acked-by: Max Filippov <[email protected]>

> diff --git a/tools/perf/perf.h b/tools/perf/perf.h
> index b079304bd53d..e441864dbe03 100644
> --- a/tools/perf/perf.h
> +++ b/tools/perf/perf.h
> @@ -132,6 +132,13 @@
> #define CPUINFO_PROC "CPU"
> #endif
>
> +#ifdef __xtensa__
> +#define mb() asm volatile("memw" ::: "memory")
> +#define wmb() asm volatile("memw" ::: "memory")
> +#define rmb() asm volatile("" ::: "memory")
> +#define CPUINFO_PROC "core ID"
> +#endif
> +
> #define barrier() asm volatile ("" ::: "memory")
>
> #ifndef cpu_relax
> --
> 1.8.5.2

--
Thanks.
-- Max

2014-01-13 07:55:25

by Baruch Siach

Subject: Re: [Linux-Xtensa] [PATCH v2] perf: add support for the xtensa architecture

Hi perf maintainers,

Ping?

Anyone taking this for v3.14?

baruch

On Thu, Jan 02, 2014 at 09:57:10AM +0200, Baruch Siach wrote:
> Signed-off-by: Baruch Siach <[email protected]>
> ---
> v2: use the "core ID" field from /proc/cpuinfo (Max Filippov)
> ---
> tools/perf/perf.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tools/perf/perf.h b/tools/perf/perf.h
> index b079304bd53d..e441864dbe03 100644
> --- a/tools/perf/perf.h
> +++ b/tools/perf/perf.h
> @@ -132,6 +132,13 @@
> #define CPUINFO_PROC "CPU"
> #endif
>
> +#ifdef __xtensa__
> +#define mb() asm volatile("memw" ::: "memory")
> +#define wmb() asm volatile("memw" ::: "memory")
> +#define rmb() asm volatile("" ::: "memory")
> +#define CPUINFO_PROC "core ID"
> +#endif
> +
> #define barrier() asm volatile ("" ::: "memory")
>
> #ifndef cpu_relax

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- [email protected] - tel: +972.2.679.5364, http://www.tkos.co.il -

2014-01-13 10:02:30

by Ingo Molnar

Subject: Re: [Linux-Xtensa] [PATCH v2] perf: add support for the xtensa architecture

* Baruch Siach <[email protected]> wrote:

> Hi perf maintainers,
>
> Ping?
>
> Anyone taking this for v3.14?

Would be nice to have some indication in the commit log about how it
was tested, how well it works, what the limitations are, etc.

Just a naked 'enable support' commit tells us very little.

Thanks,

Ingo