2023-07-25 18:31:29

by Rafael J. Wysocki

[permalink] [raw]
Subject: [PATCH v1] ACPI: thermal: Drop enabled flag from struct acpi_thermal_active

From: Rafael J. Wysocki <[email protected]>

The enabled field of struct acpi_thermal_active is only updated and never
read, so drop it along with the related code.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <[email protected]>
---
drivers/acpi/thermal.c | 6 ------
1 file changed, 6 deletions(-)

Index: linux-pm/drivers/acpi/thermal.c
===================================================================
--- linux-pm.orig/drivers/acpi/thermal.c
+++ linux-pm/drivers/acpi/thermal.c
@@ -121,7 +121,6 @@ struct acpi_thermal_active {
struct acpi_handle_list devices;
unsigned long temperature;
bool valid;
- bool enabled;
};

struct acpi_thermal_trips {
@@ -1084,15 +1083,10 @@ static int acpi_thermal_resume(struct de
if (!tz->trips.active[i].valid)
break;

- tz->trips.active[i].enabled = true;
for (j = 0; j < tz->trips.active[i].devices.count; j++) {
result = acpi_bus_update_power(
tz->trips.active[i].devices.handles[j],
&power_state);
- if (result || (power_state != ACPI_STATE_D0)) {
- tz->trips.active[i].enabled = false;
- break;
- }
}
}