LinuxLists.cc - [PATCH 2/2] Staging: mimio: Fix Coding style errors in mimio.c

2010-02-21 15:27:30

Subject: [PATCH 2/2] Staging: mimio: Fix Coding style errors in mimio.c

This is a patch to the mimio.c that fixes a couple of
space errors picked up by checkpatch.pl

Signed-off-by: Chris Nicholson <[email protected]>
---
drivers/staging/mimio/mimio.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/mimio/mimio.c b/drivers/staging/mimio/mimio.c
index 1ba8103..4d7a602 100644
--- a/drivers/staging/mimio/mimio.c
+++ b/drivers/staging/mimio/mimio.c
@@ -145,7 +145,7 @@ static void mimio_rx_handler(struct mimio *, unsigned char *, unsigned int);
static int mimio_tx(struct mimio *, const char *, int);

static char mimio_name[] = "VirtualInk mimio-Xi";
-static struct usb_device_id mimio_table [] = {
+static struct usb_device_id mimio_table[] = {
{ USB_DEVICE(MIMIO_VENDOR_ID, MIMIO_PRODUCT_ID) },
{ USB_DEVICE(0x0525, 0xa4a0) }, /* gadget zero firmware */
{ }
@@ -588,7 +588,7 @@ static int handle_mimio_rx_penupdown(struct mimio *mimio,
*(mimio->pktbuf.p + 2);
if (x != *(mimio->pktbuf.p + 3)) {
dev_dbg(&mimio->idev->dev, "EV_PEN%s: bad xsum.\n",
- down ? "DOWN":"UP");
+ down ? "DOWN" : "UP");
/* skip this event data */
mimio->pktbuf.p += 4;
/* decode any remaining events */
--
1.6.6

2010-02-22 09:06:40

by Ameya Palande

[permalink] [raw]

Subject: Re: [PATCH 2/2] Staging: mimio: Fix Coding style errors in mimio.c

Hi Chris,

On Sun, Feb 21, 2010 at 5:27 PM, Chris Nicholson
<[email protected]> wrote:
> This is a patch to the mimio.c that fixes a couple of
> space errors picked up by checkpatch.pl
>
> Signed-off-by: Chris Nicholson <[email protected]>
> ---
> drivers/staging/mimio/mimio.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/mimio/mimio.c b/drivers/staging/mimio/mimio.c
> index 1ba8103..4d7a602 100644
> --- a/drivers/staging/mimio/mimio.c
> +++ b/drivers/staging/mimio/mimio.c
> @@ -145,7 +145,7 @@ static void mimio_rx_handler(struct mimio *, unsigned char *, unsigned int);
> static int mimio_tx(struct mimio *, const char *, int);
>
> static char mimio_name[] = "VirtualInk mimio-Xi";
> -static struct usb_device_id mimio_table [] = {
> +static struct usb_device_id mimio_table[] = {
> { USB_DEVICE(MIMIO_VENDOR_ID, MIMIO_PRODUCT_ID) },
> { USB_DEVICE(0x0525, 0xa4a0) }, /* gadget zero firmware */
> { }
> @@ -588,7 +588,7 @@ static int handle_mimio_rx_penupdown(struct mimio *mimio,
> *(mimio->pktbuf.p + 2);
> if (x != *(mimio->pktbuf.p + 3)) {
> dev_dbg(&mimio->idev->dev, "EV_PEN%s: bad xsum.\n",
> - down ? "DOWN":"UP");
> + down ? "DOWN" : "UP");
> /* skip this event data */
> mimio->pktbuf.p += 4;
> /* decode any remaining events */
> --
> 1.6.6

I sent the same patch in Dec 2009 :(
http://driverdev.linuxdriverproject.org/pipermail/devel/2009-December/003128.html

It seems that mimio driver is already removed from linux-next:

commit c5982142e80229a90cd1a73eedef886de9c8e271
Author: Greg Kroah-Hartman <[email protected]>
Date: Thu Feb 11 17:15:14 2010 -0800

Staging: mimio: remove the mimio driver

Cheers,
Ameya.

2010-02-23 14:20:17

by Greg KH

[permalink] [raw]

Subject: Re: [PATCH 2/2] Staging: mimio: Fix Coding style errors in mimio.c

On Mon, Feb 22, 2010 at 11:06:35AM +0200, Ameya Palande wrote:
> Hi Chris,
>
> On Sun, Feb 21, 2010 at 5:27 PM, Chris Nicholson
> <[email protected]> wrote:
> > This is a patch to the mimio.c that fixes a couple of
> > space errors picked up by checkpatch.pl
> >
> > Signed-off-by: Chris Nicholson <[email protected]>
> > ---
> > ?drivers/staging/mimio/mimio.c | ? ?4 ++--
> > ?1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/mimio/mimio.c b/drivers/staging/mimio/mimio.c
> > index 1ba8103..4d7a602 100644
> > --- a/drivers/staging/mimio/mimio.c
> > +++ b/drivers/staging/mimio/mimio.c
> > @@ -145,7 +145,7 @@ static void mimio_rx_handler(struct mimio *, unsigned char *, unsigned int);
> > ?static int mimio_tx(struct mimio *, const char *, int);
> >
> > ?static char mimio_name[] = "VirtualInk mimio-Xi";
> > -static struct usb_device_id mimio_table [] = {
> > +static struct usb_device_id mimio_table[] = {
> > ? ? ? ?{ USB_DEVICE(MIMIO_VENDOR_ID, MIMIO_PRODUCT_ID) },
> > ? ? ? ?{ USB_DEVICE(0x0525, 0xa4a0) }, /* gadget zero firmware */
> > ? ? ? ?{ }
> > @@ -588,7 +588,7 @@ static int handle_mimio_rx_penupdown(struct mimio *mimio,
> > ? ? ? ? ? ? ? ? ? ? ? ?*(mimio->pktbuf.p + 2);
> > ? ? ? ? ? ? ? ?if (x != *(mimio->pktbuf.p + 3)) {
> > ? ? ? ? ? ? ? ? ? ? ? ?dev_dbg(&mimio->idev->dev, "EV_PEN%s: bad xsum.\n",
> > - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? down ? "DOWN":"UP");
> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? down ? "DOWN" : "UP");
> > ? ? ? ? ? ? ? ? ? ? ? ?/* skip this event data */
> > ? ? ? ? ? ? ? ? ? ? ? ?mimio->pktbuf.p += 4;
> > ? ? ? ? ? ? ? ? ? ? ? ?/* decode any remaining events */
> > --
> > 1.6.6
>
> I sent the same patch in Dec 2009 :(
> http://driverdev.linuxdriverproject.org/pipermail/devel/2009-December/003128.html
>
> It seems that mimio driver is already removed from linux-next:
>
> commit c5982142e80229a90cd1a73eedef886de9c8e271
> Author: Greg Kroah-Hartman <[email protected]>
> Date: Thu Feb 11 17:15:14 2010 -0800
>
> Staging: mimio: remove the mimio driver

Yes, sorry, the mimo driver is now gone for the 2.6.34 release.

greg k-h