2021-10-19 09:05:11

by CGEL

Subject: [PATCH] remove duplicate include in mock_region.c

From: Ran Jianping <[email protected]>

'drm/ttm/ttm_placement.h' included in
'drivers/gpu/drm/i915/selftests/mock_region.c' is duplicated.
It is also included on the 9 line.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Ran Jianping <[email protected]>
---
drivers/gpu/drm/i915/selftests/mock_region.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/selftests/mock_region.c b/drivers/gpu/drm/i915/selftests/mock_region.c
index efa86dffe3c6..75793008c4ef 100644
--- a/drivers/gpu/drm/i915/selftests/mock_region.c
+++ b/drivers/gpu/drm/i915/selftests/mock_region.c
@@ -6,8 +6,6 @@
#include <drm/ttm/ttm_placement.h>
#include <linux/scatterlist.h>

-#include <drm/ttm/ttm_placement.h>
-
#include "gem/i915_gem_region.h"
#include "intel_memory_region.h"
#include "intel_region_ttm.h"
--
2.25.1

2021-10-19 09:29:13

by Matthew Auld

Subject: Re: [PATCH] remove duplicate include in mock_region.c

On 19/10/2021 10:02, [email protected] wrote:
> From: Ran Jianping <[email protected]>
>
> 'drm/ttm/ttm_placement.h' included in
> 'drivers/gpu/drm/i915/selftests/mock_region.c' is duplicated.
> It is also included on the 9 line.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Ran Jianping <[email protected]>

Commit tile should ideally be prefixed with 'drm/i915:'.

Can fix up when pushing though. Thanks,
Reviewed-by: Matthew Auld <[email protected]>

> ---
> drivers/gpu/drm/i915/selftests/mock_region.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/mock_region.c b/drivers/gpu/drm/i915/selftests/mock_region.c
> index efa86dffe3c6..75793008c4ef 100644
> --- a/drivers/gpu/drm/i915/selftests/mock_region.c
> +++ b/drivers/gpu/drm/i915/selftests/mock_region.c
> @@ -6,8 +6,6 @@
> #include <drm/ttm/ttm_placement.h>
> #include <linux/scatterlist.h>
>
> -#include <drm/ttm/ttm_placement.h>
> -
> #include "gem/i915_gem_region.h"
> #include "intel_memory_region.h"
> #include "intel_region_ttm.h"
>

2021-10-20 08:09:21

by CGEL

Subject: drm/i915: remove duplicate include in mock_region.c

From: ran jianping <[email protected]>

'drm/ttm/ttm_placement.h' included in
'drivers/gpu/drm/i915/selftests/mock_region.c' is duplicated.
It is also included on the 9 line.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ran jianping <[email protected]>
---
drivers/gpu/drm/i915/selftests/mock_region.c | 2 --
1 file changed, 2 deletion(-)

diff --git a/drivers/gpu/drm/i915/selftests/mock_region.c b/drivers/gpu/drm/i915/selftests/mock_region.c
index efa86dffe3c6..b6747b3eeac5 100644
--- a/drivers/gpu/drm/i915/selftests/mock_region.c
+++ b/drivers/gpu/drm/i915/selftests/mock_region.c
@@ -6,7 +6,5 @@
#include <drm/ttm/ttm_placement.h>
#include <linux/scatterlist.h>

-#include <drm/ttm/ttm_placement.h>
-
#include "gem/i915_gem_region.h"
#include "intel_memory_region.h"
--
2.25.1

2021-10-20 08:14:41

by Matthew Auld

Subject: Re: drm/i915: remove duplicate include in mock_region.c

On 20/10/2021 09:04, Ran Jianping wrote:
> From: ran jianping <[email protected]>
>
> 'drm/ttm/ttm_placement.h' included in
> 'drivers/gpu/drm/i915/selftests/mock_region.c' is duplicated.
> It is also included on the 9 line.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: ran jianping <[email protected]>

Pushed to drm-intel-gt-next. Thanks.

> ---
> drivers/gpu/drm/i915/selftests/mock_region.c | 2 --
> 1 file changed, 2 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/mock_region.c b/drivers/gpu/drm/i915/selftests/mock_region.c
> index efa86dffe3c6..b6747b3eeac5 100644
> --- a/drivers/gpu/drm/i915/selftests/mock_region.c
> +++ b/drivers/gpu/drm/i915/selftests/mock_region.c
> @@ -6,7 +6,5 @@
> #include <drm/ttm/ttm_placement.h>
> #include <linux/scatterlist.h>
>
> -#include <drm/ttm/ttm_placement.h>
> -
> #include "gem/i915_gem_region.h"
> #include "intel_memory_region.h"
>