2021-05-21 21:06:03

by Doug Anderson

Subject: [PATCH 1/2] nvmem: core: constify nvmem_cell_read_variable_common() return value

The caller doesn't modify the memory pointed to by the pointer so it
can be const.

Suggested-by: Stephen Boyd <[email protected]>
Signed-off-by: Douglas Anderson <[email protected]>
---

drivers/nvmem/core.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index f9c9c9859919..4868aa876e1b 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -1609,9 +1609,9 @@ int nvmem_cell_read_u64(struct device *dev, const char *cell_id, u64 *val)
}
EXPORT_SYMBOL_GPL(nvmem_cell_read_u64);

-static void *nvmem_cell_read_variable_common(struct device *dev,
- const char *cell_id,
- size_t max_len, size_t *len)
+static const void *nvmem_cell_read_variable_common(struct device *dev,
+ const char *cell_id,
+ size_t max_len, size_t *len)
{
struct nvmem_cell *cell;
int nbits;
@@ -1655,7 +1655,7 @@ int nvmem_cell_read_variable_le_u32(struct device *dev, const char *cell_id,
u32 *val)
{
size_t len;
- u8 *buf;
+ const u8 *buf;
int i;

buf = nvmem_cell_read_variable_common(dev, cell_id, sizeof(*val), &len);
@@ -1686,7 +1686,7 @@ int nvmem_cell_read_variable_le_u64(struct device *dev, const char *cell_id,
u64 *val)
{
size_t len;
- u8 *buf;
+ const u8 *buf;
int i;

buf = nvmem_cell_read_variable_common(dev, cell_id, sizeof(*val), &len);
--
2.31.1.818.g46aad6cb9e-goog

2021-05-21 22:04:46

by Stephen Boyd

Subject: Re: [PATCH 1/2] nvmem: core: constify nvmem_cell_read_variable_common() return value

Quoting Douglas Anderson (2021-05-21 14:00:57)
> The caller doesn't modify the memory pointed to by the pointer so it
> can be const.
>
> Suggested-by: Stephen Boyd <[email protected]>
> Signed-off-by: Douglas Anderson <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

2021-05-28 11:35:41

by Srinivas Kandagatla

Subject: Re: [PATCH 1/2] nvmem: core: constify nvmem_cell_read_variable_common() return value

On 21/05/2021 22:00, Douglas Anderson wrote:
> The caller doesn't modify the memory pointed to by the pointer so it
> can be const.
>
> Suggested-by: Stephen Boyd <[email protected]>
> Signed-off-by: Douglas Anderson <[email protected]>
> ---
>

Applied both thanks,

--srini
> drivers/nvmem/core.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index f9c9c9859919..4868aa876e1b 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -1609,9 +1609,9 @@ int nvmem_cell_read_u64(struct device *dev, const char *cell_id, u64 *val)
> }
> EXPORT_SYMBOL_GPL(nvmem_cell_read_u64);
>
> -static void *nvmem_cell_read_variable_common(struct device *dev,
> - const char *cell_id,
> - size_t max_len, size_t *len)
> +static const void *nvmem_cell_read_variable_common(struct device *dev,
> + const char *cell_id,
> + size_t max_len, size_t *len)
> {
> struct nvmem_cell *cell;
> int nbits;
> @@ -1655,7 +1655,7 @@ int nvmem_cell_read_variable_le_u32(struct device *dev, const char *cell_id,
> u32 *val)
> {
> size_t len;
> - u8 *buf;
> + const u8 *buf;
> int i;
>
> buf = nvmem_cell_read_variable_common(dev, cell_id, sizeof(*val), &len);
> @@ -1686,7 +1686,7 @@ int nvmem_cell_read_variable_le_u64(struct device *dev, const char *cell_id,
> u64 *val)
> {
> size_t len;
> - u8 *buf;
> + const u8 *buf;
> int i;
>
> buf = nvmem_cell_read_variable_common(dev, cell_id, sizeof(*val), &len);
>