2019-03-09 03:33:01

by Kangjie Lu

Subject: [PATCH] net: ixgbevf: fix a missing check of ixgbevf_write_msg_read_ack

If ixgbevf_write_msg_read_ack fails, return its error code upstream

Signed-off-by: Kangjie Lu <[email protected]>
---
drivers/net/ethernet/intel/ixgbevf/vf.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c
index cd3b81300cc7..d5ce49636548 100644
--- a/drivers/net/ethernet/intel/ixgbevf/vf.c
+++ b/drivers/net/ethernet/intel/ixgbevf/vf.c
@@ -508,9 +508,8 @@ static s32 ixgbevf_update_mc_addr_list_vf(struct ixgbe_hw *hw,
vector_list[i++] = ixgbevf_mta_vector(hw, ha->addr);
}

- ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, IXGBE_VFMAILBOX_SIZE);
-
- return 0;
+ return ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf,
+ IXGBE_VFMAILBOX_SIZE);
}

/**
--
2.17.1

2019-03-21 22:40:24

by Bowers, AndrewX

Subject: RE: [Intel-wired-lan] [PATCH] net: ixgbevf: fix a missing check of ixgbevf_write_msg_read_ack

> -----Original Message-----
> From: Intel-wired-lan [mailto:[email protected]] On
> Behalf Of Kangjie Lu
> Sent: Friday, March 8, 2019 7:31 PM
> To: [email protected]
> Cc: [email protected]; [email protected]; intel-wired-
> [email protected]; [email protected]; David S. Miller
> <[email protected]>
> Subject: [Intel-wired-lan] [PATCH] net: ixgbevf: fix a missing check of
> ixgbevf_write_msg_read_ack
>
> If ixgbevf_write_msg_read_ack fails, return its error code upstream
>
> Signed-off-by: Kangjie Lu <[email protected]>
> ---
> drivers/net/ethernet/intel/ixgbevf/vf.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)

Tested-by: Andrew Bowers <[email protected]>