2019-05-28 11:59:30

by Young Xiao

Subject: [PATCH] ixgbevf: fix possible divide by zero in ixgbevf_update_itr

The next call to ixgbevf_update_itr will continue to dynamically
update ITR.

Copy from commit bdbeefe8ea8c ("ixgbe: fix possible divide by zero in
ixgbe_update_itr")

Signed-off-by: Young Xiao <[email protected]>
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index d189ed2..d2b41f9 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -1423,6 +1423,9 @@ static void ixgbevf_update_itr(struct ixgbevf_q_vector *q_vector,
*/
/* what was last interrupt timeslice? */
timepassed_us = q_vector->itr >> 2;
+ if (timepassed_us == 0)
+ return;
+
bytes_perint = bytes / timepassed_us; /* bytes/usec */

switch (itr_setting) {
--
2.7.4

2019-06-13 21:31:27

by Bowers, AndrewX

Subject: RE: [Intel-wired-lan] [PATCH] ixgbevf: fix possible divide by zero in ixgbevf_update_itr

> -----Original Message-----
> From: Intel-wired-lan [mailto:[email protected]] On
> Behalf Of Young Xiao
> Sent: Tuesday, May 28, 2019 4:58 AM
> To: Kirsher, Jeffrey T <[email protected]>; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]
> Cc: Young Xiao <[email protected]>
> Subject: [Intel-wired-lan] [PATCH] ixgbevf: fix possible divide by zero in
> ixgbevf_update_itr
>
> The next call to ixgbevf_update_itr will continue to dynamically update ITR.
>
> Copy from commit bdbeefe8ea8c ("ixgbe: fix possible divide by zero in
> ixgbe_update_itr")
>
> Signed-off-by: Young Xiao <[email protected]>
> ---
> drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 +++
> 1 file changed, 3 insertions(+)

Tested-by: Andrew Bowers <[email protected]>