2024-03-07 17:00:12

by Andy Shevchenko

Subject: [PATCH v1 1/3] spi: xilinx: Fix kernel documentation in the xilinx_spi.h

While updating the data structure layout the kernel documentation
became outdated. Synchronize kernel documentation with the actual
data structure layout.

Fixes: 1dd46599f83a ("spi: xilinx: add force_irq for QSPI mode")
Fixes: 082339bc63cc ("spi: spi-xilinx: Add run run-time endian detection")
Signed-off-by: Andy Shevchenko <[email protected]>
---
include/linux/spi/xilinx_spi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h
index 3934ce789d87..fd6add419e94 100644
--- a/include/linux/spi/xilinx_spi.h
+++ b/include/linux/spi/xilinx_spi.h
@@ -5,10 +5,10 @@
/**
* struct xspi_platform_data - Platform data of the Xilinx SPI driver
* @num_chipselect: Number of chip select by the IP.
- * @little_endian: If registers should be accessed little endian or not.
* @bits_per_word: Number of bits per word.
* @devices: Devices to add when the driver is probed.
* @num_devices: Number of devices in the devices array.
+ * @force_irq: If set, forces QSPI transaction requirements.
*/
struct xspi_platform_data {
u16 num_chipselect;
--
2.43.0.rc1.1.gbec44491f096

2024-03-08 08:22:29

by Michal Simek

Subject: Re: [PATCH v1 1/3] spi: xilinx: Fix kernel documentation in the xilinx_spi.h

On 3/7/24 16:43, Andy Shevchenko wrote:
> While updating the data structure layout the kernel documentation
> became outdated. Synchronize kernel documentation with the actual
> data structure layout.
>
> Fixes: 1dd46599f83a ("spi: xilinx: add force_irq for QSPI mode")
> Fixes: 082339bc63cc ("spi: spi-xilinx: Add run run-time endian detection")
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> include/linux/spi/xilinx_spi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h
> index 3934ce789d87..fd6add419e94 100644
> --- a/include/linux/spi/xilinx_spi.h
> +++ b/include/linux/spi/xilinx_spi.h
> @@ -5,10 +5,10 @@
> /**
> * struct xspi_platform_data - Platform data of the Xilinx SPI driver
> * @num_chipselect: Number of chip select by the IP.
> - * @little_endian: If registers should be accessed little endian or not.
> * @bits_per_word: Number of bits per word.
> * @devices: Devices to add when the driver is probed.
> * @num_devices: Number of devices in the devices array.
> + * @force_irq: If set, forces QSPI transaction requirements.
> */
> struct xspi_platform_data {
> u16 num_chipselect;

Reviewed-by: Michal Simek <[email protected]>

Thanks,
Michal