2019-12-20 00:10:54

by Colin King

Subject: [PATCH] serial: ucc_uart: remove redundant assignment to pointer bdp

From: Colin Ian King <[email protected]>

The variable bdp is being initialized with a value that is never
read and it is being updated later with a new value. The initialization
is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/tty/serial/ucc_uart.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c
index afc2a5d69202..99a069ed3636 100644
--- a/drivers/tty/serial/ucc_uart.c
+++ b/drivers/tty/serial/ucc_uart.c
@@ -336,8 +336,6 @@ static int qe_uart_tx_pump(struct uart_qe_port *qe_port)
struct uart_port *port = &qe_port->port;
struct circ_buf *xmit = &port->state->xmit;

- bdp = qe_port->rx_cur;
-
/* Handle xon/xoff */
if (port->x_char) {
/* Pick next descriptor and fill from buffer */
--
2.24.0

2019-12-20 14:22:16

by Timur Tabi

Subject: Re: [PATCH] serial: ucc_uart: remove redundant assignment to pointer bdp

On 12/19/19 6:10 PM, Colin King wrote:
> From: Colin Ian King<[email protected]>
>
> The variable bdp is being initialized with a value that is never
> read and it is being updated later with a new value. The initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King<[email protected]>

Acked-by: Timur Tabi <[email protected]>

Looks like this bug has been there since day 1.