2023-10-13 15:14:30

by Rafael J. Wysocki

Subject: [PATCH v1] thermal: ACPI: Include the right header file

From: Rafael J. Wysocki <[email protected]>

It is not necessary to include thermal_core.h into thermal_acpi.c,
because none of the code in there depends on anything in the former,
except for the linux/thermal.h, but it is better to include that one
directly instead of including the entire thermal_core.h, so make that
change.

No functional impact.

Fixes: 7a0e39748861 ("thermal: ACPI: Add ACPI trip point routines")
Signed-off-by: Rafael J. Wysocki <[email protected]>
---
drivers/thermal/thermal_acpi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-pm/drivers/thermal/thermal_acpi.c
===================================================================
--- linux-pm.orig/drivers/thermal/thermal_acpi.c
+++ linux-pm/drivers/thermal/thermal_acpi.c
@@ -8,8 +8,7 @@
*/
#include <linux/acpi.h>
#include <linux/units.h>
-
-#include "thermal_core.h"
+#include <linux/thermal.h>

/*
* Minimum temperature for full military grade is 218°K (-55°C) and

2023-10-13 15:26:08

by Daniel Lezcano

Subject: Re: [PATCH v1] thermal: ACPI: Include the right header file

On 13/10/2023 17:14, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <[email protected]>
>
> It is not necessary to include thermal_core.h into thermal_acpi.c,
> because none of the code in there depends on anything in the former,
> except for the linux/thermal.h, but it is better to include that one
> directly instead of including the entire thermal_core.h, so make that
> change.
>
> No functional impact.
>
> Fixes: 7a0e39748861 ("thermal: ACPI: Add ACPI trip point routines")
> Signed-off-by: Rafael J. Wysocki <[email protected]>
> ---

Acked-by: Daniel Lezcano <[email protected]>

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog