The variable ahci_em_messages is declared static and marked
EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the
variable is not used outside of the drivers/ata/libahci.c file it is
defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.
Fixes: ed08d40cdec4 ("ahci: Changing two module params with static and __read_mostly")
Signed-off-by: Denis Efremov <[email protected]>
---
drivers/ata/libahci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index e4c45d3cca79..bff369d9a1a7 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -175,7 +175,6 @@ struct ata_port_operations ahci_pmp_retry_srst_ops = {
EXPORT_SYMBOL_GPL(ahci_pmp_retry_srst_ops);
static bool ahci_em_messages __read_mostly = true;
-EXPORT_SYMBOL_GPL(ahci_em_messages);
module_param(ahci_em_messages, bool, 0444);
/* add other LED protocol types when they become supported */
MODULE_PARM_DESC(ahci_em_messages,
--
2.21.0
> -----Original Message-----
> From: Denis Efremov [mailto:[email protected]]
> Sent: Wednesday, July 10, 2019 11:29 PM
> To: Liu, Chuansheng <[email protected]>
> Cc: Denis Efremov <[email protected]>; Jens Axboe <[email protected]>;
> [email protected]; [email protected]
> Subject: [PATCH] ahci: Remove the exporting of ahci_em_messages
>
> The variable ahci_em_messages is declared static and marked
> EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the
> variable is not used outside of the drivers/ata/libahci.c file it is
> defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.
Sounds good to me, thanks.
Reviewed-by: Chuansheng Liu <[email protected]>
Hi Jens,
On 11.07.2019 04:03, Liu, Chuansheng wrote:
>> -----Original Message-----
>> From: Denis Efremov [mailto:[email protected]]
>> Sent: Wednesday, July 10, 2019 11:29 PM
>> To: Liu, Chuansheng <[email protected]>
>> Cc: Denis Efremov <[email protected]>; Jens Axboe <[email protected]>;
>> [email protected]; [email protected]
>> Subject: [PATCH] ahci: Remove the exporting of ahci_em_messages
>>
>> The variable ahci_em_messages is declared static and marked
>> EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the
>> variable is not used outside of the drivers/ata/libahci.c file it is
>> defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.
>
> Sounds good to me, thanks.
> Reviewed-by: Chuansheng Liu <[email protected]>
>
Could you please look at this patch once again and accept it if it's ok?
static ahci_em_messages will trigger a warning after this check
will be in tree https://lkml.org/lkml/2019/7/14/118
Thanks,
Denis